From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id EC23B1B2BA for ; Tue, 13 Feb 2018 23:18:39 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Feb 2018 14:18:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,509,1511856000"; d="scan'208";a="30529767" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga001.fm.intel.com with ESMTP; 13 Feb 2018 14:18:37 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.9]) by IRSMSX154.ger.corp.intel.com ([169.254.12.108]) with mapi id 14.03.0319.002; Tue, 13 Feb 2018 22:18:36 +0000 From: "De Lara Guarch, Pablo" To: Thomas Monjalon , "matan@mellanox.com" CC: "dev@dpdk.org" , "gaetan.rivet@6wind.com" Thread-Topic: [dpdk-dev] [PATCH v2] net/failsafe: fix FreeBSD build Thread-Index: AQHTpRfvHA2WkeNhgE2lw11fVxpsq6Oi5rRw Date: Tue, 13 Feb 2018 22:18:35 +0000 Message-ID: References: <20180213213312.22225-1-thomas@monjalon.net> <20180213221324.24524-1-thomas@monjalon.net> In-Reply-To: <20180213221324.24524-1-thomas@monjalon.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWFlZTlhMDAtNzYyYS00N2ViLWE4NDAtMmY3YjJhZmRiZjIxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Im1yY1dRWlRZY1ZCYldYeHpqMlVvWEdzWHUwdWR5RFF5aURXeGtWRnFjSlE9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/failsafe: fix FreeBSD build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2018 22:18:40 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, February 13, 2018 10:13 PM > To: matan@mellanox.com > Cc: dev@dpdk.org; gaetan.rivet@6wind.com > Subject: [dpdk-dev] [PATCH v2] net/failsafe: fix FreeBSD build >=20 > The type pthread_t is not portable because it is freely defined. > On Linux, it is an unsigned long int which can be printed with %l. > On FreeBSD, it is a pointer which can be printed with %p. >=20 > That's why there was this error: > drivers/net/failsafe/failsafe_private.h:377:53: error: > format specifies type 'unsigned long' but the argument has > type 'pthread_t' (aka 'struct pthread *') >=20 > Fixes: 655fcd68c7d2 ("net/failsafe: fix hotplug races") >=20 > Reported-by: Pablo de Lara > Signed-off-by: Thomas Monjalon Tested-by: Pablo de Lara