From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 327721F28 for ; Thu, 29 Mar 2018 18:06:59 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Mar 2018 09:06:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,376,1517904000"; d="scan'208";a="216013006" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga005.fm.intel.com with ESMTP; 29 Mar 2018 09:06:56 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.155]) by IRSMSX106.ger.corp.intel.com ([169.254.8.37]) with mapi id 14.03.0319.002; Thu, 29 Mar 2018 17:06:55 +0100 From: "De Lara Guarch, Pablo" To: Jay Zhou , "dev@dpdk.org" CC: "Zhang, Roy Fan" , "thomas@monjalon.net" , "arei.gonglei@huawei.com" , "Zeng, Xin" , "weidong.huang@huawei.com" , "wangxinxin.wang@huawei.com" , "longpeng2@huawei.com" Thread-Topic: [PATCH v3 1/7] crypto/virtio: add virtio related fundamental functions Thread-Index: AQHTxBRQiFFqYMAgtkOSI2AbKY8hm6PnZi7A Date: Thu, 29 Mar 2018 16:06:55 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2YwYWZlYzctOGFmNC00MGE1LWE4OTEtOThjNTk1NjE3ZGUzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Im1sd0dJWkpjQ0dwdHZ4UHFkR3QwYWFjQjEyWUx6WkpFa3Y0ckQrV3BGbEk9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/7] crypto/virtio: add virtio related fundamental functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2018 16:07:00 -0000 Hi Jay, > -----Original Message----- > From: Jay Zhou [mailto:jianjay.zhou@huawei.com] > Sent: Sunday, March 25, 2018 9:34 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Zhang, Roy > Fan ; thomas@monjalon.net; > arei.gonglei@huawei.com; Zeng, Xin ; > weidong.huang@huawei.com; wangxinxin.wang@huawei.com; > longpeng2@huawei.com; jianjay.zhou@huawei.com > Subject: [PATCH v3 1/7] crypto/virtio: add virtio related fundamental > functions >=20 > Since there does not have the common virtio library, we have to put these > files here. They are basically the same with virtio net related files wit= h some > minor changes. >=20 > Signed-off-by: Jay Zhou > --- > config/common_base | 20 ++ > drivers/crypto/virtio/virtio_logs.h | 47 ++++ > drivers/crypto/virtio/virtio_pci.c | 460 > ++++++++++++++++++++++++++++++++++++ > drivers/crypto/virtio/virtio_pci.h | 253 ++++++++++++++++++++ > drivers/crypto/virtio/virtio_ring.h | 137 +++++++++++ > drivers/crypto/virtio/virtqueue.c | 43 ++++ > drivers/crypto/virtio/virtqueue.h | 176 ++++++++++++++ > 7 files changed, 1136 insertions(+) > create mode 100644 drivers/crypto/virtio/virtio_logs.h > create mode 100644 drivers/crypto/virtio/virtio_pci.c > create mode 100644 drivers/crypto/virtio/virtio_pci.h > create mode 100644 drivers/crypto/virtio/virtio_ring.h > create mode 100644 drivers/crypto/virtio/virtqueue.c create mode > 100644 drivers/crypto/virtio/virtqueue.h >=20 > diff --git a/config/common_base b/config/common_base index > ad03cf4..19d0cdd 100644 > --- a/config/common_base > +++ b/config/common_base > @@ -482,6 +482,26 @@ > CONFIG_RTE_LIBRTE_PMD_QAT_DEBUG_DRIVER=3Dn > CONFIG_RTE_QAT_PMD_MAX_NB_SESSIONS=3D2048 >=20 > # > +# Compile PMD for virtio crypto devices # > +CONFIG_RTE_LIBRTE_PMD_VIRTIO_CRYPTO=3Dn > +CONFIG_RTE_LIBRTE_PMD_VIRTIO_CRYPTO_DEBUG_INIT=3Dn > +CONFIG_RTE_LIBRTE_PMD_VIRTIO_CRYPTO_DEBUG_SESSION=3Dn > +CONFIG_RTE_LIBRTE_PMD_VIRTIO_CRYPTO_DEBUG_TX=3Dn > +CONFIG_RTE_LIBRTE_PMD_VIRTIO_CRYPTO_DEBUG_RX=3Dn > +CONFIG_RTE_LIBRTE_PMD_VIRTIO_CRYPTO_DEBUG_DRIVER=3Dn > +CONFIG_RTE_LIBRTE_PMD_VIRTIO_CRYPTO_DEBUG_DUMP=3Dn Could you remove these DEBUG options? I see that they are used only for ena= bling logging. For that, we are using now dynamic logging. Take a look at the following commit, as an example: 510ac6f4f030 ("event/sw: support dynamic logging") Pablo