From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 87FB54B4B for ; Fri, 30 Mar 2018 09:38:26 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Mar 2018 00:38:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,380,1517904000"; d="scan'208";a="29323670" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga007.jf.intel.com with ESMTP; 30 Mar 2018 00:38:23 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.155]) by IRSMSX103.ger.corp.intel.com ([169.254.3.61]) with mapi id 14.03.0319.002; Fri, 30 Mar 2018 08:38:22 +0100 From: "De Lara Guarch, Pablo" To: "Zhoujian (jay)" , "dev@dpdk.org" CC: "Zhang, Roy Fan" , "thomas@monjalon.net" , "Gonglei (Arei)" , "Zeng, Xin" , "Huangweidong (C)" , "wangxin (U)" , longpeng Thread-Topic: [PATCH v3 2/7] crpyto/virtio: add crypto related session structure Thread-Index: AQHTxBRWAhBMGOidcE2KhzFDe/nAEaPnzUWwgAA7lwCAAGMRkA== Date: Fri, 30 Mar 2018 07:38:21 +0000 Message-ID: References: <6d8b86abf79abf3bd72d02cadc0fc40fc8dd44c9.1521964379.git.jianjay.zhou@huawei.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTVhMjUxYTItNTNmYi00Yjg1LTkzNzctODcxNjVhMTc2NzM0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlB1MXhNNnpYeUZMUEVINW1aWVZmRkd5STlUZ05WbmdpRFhqMmQrd1JVaXc9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 2/7] crpyto/virtio: add crypto related session structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Mar 2018 07:38:27 -0000 > -----Original Message----- > From: Zhoujian (jay) [mailto:jianjay.zhou@huawei.com] > Sent: Friday, March 30, 2018 3:44 AM > To: De Lara Guarch, Pablo ; > dev@dpdk.org > Cc: Zhang, Roy Fan ; thomas@monjalon.net; > Gonglei (Arei) ; Zeng, Xin > ; Huangweidong (C) ; > wangxin (U) ; longpeng > > Subject: RE: [PATCH v3 2/7] crpyto/virtio: add crypto related session > structure >=20 >=20 >=20 > > -----Original Message----- > > From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com] > > Sent: Friday, March 30, 2018 6:12 AM > > To: Zhoujian (jay) ; dev@dpdk.org > > Cc: Zhang, Roy Fan ; thomas@monjalon.net; > > Gonglei > > (Arei) ; Zeng, Xin ; > > Huangweidong (C) ; wangxin (U) > > ; longpeng > > Subject: RE: [PATCH v3 2/7] crpyto/virtio: add crypto related session > > structure > > > > > > > > > -----Original Message----- > > > From: Jay Zhou [mailto:jianjay.zhou@huawei.com] > > > Sent: Sunday, March 25, 2018 9:34 AM > > > To: dev@dpdk.org > > > Cc: De Lara Guarch, Pablo ; Zhang, > > > Roy Fan ; thomas@monjalon.net; > > > arei.gonglei@huawei.com; Zeng, Xin ; > > > weidong.huang@huawei.com; wangxinxin.wang@huawei.com; > > > longpeng2@huawei.com; jianjay.zhou@huawei.com > > > Subject: [PATCH v3 2/7] crpyto/virtio: add crypto related session > > > structure > > > > Typo in title. >=20 > Will fix. >=20 > > > > > > > > This structure will be used in the following patches, especially at > > > creating and destroying crypto sessions. > > > > > > Signed-off-by: Jay Zhou > > > --- > > > drivers/crypto/virtio/virtio_crypto_algs.h | 27 > > > +++++++++++++++++++++++++++ > > > 1 file changed, 27 insertions(+) > > > create mode 100644 drivers/crypto/virtio/virtio_crypto_algs.h > > > > > > diff --git a/drivers/crypto/virtio/virtio_crypto_algs.h > > > b/drivers/crypto/virtio/virtio_crypto_algs.h > > > new file mode 100644 > > > index 0000000..5f1e9df > > > --- /dev/null > > > +++ b/drivers/crypto/virtio/virtio_crypto_algs.h > > > @@ -0,0 +1,27 @@ > > > +/* SPDX-License-Identifier: BSD-3-Clause > > > + * Copyright(c) 2018 HUAWEI TECHNOLOGIES CO., LTD. > > > + */ > > > + > > > +#ifndef _VIRTIO_CRYPTO_ALGS_H_ > > > +#define _VIRTIO_CRYPTO_ALGS_H_ > > > + > > > +#include > > > +#include > > > + > > > +struct virtio_crypto_session { > > > + uint64_t session_id; > > > > Probably a uint32_t here is enough. >=20 > Consider the type of session_id in the struct virtio_crypto_op_header of > linux kernel and QEMU side is uint64_t, could we just keep it as uint64_t > for consistency? Fair enough. Pablo >=20 > Regards, > Jay