From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Nicolau, Radu" <radu.nicolau@intel.com>,
Anoob Joseph <Anoob.Joseph@caviumnetworks.com>,
Akhil Goyal <akhil.goyal@nxp.com>
Cc: "Doherty, Declan" <declan.doherty@intel.com>,
Jerin Jacob <jerin.jacob@caviumnetworks.com>,
Narayana Prasad <narayanaprasad.athreya@caviumnetworks.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: remove redundant string compare
Date: Fri, 30 Mar 2018 15:42:36 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CCC2D7B@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <f5a50b6b-1c3c-6fb6-4f1d-ec76ff6b36ba@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Radu Nicolau
> Sent: Thursday, March 29, 2018 11:06 AM
> To: Anoob Joseph <Anoob.Joseph@caviumnetworks.com>; Akhil Goyal
> <akhil.goyal@nxp.com>
> Cc: Doherty, Declan <declan.doherty@intel.com>; Jerin Jacob
> <jerin.jacob@caviumnetworks.com>; Narayana Prasad
> <narayanaprasad.athreya@caviumnetworks.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: remove redundant
> string compare
>
>
> On 3/28/2018 3:28 PM, Anoob Joseph wrote:
> > Hi Akhil, Radu,
> >
> > Did you get time to review the patch?
> >
> > Thanks,
> > Anoob
> >
> > On 23/03/18 11:20, Anoob Joseph wrote:
> >> Removing redundant strncmp in parsing long arguments. The getopt
> >> library provides means to identify long options using the "val" field
> >> of structure option. The existing code gets 0 as "val" for all long
> >> arguments and then uses strncmp to figure out which long option was
> >> being referred to. Fixing this.
> >>
> >> In addition, the macros and enums used for long arguments have been
> >> renamed and repositioned adhering to the general convention followed
> >> in various other apps, like l3fwd.
> >>
> >> Signed-off-by: Anoob Joseph <anoob.joseph@caviumnetworks.com>
> >> ---
> Acked-by: Radu Nicolau <radu.nicolau@intel.com>
> <mailto:radu.nicolau@intel.com>
Applied to dpdk-next-crypto.
Thanks,
Pablo
prev parent reply other threads:[~2018-03-30 15:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 5:50 Anoob Joseph
2018-03-28 14:28 ` Anoob Joseph
2018-03-29 10:06 ` Radu Nicolau
2018-03-30 15:42 ` De Lara Guarch, Pablo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CCC2D7B@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=Anoob.Joseph@caviumnetworks.com \
--cc=akhil.goyal@nxp.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=narayanaprasad.athreya@caviumnetworks.com \
--cc=radu.nicolau@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).