DPDK patches and discussions
 help / color / mirror / Atom feed
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Jay Zhou <jianjay.zhou@huawei.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
	"thomas@monjalon.net" <thomas@monjalon.net>,
	"arei.gonglei@huawei.com" <arei.gonglei@huawei.com>,
	"Zeng, Xin" <xin.zeng@intel.com>,
	"weidong.huang@huawei.com" <weidong.huang@huawei.com>,
	"wangxinxin.wang@huawei.com" <wangxinxin.wang@huawei.com>,
	"longpeng2@huawei.com" <longpeng2@huawei.com>
Subject: Re: [dpdk-dev] [PATCH v5 0/7] crypto: add virtio poll mode driver
Date: Mon, 2 Apr 2018 11:52:33 +0000	[thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CCC3E8A@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <cover.1522487484.git.jianjay.zhou@huawei.com>

Hi Jay,

> -----Original Message-----
> From: Jay Zhou [mailto:jianjay.zhou@huawei.com]
> Sent: Saturday, March 31, 2018 10:19 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Zhang, Roy Fan
> <roy.fan.zhang@intel.com>; thomas@monjalon.net;
> arei.gonglei@huawei.com; Zeng, Xin <xin.zeng@intel.com>;
> weidong.huang@huawei.com; wangxinxin.wang@huawei.com;
> longpeng2@huawei.com; jianjay.zhou@huawei.com
> Subject: [PATCH v5 0/7] crypto: add virtio poll mode driver
> 
> This patch series introduce virtio crypto poll mode driver.
> 

Thanks for the work. As a last thing from my side,
could I ask you to enable the compilation of the driver from the beginning?
In DPDK we try to enable it from the beginning of the patchsets.
The AMD CCP PMD is a good example on how to do this and
how to split the patches in a more functional way.

Sorry for missing this earlier and giving this feedback a bit late.
Let me know if you need some help on this.

Thanks,
Pablo

  parent reply	other threads:[~2018-04-02 11:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-31  9:18 Jay Zhou
2018-03-31  9:18 ` [dpdk-dev] [PATCH v5 1/7] crypto/virtio: add virtio related fundamental functions Jay Zhou
2018-03-31  9:18 ` [dpdk-dev] [PATCH v5 2/7] crypto/virtio: add crypto related session structure Jay Zhou
2018-03-31  9:18 ` [dpdk-dev] [PATCH v5 3/7] crypto/virtio: core code of virtio crypto PMD Jay Zhou
2018-03-31  9:18 ` [dpdk-dev] [PATCH v5 4/7] crypto/virtio: add makefile Jay Zhou
2018-03-31  9:18 ` [dpdk-dev] [PATCH v5 5/7] doc: add virtio crypto PMD guide Jay Zhou
2018-03-31  9:18 ` [dpdk-dev] [PATCH v5 6/7] test/crypto: add function tests for virtio crypto PMD Jay Zhou
2018-03-31  9:18 ` [dpdk-dev] [PATCH v5 7/7] MAINTAINERS: add myself as virtio crypto PMD maintainer Jay Zhou
2018-04-02 11:52 ` De Lara Guarch, Pablo [this message]
2018-04-02 12:10   ` [dpdk-dev] [PATCH v5 0/7] crypto: add virtio poll mode driver Zhoujian (jay)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CCC3E8A@IRSMSX108.ger.corp.intel.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=arei.gonglei@huawei.com \
    --cc=dev@dpdk.org \
    --cc=jianjay.zhou@huawei.com \
    --cc=longpeng2@huawei.com \
    --cc=roy.fan.zhang@intel.com \
    --cc=thomas@monjalon.net \
    --cc=wangxinxin.wang@huawei.com \
    --cc=weidong.huang@huawei.com \
    --cc=xin.zeng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).