From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 0B751AAA4 for ; Mon, 16 Apr 2018 16:15:59 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2018 07:15:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,459,1517904000"; d="scan'208";a="191877888" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga004.jf.intel.com with ESMTP; 16 Apr 2018 07:15:55 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.155]) by IRSMSX102.ger.corp.intel.com ([169.254.2.164]) with mapi id 14.03.0319.002; Mon, 16 Apr 2018 15:15:54 +0100 From: "De Lara Guarch, Pablo" To: Jay Zhou , "dev@dpdk.org" CC: "Zhang, Roy Fan" , "thomas@monjalon.net" , "arei.gonglei@huawei.com" , "Zeng, Xin" , "weidong.huang@huawei.com" , "wangxinxin.wang@huawei.com" , "longpeng2@huawei.com" Thread-Topic: [PATCH v10 01/10] crypto/virtio: add virtio crypto PMD Thread-Index: AQHT1SmvFxXT3Qlwj0K15Oq4b5yafKQDaoqg Date: Mon, 16 Apr 2018 14:15:54 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzVhMWFiZDMtNzc2Ni00ZjYyLWJkMTUtYmZjYzQ4NWE0ZmExIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkRoT0pSMTljZ0p6Wk1DT2RaQnFlalNyWEpmOERKR3FEVUtVdVU3K3JFZ1E9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v10 01/10] crypto/virtio: add virtio crypto PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 14:16:00 -0000 Hi Jay, > -----Original Message----- > From: Jay Zhou [mailto:jianjay.zhou@huawei.com] > Sent: Monday, April 16, 2018 3:21 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Zhang, Roy Fa= n > ; thomas@monjalon.net; > arei.gonglei@huawei.com; Zeng, Xin ; > weidong.huang@huawei.com; wangxinxin.wang@huawei.com; > longpeng2@huawei.com; jianjay.zhou@huawei.com > Subject: [PATCH v10 01/10] crypto/virtio: add virtio crypto PMD >=20 > The virtio crypto device is a virtual cryptography device as well as a ki= nd of > virtual hardware accelerator for virtual machines. The linux kernel virti= o-crypto > driver has been merged, and this patch introduces virtio crypto PMD to ac= hieve > better performance. >=20 > Signed-off-by: Jay Zhou > Reviewed-by: Fan Zhang > Acked-by: Fan Zhang ... > +++ b/drivers/crypto/virtio/meson.build > @@ -0,0 +1,11 @@ > +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 HUAWEI > +TECHNOLOGIES CO., LTD. > + > +dep =3D dependency('libcrypto', required: false) if not dep.found() > + build =3D false > +endif Does this PMD have a dependency on libcrypto? Looking at the code, I don't think it does. Therefore, you should remove this and also LDLIBS +=3D -lcrypto in the Make= file. Once this is removed, and you add the path to the virtio_crypto.h file (as = Ferruh suggested), I'd say this PMD can be enabled by default.