From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 49A0CAAD1 for ; Mon, 16 Apr 2018 16:20:47 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2018 07:20:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,459,1517904000"; d="scan'208";a="220814540" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga006.fm.intel.com with ESMTP; 16 Apr 2018 07:20:44 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.155]) by IRSMSX101.ger.corp.intel.com ([169.254.1.176]) with mapi id 14.03.0319.002; Mon, 16 Apr 2018 15:20:44 +0100 From: "De Lara Guarch, Pablo" To: "Kumar, Ravi1" , "dev@dpdk.org" CC: "hemant.agrawal@nxp.com" Thread-Topic: [PATCH v5 01/19] crypto/ccp: add AMD ccp skeleton PMD Thread-Index: AQHTv31EqdLy4kwWa0GwR68nW9WH1KPpcjPwgAOLD4CAFp61wA== Date: Mon, 16 Apr 2018 14:20:43 +0000 Message-ID: References: <1520584520-130522-1-git-send-email-Ravi1.kumar@amd.com> <1521462233-13590-1-git-send-email-Ravi1.kumar@amd.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTI4Y2YzYzgtZDcxMS00MjExLWE3YmYtNWRmMTgyYmI3NTUwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InBpU2VJMUxURm1LYnFkY09oT3JidmNyUTBGa3FUd29nTEpYbE9OY3BwVnM9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 01/19] crypto/ccp: add AMD ccp skeleton PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 14:20:47 -0000 Hi Ravi, > -----Original Message----- > From: Kumar, Ravi1 [mailto:Ravi1.Kumar@amd.com] > Sent: Monday, April 2, 2018 6:50 AM > To: De Lara Guarch, Pablo ; dev@dpdk.org > Cc: hemant.agrawal@nxp.com > Subject: RE: [PATCH v5 01/19] crypto/ccp: add AMD ccp skeleton PMD >=20 > > > > > >> -----Original Message----- > >> From: Ravi Kumar [mailto:Ravi1.kumar@amd.com] > >> Sent: Monday, March 19, 2018 12:24 PM > >> To: dev@dpdk.org > >> Cc: De Lara Guarch, Pablo ; > >> hemant.agrawal@nxp.com > >> Subject: [PATCH v5 01/19] crypto/ccp: add AMD ccp skeleton PMD > >> > >> Signed-off-by: Ravi Kumar > > > >Patchset applied to dpdk-next-crypto, with same minor changes (title cha= nges > and driver registering modification due to an earlier patch). > > > >Thanks for the work! > >Pablo > > There's been a memory rework applied in DPDK at the same time I applied you= r PMD in next-crypto, Which means that it is broken now. Could you submit a fix for it? At least, compilation is broken now, but it may require more changes: drivers/crypto/ccp/ccp_dev.c:98:7: error: implicit declaration of function = 'rte_eal_get_physmem_layout' is invalid in C99 [-Werror,-Wimplicit-function-declaration] ms =3D rte_eal_get_physmem_layout(); This function does not exist anymore. Commit 2d84772bf858 ("crypto/qat: use contiguous allocation for DMA memory"= ) makes a similar required changed in QAT. Take a look at it and see if it suits you. >=20 > Thanks a lot Pablo. >=20 > Regards, > Ravi