Re: [dpdk-dev] [PATCH 4/4] crypto/dpaa_sec: update maximum queue pairs to 2

["De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>]

> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Friday, April 20, 2018 11:40 AM
> To: Hemant Agrawal <hemant.agrawal@nxp.com>; dev@dpdk.org; De Lara
> Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: Nipun Gupta <nipun.gupta@nxp.com>
> Subject: Re: [PATCH 4/4] crypto/dpaa_sec: update maximum queue pairs to 2
> 
> Hi Hemant,
> On 4/20/2018 3:53 PM, Hemant Agrawal wrote:
> >
> >
> >> Hi Hemant/Nipun
> >> On 4/19/2018 10:22 PM, Hemant Agrawal wrote:
> >>> From: Nipun Gupta <nipun.gupta@nxp.com>
> >>>
> >>> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
> >>> ---
> >>>  drivers/crypto/dpaa_sec/dpaa_sec.h | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.h
> >>> b/drivers/crypto/dpaa_sec/dpaa_sec.h
> >>> index 1433595..5b25aa1 100644
> >>> --- a/drivers/crypto/dpaa_sec/dpaa_sec.h
> >>> +++ b/drivers/crypto/dpaa_sec/dpaa_sec.h
> >>> @@ -136,7 +136,7 @@ struct dpaa_sec_qp {
> >>>  	int tx_errs;
> >>>  };
> >>>
> >>> -#define RTE_DPAA_MAX_NB_SEC_QPS 1
> >>> +#define RTE_DPAA_MAX_NB_SEC_QPS 2
> >>>  #define RTE_DPAA_MAX_RX_QUEUE
> >> RTE_DPAA_SEC_PMD_MAX_NB_SESSIONS
> >>> #define DPAA_MAX_DEQUEUE_NUM_FRAMES 63
> >>>
> >>>
> >> Why 2? I think it should be 8.
> >>
> > [Hemant] Ok. Sending v2
> 
> I guess this need some testing whether it will break the existing use cases or not.
> 
> Pablo,
> 
> I recommend, it would be good if you can apply the other 3 patches in this series
> in RC1. This patch should be hold back for RC2.

Good to me.
Thanks,
Pablo

> 
> Thanks,
> Akhil