From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pablo.de.lara.guarch@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 9EC9B2C12
 for <dev@dpdk.org>; Mon, 23 Apr 2018 12:24:34 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 23 Apr 2018 03:24:33 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.49,317,1520924400"; d="scan'208";a="45331835"
Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75])
 by orsmga003.jf.intel.com with ESMTP; 23 Apr 2018 03:24:32 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.155]) by
 IRSMSX153.ger.corp.intel.com ([169.254.9.3]) with mapi id 14.03.0319.002;
 Mon, 23 Apr 2018 11:24:31 +0100
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, "Chalupnik, KamilX"
 <kamilx.chalupnik@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Mokhtar, Amr" <amr.mokhtar@intel.com>
Thread-Topic: [dpdk-dev] [PATCH] doc: update bbdev library documentation
Thread-Index: AQHTzB4rveTR8rK6jUCiWuW6sy9a66QNRMIAgAD8jWA=
Date: Mon, 23 Apr 2018 10:24:30 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CCDA883@IRSMSX108.ger.corp.intel.com>
References: <20180404140602.9344-1-kamilx.chalupnik@intel.com>
 <2713250.YhKZBbbERd@xps>
In-Reply-To: <2713250.YhKZBbbERd@xps>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjYxYTk2ZDQtYjg2OS00Yzk1LWI0YzItYWI2MTFlY2NhNjEzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik1vemhSK3paelNKZTdFT2lkKzRsaGkwV1MzNnljYldzSnFoa1piNEcydjg9In0=
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.200.100
dlp-reaction: no-action
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] doc: update bbdev library documentation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Apr 2018 10:24:35 -0000



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Sunday, April 22, 2018 9:17 PM
> To: Chalupnik, KamilX <kamilx.chalupnik@intel.com>
> Cc: dev@dpdk.org; Mokhtar, Amr <amr.mokhtar@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] doc: update bbdev library documentation
>=20
> Hi,
>=20
> 04/04/2018 16:05, KamilX Chalupnik:
> > From: "Chalupnik, KamilX" <kamilx.chalupnik@intel.com>
>=20
> The above line will appear as the author name in Git.
> Please make sure it is the same as the Signed-off-by line.
> Usually, we use FirstName LastName, without any comma.
>=20
>=20
> > Update the documentation describing Wireless Basband Device:
> > - device capabilities updated
> > - input/output data buffers description added
> > - details about implementation of turbo encode/decode
> >   operation added
> > - images presenting CB/TB processing by turbo encoder/decoder
> >   added
> >
> > Signed-off-by: KamilX Chalupnik <kamilx.chalupnik@intel.com>
>=20
> Is KamilX your name? Or just Kamil?
>=20
>=20
> >  doc/guides/prog_guide/bbdev.rst               | 247 ++++++++++++++++++=
+++++--
> -
> >  doc/guides/prog_guide/img/turbo_tb_decode.png | Bin 0 -> 43552 bytes
> > doc/guides/prog_guide/img/turbo_tb_encode.png | Bin 0 -> 46944 bytes
> >  3 files changed, 222 insertions(+), 25 deletions(-)  create mode
> > 100644 doc/guides/prog_guide/img/turbo_tb_decode.png
> >  create mode 100644 doc/guides/prog_guide/img/turbo_tb_encode.png
>=20
> No, sorry, you cannot add binary file in this repository.
> It is an Open Source project, we provide sources.
> For figures, the SVG format is preferred.
>=20
> I'm sorry that your Intel colleagues did not warn you.
>=20

Thomas is right. I should have spotted this, sorry about it.
Will drop this from next-crypto subtree, so this patch requires a v2.
Once it is sent, addressing Thomas' comments, it may be applied.

Apologies for the confusion,
Pablo