From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 847B5DED for ; Tue, 24 Apr 2018 10:56:18 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2018 01:56:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,322,1520924400"; d="scan'208";a="193916021" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga004.jf.intel.com with ESMTP; 24 Apr 2018 01:56:15 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.155]) by IRSMSX104.ger.corp.intel.com ([169.254.5.171]) with mapi id 14.03.0319.002; Tue, 24 Apr 2018 09:56:14 +0100 From: "De Lara Guarch, Pablo" To: "Daly, Lee" , "dev@dpdk.org" CC: "Tucker, Greg B" , "Jain, Deepak K" , "Trahe, Fiona" Thread-Topic: [PATCH v3 01/11] compress/isal: add skeleton ISA-L compression PMD Thread-Index: AQHT1lEGm9Dy1dYujUqvTlfAsUSsYKQPnFQw Date: Tue, 24 Apr 2018 08:56:14 +0000 Message-ID: References: <1523038388-29964-1-git-send-email-lee.daly@intel.com> <1523972132-6894-1-git-send-email-lee.daly@intel.com> <1523972132-6894-2-git-send-email-lee.daly@intel.com> In-Reply-To: <1523972132-6894-2-git-send-email-lee.daly@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjhiNGJmYTgtMTg4NS00ODVjLWE2MGMtYjU1MTgxZDY4ZWQxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IllcL1hBT1IrMzMzd1lvWDBTMUxTazVhSm81M0M5TkJ4R21KcmhjRFV2YWJFPSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 01/11] compress/isal: add skeleton ISA-L compression PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2018 08:56:20 -0000 Hi Lee, > -----Original Message----- > From: Daly, Lee > Sent: Tuesday, April 17, 2018 2:35 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Tucker, Greg = B > ; Jain, Deepak K ; Trah= e, > Fiona ; Daly, Lee > Subject: [PATCH v3 01/11] compress/isal: add skeleton ISA-L compression P= MD >=20 Add some explanation on the commit message about the patch (especially for = this one, where you are introducing the PMD). Same applies for the other commits. > Signed-off-by: Lee Daly > --- > config/common_base | 5 +++++ > doc/guides/rel_notes/release_18_05.rst | 6 ++++++ > drivers/Makefile | 2 ++ > drivers/compress/Makefile | 8 +++++++ > drivers/compress/isal/Makefile | 30 ++++++++++++++++++++= ++++++ > drivers/compress/isal/isal_compress_pmd.c | 29 > +++++++++++++++++++++++++ > drivers/compress/isal/meson.build | 14 ++++++++++++ > drivers/compress/isal/rte_pmd_isal_version.map | 3 +++ > drivers/compress/meson.build | 8 +++++++ > drivers/meson.build | 1 + > mk/rte.app.mk | 5 +++++ > 11 files changed, 111 insertions(+) > create mode 100644 drivers/compress/Makefile create mode 100644 > drivers/compress/isal/Makefile create mode 100644 > drivers/compress/isal/isal_compress_pmd.c > create mode 100644 drivers/compress/isal/meson.build create mode 100644 > drivers/compress/isal/rte_pmd_isal_version.map > create mode 100644 drivers/compress/meson.build >=20 > diff --git a/config/common_base b/config/common_base index > 5053c89..0992fe1 100644 > --- a/config/common_base > +++ b/config/common_base > @@ -557,6 +557,11 @@ CONFIG_RTE_LIBRTE_COMPRESSDEV=3Dy > CONFIG_RTE_COMPRESS_MAX_DEVS=3D64 >=20 > # > +# Compile PMD for ISA-L compression device # > +CONFIG_RTE_LIBRTE_PMD_ISAL=3Dn > + > +# > # Compile generic event device library > # > CONFIG_RTE_LIBRTE_EVENTDEV=3Dy > diff --git a/doc/guides/rel_notes/release_18_05.rst > b/doc/guides/rel_notes/release_18_05.rst > index 5193a62..fa0a624 100644 > --- a/doc/guides/rel_notes/release_18_05.rst > +++ b/doc/guides/rel_notes/release_18_05.rst > @@ -75,6 +75,12 @@ New Features > The compressdev library provides an API for offload of compression and > decompression operations to hardware or software accelerator devices. >=20 > +* **Added a new compression poll mode driver using Intels ISA-L.** > + > + Added the new ``ISA-L`` compression driver. See the > + :doc:`../compressdevs/isal` compression driver guide for more details= on > + this new driver. The reference to the document is not yet available, so remove it from here = and add it in the last patch. > diff --git a/drivers/compress/isal/isal_compress_pmd.c > b/drivers/compress/isal/isal_compress_pmd.c > new file mode 100644 > index 0000000..d7137fd > --- /dev/null > +++ b/drivers/compress/isal/isal_compress_pmd.c > @@ -0,0 +1,29 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2018 Intel Corporation > + */ > + > +#include > +#include > + > +/** Remove compression device */ > +static int > +compdev_isal_remove_dev(struct rte_vdev_device *vdev __rte_unused) { > + return 0; > +} > + > +/** Initialise ISA-L compression device */ static int > +compdev_isal_probe(struct rte_vdev_device *dev __rte_unused) { > + return 0; > +} > + > +static struct rte_vdev_driver compdev_isal_pmd_drv =3D { > + .probe =3D compdev_isal_probe, > + .remove =3D compdev_isal_remove_dev, > +}; > + > +RTE_PMD_REGISTER_VDEV(COMPDEV_NAME_ISAL_PMD, > compdev_isal_pmd_drv); > +RTE_PMD_REGISTER_PARAM_STRING(COMPDEV_NAME_ISAL_PMD, > + "socket_id=3D"); > diff --git a/drivers/compress/isal/meson.build > b/drivers/compress/isal/meson.build > new file mode 100644 > index 0000000..4447e20 > --- /dev/null > +++ b/drivers/compress/isal/meson.build > @@ -0,0 +1,14 @@ > +# SPDX-License-Identifier: BSD-3-Clause # Copyright 2018 Intel > +Corporation > + > +dep =3D dependency('libisal', required: false) if not dep.found() > + build =3Dfalse > +endif > + > +deps +=3D 'bus_vdev' > +sources =3D files('isal_compress_pmd.c') > +ext_deps +=3D dep > +pkgconfig_extra_libs +=3D '-lisal' > + > +allow_experimental_apis =3D true > diff --git a/drivers/compress/isal/rte_pmd_isal_version.map > b/drivers/compress/isal/rte_pmd_isal_version.map > new file mode 100644 > index 0000000..de8e412 > --- /dev/null > +++ b/drivers/compress/isal/rte_pmd_isal_version.map > @@ -0,0 +1,3 @@ > +DPDK_18.05 { > + local: *; > +}; > diff --git a/drivers/compress/meson.build b/drivers/compress/meson.build = new > file mode 100644 index 0000000..fb136e1 > --- /dev/null > +++ b/drivers/compress/meson.build > @@ -0,0 +1,8 @@ > +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Intel > +Corporation > + > +drivers =3D ['isal'] > + > +std_deps =3D ['compressdev'] # compressdev pulls in all other needed dep= s > +config_flag_fmt =3D 'RTE_LIBRTE_@0@_PMD' > +driver_name_fmt =3D 'rte_pmd_@0@' > diff --git a/drivers/meson.build b/drivers/meson.build index b146f09..ac7= ba5e > 100644 > --- a/drivers/meson.build > +++ b/drivers/meson.build > @@ -7,6 +7,7 @@ driver_classes =3D ['common', > 'mempool', # depends on common and bus. > 'net', # depends on common, bus and mempool. > 'crypto', # depends on common, bus and mempool (net in future). > + 'compress', # depends on bus, mempool. > 'event'] # depends on common, bus, mempool and net. >=20 > foreach class:driver_classes > diff --git a/mk/rte.app.mk b/mk/rte.app.mk index 8530ac5..7a6739c 100644 > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -228,6 +228,11 @@ endif # CONFIG_RTE_LIBRTE_DPAA_BUS >=20 > endif # CONFIG_RTE_LIBRTE_CRYPTODEV >=20 > +ifeq ($(CONFIG_RTE_LIBRTE_COMPRESSDEV),y) > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_ISAL) +=3D -lrte_pmd_isal_comp > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_ISAL) +=3D -lisal endif # > +CONFIG_RTE_LIBRTE_COMPRESSDEV > + > ifeq ($(CONFIG_RTE_LIBRTE_EVENTDEV),y) > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SKELETON_EVENTDEV) +=3D - > lrte_pmd_skeleton_event > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SW_EVENTDEV) +=3D -lrte_pmd_sw_event > -- > 2.7.4