From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id B7DDBA69 for ; Tue, 24 Apr 2018 11:21:12 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2018 02:21:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,322,1520924400"; d="scan'208";a="222865836" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga005.fm.intel.com with ESMTP; 24 Apr 2018 02:21:11 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.155]) by IRSMSX103.ger.corp.intel.com ([169.254.3.61]) with mapi id 14.03.0319.002; Tue, 24 Apr 2018 10:21:10 +0100 From: "De Lara Guarch, Pablo" To: "Daly, Lee" , "dev@dpdk.org" CC: "Tucker, Greg B" , "Jain, Deepak K" , "Trahe, Fiona" Thread-Topic: [PATCH v3 02/11] compress/isal: add pmd device init and de-init Thread-Index: AQHT1lEGetZsa/v2lkK0CHYwF3dMKaQPqFcQ Date: Tue, 24 Apr 2018 09:21:09 +0000 Message-ID: References: <1523038388-29964-1-git-send-email-lee.daly@intel.com> <1523972132-6894-1-git-send-email-lee.daly@intel.com> <1523972132-6894-3-git-send-email-lee.daly@intel.com> In-Reply-To: <1523972132-6894-3-git-send-email-lee.daly@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2IxNGI2MmYtZjczOS00ZDNjLWExZDUtODIyOGQwNzM0OTI1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InRaY0s0ZUxmR0Y3VUF3RlJLVFpKOEhpc1JlY2g4b1cydGhnQ1Q3NmlrNGs9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 02/11] compress/isal: add pmd device init and de-init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2018 09:21:13 -0000 > -----Original Message----- > From: Daly, Lee > Sent: Tuesday, April 17, 2018 2:35 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Tucker, Greg = B > ; Jain, Deepak K ; Trah= e, > Fiona ; Daly, Lee > Subject: [PATCH v3 02/11] compress/isal: add pmd device init and de-init >=20 > Signed-off-by: Lee Daly ... > +++ b/drivers/compress/isal/isal_compress_pmd.c > @@ -3,20 +3,102 @@ > */ >=20 > #include > +#include > +#include > #include >=20 > +#include "isal_compress_pmd_private.h" > + > +int isal_logtype_driver; > + > +/* Enqueue burst */ > +static uint16_t > +isal_comp_pmd_enqueue_burst(void *queue_pair __rte_unused, > + struct rte_comp_op **ops __rte_unused, > + uint16_t nb_ops __rte_unused) > +{ > + uint16_t num_enq =3D 0; > + > + return num_enq; > +} > + > +/* Dequeue burst */ > +static uint16_t > +isal_comp_pmd_dequeue_burst(void *queue_pair __rte_unused, > + struct rte_comp_op **ops __rte_unused, > + uint16_t nb_ops __rte_unused) > +{ > + uint16_t nb_dequeued =3D 0; > + > + return nb_dequeued; > +} Since you have a separate patch implementing these two functions (enqueue/d= equeuer), I would directly declare them in that patch. Therefore, also remove the fun= ction pointers setting in compdev_isal_create and leave it for that patch. > + > +/* Create ISA-L compression device */ > +static int > +compdev_isal_create(const char *name, struct rte_vdev_device *vdev, > + struct rte_compressdev_pmd_init_params *init_params) { > + struct rte_compressdev *dev; > + > + dev =3D rte_compressdev_pmd_create(name, &vdev->device, > + sizeof(struct isal_comp_private), init_params); > + if (dev =3D=3D NULL) { > + ISAL_PMD_LOG(ERR, "failed to create compressdev vdev"); > + return -EFAULT; > + } > + > + dev->dev_ops =3D isal_compress_pmd_ops; > + > + /* register rx/tx burst functions for data path */ > + dev->dequeue_burst =3D isal_comp_pmd_dequeue_burst; > + dev->enqueue_burst =3D isal_comp_pmd_enqueue_burst; > + > + return 0;