From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 488AE23D for ; Tue, 24 Apr 2018 16:10:39 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2018 07:10:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,323,1520924400"; d="scan'208";a="222957088" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by fmsmga006.fm.intel.com with ESMTP; 24 Apr 2018 07:10:37 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.155]) by irsmsx105.ger.corp.intel.com ([169.254.7.163]) with mapi id 14.03.0319.002; Tue, 24 Apr 2018 15:10:36 +0100 From: "De Lara Guarch, Pablo" To: "Chalupnik, KamilX" , "dev@dpdk.org" CC: "Mokhtar, Amr" , "Chalupnik, KamilX" Thread-Topic: [dpdk-dev] [PATCH v2] app/bbdev: remove improper WARNING printouts Thread-Index: AQHT1veWV5yDTNe3kkeHA0Bzagx/JKQP+utg Date: Tue, 24 Apr 2018 14:10:36 +0000 Message-ID: References: <20180404140602.9344-6-kamilx.chalupnik@intel.com> <20180418092616.33568-1-kamilx.chalupnik@intel.com> In-Reply-To: <20180418092616.33568-1-kamilx.chalupnik@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjY0NzMyZjEtNDNlMy00ZWQyLWJiMWYtYjM3MDM4NjBlNzBkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IldIUTFJZ1BTbkI0SVhnbDVVZEFWUkNBM1NUN2IrXC9Ga2hZcGtUODVEKzhjPSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] app/bbdev: remove improper WARNING printouts X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2018 14:10:40 -0000 Hi Kamil, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of KamilX Chalupnik > Sent: Wednesday, April 18, 2018 10:26 AM > To: dev@dpdk.org > Cc: Mokhtar, Amr ; Chalupnik, KamilX > > Subject: [dpdk-dev] [PATCH v2] app/bbdev: remove improper WARNING > printouts >=20 > Improper WARNING printouts in BBDev Test Application removed >=20 > Signed-off-by: KamilX Chalupnik >=20 > v2: > - apply patch failure fixed >=20 > --- > app/test-bbdev/test_bbdev_perf.c | 2 +- > app/test-bbdev/test_bbdev_vector.c | 12 ++++++------ > 2 files changed, 7 insertions(+), 7 deletions(-) >=20 > diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test- > bbdev/test_bbdev_perf.c > index 00f3b08..84a5393 100644 > --- a/app/test-bbdev/test_bbdev_perf.c > +++ b/app/test-bbdev/test_bbdev_perf.c > @@ -138,7 +138,7 @@ check_dev_cap(const struct rte_bbdev_info *dev_info) > !(cap->capability_flags & > RTE_BBDEV_TURBO_SOFT_OUTPUT)) { > printf( > - "WARNING: Device \"%s\" does not > support soft output - soft output flags will be ignored.\n", > + "INFO: Device \"%s\" does not support > soft output - soft output > +flags will be ignored.\n", I think, instead of using "printf", you should use RTE_LOG, ideally with a = dynamic log type, so a user can change the level and decide which messages to show (like what= was done in TestPMD, with TESTPMD_LOG). Thanks, Pablo