From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 8CBBF4CA6 for ; Tue, 24 Apr 2018 17:30:28 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2018 08:30:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,323,1520924400"; d="scan'208";a="222979173" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga006.fm.intel.com with ESMTP; 24 Apr 2018 08:30:26 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.155]) by IRSMSX153.ger.corp.intel.com ([169.254.9.3]) with mapi id 14.03.0319.002; Tue, 24 Apr 2018 16:30:25 +0100 From: "De Lara Guarch, Pablo" To: "Chalupnik, KamilX" , "dev@dpdk.org" CC: "Mokhtar, Amr" , "Chalupnik, KamilX" Thread-Topic: [dpdk-dev] [PATCH v2] baseband/turbo_sw: splitting Queue Groups Thread-Index: AQHT1lo/sX6WpgZFS0Snz5QcBESFVqQQE2pA Date: Tue, 24 Apr 2018 15:30:24 +0000 Message-ID: References: <20180404140602.9344-4-kamilx.chalupnik@intel.com> <20180417143953.22356-1-kamilx.chalupnik@intel.com> In-Reply-To: <20180417143953.22356-1-kamilx.chalupnik@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2VkNTNhYjQtYTFlNy00ZjZiLThhN2YtYThjN2U4MDg2MWE4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Imo4RzlmVnNXeEpmd3dnalhXNVZKMUJLdUZsM1VUTnI2UEF2Q2lMaGtsSHM9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] baseband/turbo_sw: splitting Queue Groups X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2018 15:30:30 -0000 Hi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of KamilX Chalupnik > Sent: Tuesday, April 17, 2018 3:40 PM > To: dev@dpdk.org > Cc: Mokhtar, Amr ; Chalupnik, KamilX > > Subject: [dpdk-dev] [PATCH v2] baseband/turbo_sw: splitting Queue Groups >=20 This patch is mainly an API change, so title should be: "bbdev: split queue= groups", Since it mainly targets the library (which therefore, requires changes in t= he PMDs and the test app). Also the commit message should be updated, not focusing on the Turbo SW dri= ver. > Splitting Queue Groups into UL/DL Groups in Turbo Software Driver. The ar= e > independent for Decode/Encode >=20 > Signed-off-by: KamilX Chalupnik >=20 ... > - TEST_ASSERT(event_status =3D=3D 0, > + TEST_ASSERT(event_status =3D=3D (int) RTE_BBDEV_EVENT_UNKNOWN, > "Failed test for rte_bbdev_pmd_callback_process " > "for RTE_BBDEV_EVENT_UNKNOWN "); These changes making use of the EVENT macros should be in a separate patch, as it doesn't look like they belong to this one.