From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 2523D2F4F for ; Tue, 24 Apr 2018 19:20:19 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2018 10:20:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,324,1520924400"; d="scan'208";a="36684402" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga006.jf.intel.com with ESMTP; 24 Apr 2018 10:20:17 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.155]) by IRSMSX106.ger.corp.intel.com ([169.254.8.37]) with mapi id 14.03.0319.002; Tue, 24 Apr 2018 18:20:16 +0100 From: "De Lara Guarch, Pablo" To: "De Lara Guarch, Pablo" , "Chalupnik, KamilX" , "dev@dpdk.org" CC: "Mokhtar, Amr" , "Chalupnik, KamilX" Thread-Topic: [dpdk-dev] [PATCH v2] baseband/turbo_sw: splitting Queue Groups Thread-Index: AQHT1lo/sX6WpgZFS0Snz5QcBESFVqQQE2pAgAAghJA= Date: Tue, 24 Apr 2018 17:20:15 +0000 Message-ID: References: <20180404140602.9344-4-kamilx.chalupnik@intel.com> <20180417143953.22356-1-kamilx.chalupnik@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2VkNTNhYjQtYTFlNy00ZjZiLThhN2YtYThjN2U4MDg2MWE4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Imo4RzlmVnNXeEpmd3dnalhXNVZKMUJLdUZsM1VUTnI2UEF2Q2lMaGtsSHM9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] baseband/turbo_sw: splitting Queue Groups X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2018 17:20:20 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch, Pabl= o > Sent: Tuesday, April 24, 2018 4:30 PM > To: Chalupnik, KamilX ; dev@dpdk.org > Cc: Mokhtar, Amr ; Chalupnik, KamilX > > Subject: Re: [dpdk-dev] [PATCH v2] baseband/turbo_sw: splitting Queue Gro= ups >=20 > Hi, >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of KamilX Chalupnik > > Sent: Tuesday, April 17, 2018 3:40 PM > > To: dev@dpdk.org > > Cc: Mokhtar, Amr ; Chalupnik, KamilX > > > > Subject: [dpdk-dev] [PATCH v2] baseband/turbo_sw: splitting Queue > > Groups > > >=20 > This patch is mainly an API change, so title should be: "bbdev: split que= ue > groups", Since it mainly targets the library (which therefore, requires c= hanges in > the PMDs and the test app). > Also the commit message should be updated, not focusing on the Turbo SW > driver. >=20 Could you also document this API change in release notes? Thanks, Pablo >=20 > > Splitting Queue Groups into UL/DL Groups in Turbo Software Driver. The > > are independent for Decode/Encode > > > > Signed-off-by: KamilX Chalupnik > > >=20 > ... >=20 > > - TEST_ASSERT(event_status =3D=3D 0, > > + TEST_ASSERT(event_status =3D=3D (int) RTE_BBDEV_EVENT_UNKNOWN, > > "Failed test for rte_bbdev_pmd_callback_process " > > "for RTE_BBDEV_EVENT_UNKNOWN "); >=20 > These changes making use of the EVENT macros should be in a separate patc= h, > as it doesn't look like they belong to this one. >=20