From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id DEB864C6F for ; Tue, 24 Apr 2018 19:44:58 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2018 10:44:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,324,1520924400"; d="scan'208";a="49579665" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by fmsmga001.fm.intel.com with ESMTP; 24 Apr 2018 10:44:51 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.155]) by irsmsx105.ger.corp.intel.com ([169.254.7.163]) with mapi id 14.03.0319.002; Tue, 24 Apr 2018 18:44:50 +0100 From: "De Lara Guarch, Pablo" To: "Chalupnik, KamilX" , "dev@dpdk.org" CC: "Mokhtar, Amr" , "Chalupnik, KamilX" Thread-Topic: [dpdk-dev] [PATCH v2] baseband/turbo_sw: offload cost measurement test Thread-Index: AQHT1lh/uTSiYM8t+0Kod24sSbGByaQQHRiA Date: Tue, 24 Apr 2018 17:44:50 +0000 Message-ID: References: <20180404140602.9344-2-kamilx.chalupnik@intel.com> <20180417142724.27748-1-kamilx.chalupnik@intel.com> In-Reply-To: <20180417142724.27748-1-kamilx.chalupnik@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWFkZWI1NzItYzk2ZC00ZDAzLWEzYWEtZWE3YjJjM2UwZDAzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Im1lN09MYmJtSXNVRVEyZkJ4Nm0zOSs0cmVIZUhBVkxWOWw5QVhHR3NuRXM9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] baseband/turbo_sw: offload cost measurement test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2018 17:45:00 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of KamilX Chalupnik > Sent: Tuesday, April 17, 2018 3:27 PM > To: dev@dpdk.org > Cc: Mokhtar, Amr ; Chalupnik, KamilX > > Subject: [dpdk-dev] [PATCH v2] baseband/turbo_sw: offload cost measuremen= t > test >=20 > New test created to measure offload cost. > Changes were introduced in API, turbo software driver and test applicatio= n. >=20 Shouldn't this be generic to bbdev/baseband drivers in general and not just= turbo? > Signed-off-by: KamilX Chalupnik ... > --- a/lib/librte_bbdev/rte_bbdev.h > +++ b/lib/librte_bbdev/rte_bbdev.h > @@ -239,6 +239,10 @@ struct rte_bbdev_stats { > uint64_t enqueue_err_count; > /** Total error count on operations dequeued */ > uint64_t dequeue_err_count; > +#ifdef RTE_TEST_BBDEV > + /** It stores turbo decoder/encoder working time. */ > + uint64_t turbo_perf_time; > +#endif I don't think it is a good idea to use RTE_TEST_BBDEV here. This macro is used to enable/disable the compilation of the bbdev test app, so I think it should not be used in the API/PMDs. Also, this looks too specific for the Turbo SW PMD to be exposed as a generic statistic. > }; >=20 > /** > -- > 2.5.5 >=20