From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pablo.de.lara.guarch@intel.com> Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 1C0BD5323 for <dev@dpdk.org>; Thu, 26 Apr 2018 13:28:46 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Apr 2018 04:28:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,330,1520924400"; d="scan'208";a="37204856" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga006.jf.intel.com with ESMTP; 26 Apr 2018 04:28:44 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.155]) by irsmsx110.ger.corp.intel.com ([169.254.15.211]) with mapi id 14.03.0319.002; Thu, 26 Apr 2018 12:28:43 +0100 From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com> To: "Chalupnik, KamilX" <kamilx.chalupnik@intel.com>, "dev@dpdk.org" <dev@dpdk.org> CC: "Mokhtar, Amr" <amr.mokhtar@intel.com> Thread-Topic: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support Thread-Index: AQHTzB5WbYdJWBOtYEmRu+DkPJ1VhaQQFMBggAElHYCAAIobMIABGKqAgAAt3lA= Date: Thu, 26 Apr 2018 11:28:42 +0000 Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CCDE150@IRSMSX108.ger.corp.intel.com> References: <20180404140602.9344-1-kamilx.chalupnik@intel.com> <20180404140602.9344-8-kamilx.chalupnik@intel.com> <E115CCD9D858EF4F90C690B0DCB4D8976CCDBEEF@IRSMSX108.ger.corp.intel.com> <EEA9FF629BF25B47BD67ADE995041EE23CF5B5C4@IRSMSX103.ger.corp.intel.com> <E115CCD9D858EF4F90C690B0DCB4D8976CCDD50B@IRSMSX108.ger.corp.intel.com> <EEA9FF629BF25B47BD67ADE995041EE23CF5DBFE@IRSMSX103.ger.corp.intel.com> In-Reply-To: <EEA9FF629BF25B47BD67ADE995041EE23CF5DBFE@IRSMSX103.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDE1NjJlNzUtNzA1Yy00MDEwLWE1Y2YtNmQzMTVmYjQ5NDNhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ilk5R2E2UTFWUHdnaGRrOU00Nnd1VjdWd0tIeG16MStsRFlEbk0xNjBvY009In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 26 Apr 2018 11:28:47 -0000 > -----Original Message----- > From: Chalupnik, KamilX > Sent: Thursday, April 26, 2018 10:42 AM > To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; dev@dpdk.org > Cc: Mokhtar, Amr <amr.mokhtar@intel.com> > Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support >=20 > Hi Pablo, >=20 > > -----Original Message----- > > From: De Lara Guarch, Pablo > > Sent: Wednesday, April 25, 2018 6:11 PM > > To: Chalupnik, KamilX <kamilx.chalupnik@intel.com>; dev@dpdk.org > > Cc: Mokhtar, Amr <amr.mokhtar@intel.com> > > Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support > > > > Hi Kamil, > > > > > -----Original Message----- > > > From: Chalupnik, KamilX > > > Sent: Wednesday, April 25, 2018 9:43 AM > > > To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; > > > dev@dpdk.org > > > Cc: Mokhtar, Amr <amr.mokhtar@intel.com> > > > Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support > > > > > > Hi Pablo > > > > > > > -----Original Message----- > > > > From: De Lara Guarch, Pablo > > > > Sent: Tuesday, April 24, 2018 4:18 PM > > > > To: Chalupnik, KamilX <kamilx.chalupnik@intel.com>; dev@dpdk.org > > > > Cc: Mokhtar, Amr <amr.mokhtar@intel.com>; Chalupnik, KamilX > > > > <kamilx.chalupnik@intel.com> > > > > Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support > > > > > > > > Hi Kamil, > > > > > > > > > -----Original Message----- > > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of KamilX > > > > > Chalupnik > > > > > Sent: Wednesday, April 4, 2018 3:06 PM > > > > > To: dev@dpdk.org > > > > > Cc: Mokhtar, Amr <amr.mokhtar@intel.com>; Chalupnik, KamilX > > > > > <kamilx.chalupnik@intel.com> > > > > > Subject: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support > > > > > > > > > > From: "Chalupnik, KamilX" <kamilx.chalupnik@intel.com> > > > > > > > > > > Support for linking with dynamic library added in Baseband > > > > > Device test application > > > > > > > > > > Signed-off-by: KamilX Chalupnik <kamilx.chalupnik@intel.com> > > > > > --- > > > > > app/test-bbdev/Makefile | 4 ++++ > > > > > doc/guides/tools/testbbdev.rst | 7 +++++++ > > > > > 2 files changed, 11 insertions(+) > > > > > > > > > > diff --git a/app/test-bbdev/Makefile b/app/test-bbdev/Makefile > > > > > index 6da0c8e..26c9a4b 100644 > > > > > --- a/app/test-bbdev/Makefile > > > > > +++ b/app/test-bbdev/Makefile > > > > > @@ -22,4 +22,8 @@ SRCS-$(CONFIG_RTE_TEST_BBDEV) +=3D > > > > test_bbdev_vector.c > > > > > > > > > > LDLIBS +=3D -lm > > > > > > > > > > +ifeq ($(CONFIG_RTE_LIBRTE_PMD_BBDEV_TURBO_SW),y) > > > > > +LDLIBS +=3D -lrte_pmd_bbdev_turbo_sw endif > > > > > > > > This is already done in mk/rte.app.mk, so it should not be needed. > > > > > > > > > > We need this here when DPDK is built as dynamic library. > > > In rte.app.mk lrte_pmd_bbdev_turbo_sw is added to LDLIBS when > > > CONFIG_RTE_BUILD_SHARED_LIB is not set. > > > > In that case, you need to use the EAL option "-d" with the .so library= . > > > > ./testbbdev -d build/lib/librte_pmd_bbdev_turbo_sw.so --vdev=3D"turbo_s= w" >=20 > I thought it is fine as long as other test applications works in that way= , e.g. test- > crypto-perf, test-pmd >=20 > > Btw, now that I have seen the name of the vdev, I think you should > > rename to "baseband_turbo_sw". > > Also, NULL PMD should be renamed to "baseband_null". >=20 > Ok, we will deliver such changes in patches for next release. Are you ok = with > that? I think this change should not take a long time. The sooner we do it, the b= etter, as there might be more people using this in the future. I can send the patch for you, so you can focus on other changes, and then y= ou can see if it is fine for you. Thanks, Pablo >=20 >=20 > Best regards, > Kamil