From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 1A17F2BAE for ; Mon, 7 May 2018 14:50:10 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 May 2018 05:50:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,373,1520924400"; d="scan'208";a="226414961" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga005.fm.intel.com with ESMTP; 07 May 2018 05:50:07 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.150]) by IRSMSX101.ger.corp.intel.com ([169.254.1.118]) with mapi id 14.03.0319.002; Mon, 7 May 2018 13:50:07 +0100 From: "De Lara Guarch, Pablo" To: "Chalupnik, KamilX" , "dev@dpdk.org" CC: "Mokhtar, Amr" Thread-Topic: [PATCH 05/13] baseband/turbo_sw: scalling input LLR to range [-16 16] Thread-Index: AQHT3WMPIcyW5eDva0ujh1VtxN3FD6QkQy+w Date: Mon, 7 May 2018 12:50:06 +0000 Message-ID: References: <20180426133008.12388-1-kamilx.chalupnik@intel.com> <20180426133008.12388-5-kamilx.chalupnik@intel.com> In-Reply-To: <20180426133008.12388-5-kamilx.chalupnik@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzJlNjZjZmQtYzRhNy00MDcxLTlkNjktY2Y1ODQ4N2RjYjNhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlNYdjRUdTFSOXBvTFVnMm9waGJIdHBXUUxEM3ZZQzMzMmtUZ2xIZVwvUklFPSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 05/13] baseband/turbo_sw: scalling input LLR to range [-16 16] X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 May 2018 12:50:11 -0000 > -----Original Message----- > From: Chalupnik, KamilX > Sent: Thursday, April 26, 2018 2:30 PM > To: dev@dpdk.org > Cc: Mokhtar, Amr ; De Lara Guarch, Pablo > ; Chalupnik, KamilX > > Subject: [PATCH 05/13] baseband/turbo_sw: scalling input LLR to range [-1= 6 16] What is LLR? It is worth expanding the acronym, and then you can use it lat= er. >=20 > From: KamilX Chalupnik >=20 > Update Turbo Software driver for Wireless Baseband Device: > - function scaling input LLR values to specific range [-16, 16] added > - new test vectors to check device capabilities added >=20 > Signed-off-by: Kamil Chalupnik > Acked-by: Amr Mokhtar ... > --- a/app/test-bbdev/test_bbdev_perf.c > +++ b/app/test-bbdev/test_bbdev_perf.c > @@ -4,6 +4,7 @@ >=20 > #include > #include > +#include >=20 > #include > #include > @@ -609,10 +610,32 @@ allocate_buffers_on_socket(struct > rte_bbdev_op_data **buffers, const int len, > return (*buffers =3D=3D NULL) ? TEST_FAILED : TEST_SUCCESS; } >=20 > +static void > +limit_input_llr_val_range(struct rte_bbdev_op_data *input_ops, > + const uint16_t n, const int8_t max_llr_modulus) { No need for const in parameters passed by value. > + uint16_t i, byte_idx; > + ... > static inline void > diff --git a/lib/librte_bbdev/rte_bbdev_op.h b/lib/librte_bbdev/rte_bbdev= _op.h > index 1a80588..90a688e 100644 > --- a/lib/librte_bbdev/rte_bbdev_op.h > +++ b/lib/librte_bbdev/rte_bbdev_op.h > @@ -379,6 +379,10 @@ struct rte_bbdev_op_turbo_enc { struct > rte_bbdev_op_cap_turbo_dec { > /**< Flags from rte_bbdev_op_td_flag_bitmasks */ > uint32_t capability_flags; > + /** Maximal LLR absolute value. Acceptable LLR values lie in range > + * [-max_llr_modulus, max_llr_modulus]. > + */ > + int8_t max_llr_modulus; > uint8_t num_buffers_src; /**< Num input code block buffers */ > /**< Num hard output code block buffers */ > uint8_t num_buffers_hard_out; This is breaking ABI, add a note in ABI changes, in release notes. > -- > 2.5.5