From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id A45004F96 for ; Tue, 8 May 2018 20:32:39 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 May 2018 11:32:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,379,1520924400"; d="scan'208";a="44244294" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by fmsmga002.fm.intel.com with ESMTP; 08 May 2018 11:32:34 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.150]) by IRSMSX109.ger.corp.intel.com ([169.254.13.176]) with mapi id 14.03.0319.002; Tue, 8 May 2018 19:32:33 +0100 From: "De Lara Guarch, Pablo" To: "Verma, Shally" , "Trahe, Fiona" CC: "Doherty, Declan" , "Athreya, Narayana Prasad" , "Sahu, Sunila" , "Gupta, Ashish" , "dev@dpdk.org" , "Sahu, Sunila" , "Gupta, Ashish" , "Kotamarthy, Kanaka" , "Marisetti, Balaji" Thread-Topic: [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptodev Thread-Index: AQHTzNDonS9OmXVrX0eVXtpZSR5uzqQlysOAgAABzQCAAI24sA== Date: Tue, 8 May 2018 18:32:33 +0000 Message-ID: References: <1522927489-23668-1-git-send-email-shally.verma@caviumnetworks.com> <1522927489-23668-3-git-send-email-shally.verma@caviumnetworks.com> <348A99DA5F5B7549AA880327E580B4358947A9DD@IRSMSX103.ger.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDYwNmNlMTYtNGM3NS00ZTUwLWJkZGYtMTJhZTk1MWI0MmZhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IllQT0h4TXpPbXJwWm5ObXF6c0wzTTNVcjgyOHVoUzlISnVZTDRBNTRtWDg9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptodev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 May 2018 18:32:40 -0000 Hi Shally, > -----Original Message----- > From: Verma, Shally [mailto:Shally.Verma@cavium.com] > Sent: Tuesday, May 8, 2018 11:58 AM > To: Trahe, Fiona ; De Lara Guarch, Pablo > > Cc: Doherty, Declan ; Athreya, Narayana Prasad > ; Sahu, Sunila > ; Gupta, Ashish ; > dev@dpdk.org; Sahu, Sunila ; Gupta, Ashish > ; Kotamarthy, Kanaka > ; Marisetti, Balaji > > Subject: RE: [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptod= ev >=20 > Hi Fiona >=20 > >-----Original Message----- > >From: Trahe, Fiona [mailto:fiona.trahe@intel.com] > >Sent: 08 May 2018 16:22 > >To: Verma, Shally ; De Lara Guarch, Pablo > > > >Cc: Doherty, Declan ; Athreya, Narayana > >Prasad ; Sahu, Sunila > >; Gupta, Ashish ; > >dev@dpdk.org; Sahu, Sunila ; Gupta, Ashish > >; Trahe, Fiona > >Subject: RE: [PATCH v2 2/6] lib/cryptodev: add asym op support in > >cryptodev > > > >Hi Shally, > > > >Reviewing the asymm v2 patch - quick comment: > > > >> List of TBDs: > >> - change PMD ops session_get_size, session_configure, session_clear > >> to sym_session_* APIs > >> - change external get_session_private_size to sym_get_session_* > >> - per-service stats update > >[Fiona] You'll need to send a deprecation notice for any changes to > >existing cryptodev APIs in > >18.05 if you want the changes applied in 18.08 >=20 > Thanks for info. However, assume API name change is not blocker for spec = to be > in 18.08. So, I planned to do it at later stage after spec get stabilize = and > accepted. > Do you have any other thoughts to it? Any modifications to the API, including name changes, require a deprecation= notice. Making this change will break the compilation of all the apps using it. What I would suggest is renaming the function and creating a wrapper with t= he current name, calling the new function, and marking it as rte_deprecated. Something like: /* * @deprecated ... */ __rte_deprecated unsigned=20 rte_cryptodev_get_session_private_size(...) { return rte_cryptodev_get_sym_session_private_size(...); } This way, we can give users time to change to the new API, without breaking= directly the code. Thanks, Pablo >=20 > Shally