From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Andy Green <andy@warmcat.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/4] net/bnx2x: do not cast function pointers as a policy
Date: Fri, 11 May 2018 16:33:34 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CD090BC@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <152600347742.53624.12860056818159426243.stgit@localhost.localdomain>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andy Green
> Sent: Friday, May 11, 2018 2:51 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH 1/4] net/bnx2x: do not cast function pointers as a
> policy
>
> This is stopping the compiler telling you when you have done something stupid...
> that is something none of us can afford...
>
> Now gcc 8.x can tell you did something stupid despite trying to hide the
> evidence.
>
> Remove all the "black magic" casts.
>
> Fix the actual problems.
> ---
> drivers/net/bnx2x/elink.c | 294 +++++++++++++++++++++++----------------------
Missing signed-off-by line, fixes line and Cc stable:
Fixes: b5bf7719221d ("bnx2x: driver support routines")
Cc: stable@dpdk.org
next prev parent reply other threads:[~2018-05-11 16:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 1:51 [dpdk-dev] [PATCH 0/4] GCC8 fixes for MLX4/5/BNX2X PMD Andy Green
2018-05-11 1:51 ` [dpdk-dev] [PATCH 1/4] net/bnx2x: do not cast function pointers as a policy Andy Green
2018-05-11 16:03 ` Ferruh Yigit
2018-05-12 0:25 ` Andy Green
2018-05-11 16:33 ` De Lara Guarch, Pablo [this message]
2018-05-11 1:51 ` [dpdk-dev] [PATCH 2/4] net/bnx2x: remove unmeetable comparison Andy Green
2018-05-11 16:32 ` De Lara Guarch, Pablo
2018-05-11 18:10 ` Stephen Hemminger
2018-05-12 1:04 ` Andy Green
2018-05-11 1:51 ` [dpdk-dev] [PATCH 3/4] net/mlx5: solve var may be used uninitialized Andy Green
2018-05-11 16:25 ` De Lara Guarch, Pablo
2018-05-13 4:45 ` Shahaf Shuler
2018-05-13 5:25 ` Andy Green
2018-05-11 1:51 ` [dpdk-dev] [PATCH 4/4] net/bnx2x: solve overruns Andy Green
2018-05-11 16:21 ` De Lara Guarch, Pablo
2018-05-11 16:04 ` [dpdk-dev] [PATCH 0/4] GCC8 fixes for MLX4/5/BNX2X PMD Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CD090BC@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=andy@warmcat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).