From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 263DD1BC3A for ; Mon, 14 May 2018 10:04:22 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 May 2018 01:04:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,399,1520924400"; d="scan'208";a="55666786" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga001.jf.intel.com with ESMTP; 14 May 2018 01:04:20 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.150]) by IRSMSX153.ger.corp.intel.com ([169.254.9.5]) with mapi id 14.03.0319.002; Mon, 14 May 2018 09:04:19 +0100 From: "De Lara Guarch, Pablo" To: "Verma, Shally" , "dev@dpdk.org" CC: "Trahe, Fiona" , "ahmed.mansour@nxp.com" , "Gupta, Ashish" , "Gupta, Ashish" , "Sahu, Sunila" Thread-Topic: [PATCH v6 02/14] compressdev: add queue pair management Thread-Index: AQHT61jFOzYhTdwbKEaa5Pf96WsataQu3UKw Date: Mon, 14 May 2018 08:04:19 +0000 Message-ID: References: <1517595924-25963-1-git-send-email-fiona.trahe@intel.com> <20180427132407.13385-1-pablo.de.lara.guarch@intel.com> <20180427132407.13385-3-pablo.de.lara.guarch@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjBmMzU0YzEtNGEzOS00NmE3LTkzODMtYThiMGQ5MTc0MTMwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlpzUnNSUTA0OWhqeitqTlh3a1prcDlIbUR2eU1jMFV5VWNpbnVqVEdaZ0E9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 02/14] compressdev: add queue pair management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 May 2018 08:04:23 -0000 Hi Shally, > -----Original Message----- > From: Verma, Shally [mailto:Shally.Verma@cavium.com] > Sent: Monday, May 14, 2018 8:54 AM > To: De Lara Guarch, Pablo ; dev@dpdk.org > Cc: Trahe, Fiona ; ahmed.mansour@nxp.com; Gupta, > Ashish ; Gupta, Ashish > ; Sahu, Sunila > Subject: RE: [PATCH v6 02/14] compressdev: add queue pair management >=20 > HI Pablo >=20 > >-----Original Message----- > >From: Pablo de Lara [mailto:pablo.de.lara.guarch@intel.com] > >Sent: 27 April 2018 18:54 > >To: dev@dpdk.org > >Cc: fiona.trahe@intel.com; Verma, Shally ; > >ahmed.mansour@nxp.com; Gupta, Ashish ; Pablo > >de Lara ; Verma, Shally > >; Gupta, Ashish > >Subject: [PATCH v6 02/14] compressdev: add queue pair management > > > >From: Fiona Trahe > > > >Add functions to manage device queue pairs. > > > >Signed-off-by: Fiona Trahe > >Signed-off-by: Pablo de Lara > >Signed-off-by: Shally Verma > >Signed-off-by: Ashish Gupta > >--- > > lib/librte_compressdev/rte_compressdev.c | 178 > ++++++++++++++++++++- > > lib/librte_compressdev/rte_compressdev.h | 45 ++++++ > > lib/librte_compressdev/rte_compressdev_internal.h | 5 + > > lib/librte_compressdev/rte_compressdev_pmd.h | 47 ++++++ > > lib/librte_compressdev/rte_compressdev_version.map | 2 + > > 5 files changed, 276 insertions(+), 1 deletion(-) > > > >diff --git a/lib/librte_compressdev/rte_compressdev.c > >b/lib/librte_compressdev/rte_compressdev.c > >index 751517c3d..6667528b5 100644 > >--- a/lib/librte_compressdev/rte_compressdev.c > >+++ b/lib/librte_compressdev/rte_compressdev.c > >@@ -227,10 +227,136 @@ rte_compressdev_pmd_release_device(struct > rte_compressdev *compressdev) > > return 0; > > } > > > >+uint16_t __rte_experimental > >+rte_compressdev_queue_pair_count(uint8_t dev_id) { > >+ struct rte_compressdev *dev; > >+ > >+ dev =3D &rte_comp_devices[dev_id]; > >+ return dev->data->nb_queue_pairs; > >+} > >+ > >+static int > >+rte_compressdev_queue_pairs_config(struct rte_compressdev *dev, > >+ uint16_t nb_qpairs, int socket_id) > >+{ > >+ struct rte_compressdev_info dev_info; > >+ void **qp; > >+ unsigned int i; > >+ > >+ if ((dev =3D=3D NULL) || (nb_qpairs < 1)) { > >+ COMPRESSDEV_LOG(ERR, "invalid param: dev %p, nb_queues > %u", > >+ dev, nb_qpairs); > [Shally] shouldn't nb_qpairs < 0 as nb_qpairs =3D 0 a valid input which = imply > number of supported qp is implementation defined and thus unlimited. You mean maximum number of queues. This is number of queues to configure, which should be at least 1. Thanks, Pablo >=20 > Thanks > Shally >=20 > //snip