* [dpdk-dev] [PATCH v2] crypto/scheduler: fix possible duplicated ring names
@ 2018-05-16 13:10 Fan Zhang
2018-05-16 13:56 ` De Lara Guarch, Pablo
0 siblings, 1 reply; 3+ messages in thread
From: Fan Zhang @ 2018-05-16 13:10 UTC (permalink / raw)
To: dev; +Cc: roy.fan.zhang, kirill.rybalchenko, stable, pablo.de.lara.guarch
This patch fixes the possible duplicated ring names in multi-core
scheduler. Originally two or more multi-core schedulers may have
same worker ring names thus will cause initialization error.
Fixes: 4c07e0552f0a ("crypto/scheduler: add multicore scheduling mode")
Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
v2:
- changed fix line location
- used device id and index to generate unique pool name
drivers/crypto/scheduler/scheduler_multicore.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/scheduler/scheduler_multicore.c b/drivers/crypto/scheduler/scheduler_multicore.c
index 644426e93..d49e53681 100644
--- a/drivers/crypto/scheduler/scheduler_multicore.c
+++ b/drivers/crypto/scheduler/scheduler_multicore.c
@@ -347,14 +347,16 @@ scheduler_create_private_ctx(struct rte_cryptodev *dev)
for (i = 0; i < sched_ctx->nb_wc; i++) {
char r_name[16];
- snprintf(r_name, sizeof(r_name), MC_SCHED_ENQ_RING_NAME_PREFIX "%u", i);
+ snprintf(r_name, sizeof(r_name), MC_SCHED_ENQ_RING_NAME_PREFIX
+ "%u_%u", dev->data->dev_id, i);
mc_ctx->sched_enq_ring[i] = rte_ring_create(r_name, PER_SLAVE_BUFF_SIZE,
rte_socket_id(), RING_F_SC_DEQ | RING_F_SP_ENQ);
if (!mc_ctx->sched_enq_ring[i]) {
CS_LOG_ERR("Cannot create ring for worker %u", i);
goto exit;
}
- snprintf(r_name, sizeof(r_name), MC_SCHED_DEQ_RING_NAME_PREFIX "%u", i);
+ snprintf(r_name, sizeof(r_name), MC_SCHED_DEQ_RING_NAME_PREFIX
+ "%u_%u", dev->data->dev_id, i);
mc_ctx->sched_deq_ring[i] = rte_ring_create(r_name, PER_SLAVE_BUFF_SIZE,
rte_socket_id(), RING_F_SC_DEQ | RING_F_SP_ENQ);
if (!mc_ctx->sched_deq_ring[i]) {
--
2.13.6
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH v2] crypto/scheduler: fix possible duplicated ring names
2018-05-16 13:10 [dpdk-dev] [PATCH v2] crypto/scheduler: fix possible duplicated ring names Fan Zhang
@ 2018-05-16 13:56 ` De Lara Guarch, Pablo
2018-05-17 16:15 ` [dpdk-dev] [dpdk-stable] " De Lara Guarch, Pablo
0 siblings, 1 reply; 3+ messages in thread
From: De Lara Guarch, Pablo @ 2018-05-16 13:56 UTC (permalink / raw)
To: Zhang, Roy Fan, dev; +Cc: Rybalchenko, Kirill, stable
> -----Original Message-----
> From: Zhang, Roy Fan
> Sent: Wednesday, May 16, 2018 2:11 PM
> To: dev@dpdk.org
> Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; Rybalchenko, Kirill
> <kirill.rybalchenko@intel.com>; stable@dpdk.org; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH v2] crypto/scheduler: fix possible duplicated ring names
>
> This patch fixes the possible duplicated ring names in multi-core scheduler.
> Originally two or more multi-core schedulers may have same worker ring names
> thus will cause initialization error.
>
> Fixes: 4c07e0552f0a ("crypto/scheduler: add multicore scheduling mode")
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] crypto/scheduler: fix possible duplicated ring names
2018-05-16 13:56 ` De Lara Guarch, Pablo
@ 2018-05-17 16:15 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 3+ messages in thread
From: De Lara Guarch, Pablo @ 2018-05-17 16:15 UTC (permalink / raw)
To: De Lara Guarch, Pablo, Zhang, Roy Fan, dev; +Cc: Rybalchenko, Kirill, stable
> -----Original Message-----
> From: stable [mailto:stable-bounces@dpdk.org] On Behalf Of De Lara Guarch,
> Pablo
> Sent: Wednesday, May 16, 2018 2:56 PM
> To: Zhang, Roy Fan <roy.fan.zhang@intel.com>; dev@dpdk.org
> Cc: Rybalchenko, Kirill <kirill.rybalchenko@intel.com>; stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH v2] crypto/scheduler: fix possible duplicated
> ring names
>
>
>
> > -----Original Message-----
> > From: Zhang, Roy Fan
> > Sent: Wednesday, May 16, 2018 2:11 PM
> > To: dev@dpdk.org
> > Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; Rybalchenko, Kirill
> > <kirill.rybalchenko@intel.com>; stable@dpdk.org; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch@intel.com>
> > Subject: [PATCH v2] crypto/scheduler: fix possible duplicated ring
> > names
> >
> > This patch fixes the possible duplicated ring names in multi-core scheduler.
> > Originally two or more multi-core schedulers may have same worker ring
> > names thus will cause initialization error.
> >
> > Fixes: 4c07e0552f0a ("crypto/scheduler: add multicore scheduling
> > mode")
Added Cc: stable@dpdk.org
> >
> > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Applied to dpdk-next-crypto.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-17 16:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-16 13:10 [dpdk-dev] [PATCH v2] crypto/scheduler: fix possible duplicated ring names Fan Zhang
2018-05-16 13:56 ` De Lara Guarch, Pablo
2018-05-17 16:15 ` [dpdk-dev] [dpdk-stable] " De Lara Guarch, Pablo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).