From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 70B3256A1 for ; Thu, 17 May 2018 10:06:04 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 May 2018 01:06:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,390,1520924400"; d="scan'208";a="59376691" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga002.jf.intel.com with ESMTP; 17 May 2018 01:06:02 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.150]) by IRSMSX151.ger.corp.intel.com ([169.254.4.167]) with mapi id 14.03.0319.002; Thu, 17 May 2018 09:06:01 +0100 From: "De Lara Guarch, Pablo" To: Vijaya Mohan Guvva , "Richardson, Bruce" CC: "dev@dpdk.org" Thread-Topic: [PATCH V2] librte_hash: new hash del abi to return stored value Thread-Index: AQHT7X439vrbwy1Ftki9oLlsZE7S7KQzj2ZA Date: Thu, 17 May 2018 08:06:00 +0000 Message-ID: References: <1526520393-19295-1-git-send-email-vguvva@caviumnetworks.com> In-Reply-To: <1526520393-19295-1-git-send-email-vguvva@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGNiMTRmZDYtZjZlNS00NjdiLWJkMDItYzk1MTk4OWU5NTI2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkF5cE9GNWR3c3ZnRXQ2UXNQR0lLTWIwN0w0QytiSEF0RE9EekVRZ3oxd3c9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH V2] librte_hash: new hash del abi to return stored value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2018 08:06:04 -0000 Hi Vijaya, > -----Original Message----- > From: Vijaya Mohan Guvva [mailto:vguvva@caviumnetworks.com] > Sent: Thursday, May 17, 2018 2:27 AM > To: Richardson, Bruce ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; Vijaya Mohan Guvva > Subject: [PATCH V2] librte_hash: new hash del abi to return stored value >=20 You are actually adding new API, not ABI, so I would reword the commit mess= age. "hash: add API to return stored value at deletion" maybe? I would add some information in the commit message and move the changelog (= V1, V2 notes) after the three dashes. =20 > V2: > Adding another new interface rte_hash_del_key_data to delete key from has= h > table and return stored data. >=20 > V1: > Add a new key delete interface rte_hash_del_key_with_hash_data to delete = the > key from hash and return the value stored. This is useful for hash users = to free > the data stored in the table after key delete and to avoid maintaining a = user data > array in the dpdk application. >=20 > Signed-off-by: Vijaya Mohan Guvva > --- > lib/librte_hash/rte_cuckoo_hash.c | 30 +++++++++++++++++++++++--- > lib/librte_hash/rte_hash.h | 45 > +++++++++++++++++++++++++++++++++++++++ > 2 files changed, 72 insertions(+), 3 deletions(-) ... > +int32_t > +rte_hash_del_key_with_hash_data(const struct rte_hash *h, const void *ke= y, > + hash_sig_t sig, void **data); > + > +/** > * Remove a key from an existing hash table. > * This operation is not multi-thread safe > * and should only be called from one thread. > -- > 1.8.3.1 You need to update the version.map file to add the two new functions (you might need to wait until 18.05 is released, so you can use the 18.08 t= ag).