* [dpdk-dev] [PATCH] compressdev: clarify buffer size limitation
@ 2018-05-16 14:18 Fiona Trahe
2018-05-17 6:10 ` Verma, Shally
0 siblings, 1 reply; 4+ messages in thread
From: Fiona Trahe @ 2018-05-16 14:18 UTC (permalink / raw)
To: dev; +Cc: pablo.de.lara.guarch, fiona.trahe
Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
---
lib/librte_compressdev/rte_comp.h | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/lib/librte_compressdev/rte_comp.h b/lib/librte_compressdev/rte_comp.h
index 4c802195f..9826086b1 100644
--- a/lib/librte_compressdev/rte_comp.h
+++ b/lib/librte_compressdev/rte_comp.h
@@ -295,12 +295,19 @@ struct rte_comp_op {
struct rte_mbuf *m_src;
/**< source mbuf
* The total size of the input buffer(s) can be retrieved using
- * rte_pktmbuf_data_len(m_src)
+ * rte_pktmbuf_data_len(m_src). The max data size which can fit in a
+ * single mbuf is limited by the uint16_t rte_mbuf.data_len to 64k-1.
+ * If the input data is bigger than this it can be passed to the PMD in
+ * a chain of mbufs if the PMD's capabilities indicate it supports this.
*/
struct rte_mbuf *m_dst;
/**< destination mbuf
* The total size of the output buffer(s) can be retrieved using
- * rte_pktmbuf_data_len(m_dst)
+ * rte_pktmbuf_data_len(m_dst). The max data size which can fit in a
+ * single mbuf is limited by the uint16_t rte_mbuf.data_len to 64k-1.
+ * If the output data is expected to be bigger than this a chain of
+ * mbufs can be passed to the PMD if the PMD's capabilities indicate
+ * it supports this.
*/
struct {
--
2.13.6
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] compressdev: clarify buffer size limitation
2018-05-16 14:18 [dpdk-dev] [PATCH] compressdev: clarify buffer size limitation Fiona Trahe
@ 2018-05-17 6:10 ` Verma, Shally
2018-05-21 22:32 ` De Lara Guarch, Pablo
0 siblings, 1 reply; 4+ messages in thread
From: Verma, Shally @ 2018-05-17 6:10 UTC (permalink / raw)
To: Fiona Trahe, dev; +Cc: pablo.de.lara.guarch, Gupta, Ashish, Sahu, Sunila
>-----Original Message-----
>From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fiona Trahe
>Sent: 16 May 2018 19:49
>To: dev@dpdk.org
>Cc: pablo.de.lara.guarch@intel.com; fiona.trahe@intel.com
>Subject: [dpdk-dev] [PATCH] compressdev: clarify buffer size limitation
>
>Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
>---
> lib/librte_compressdev/rte_comp.h | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
>diff --git a/lib/librte_compressdev/rte_comp.h b/lib/librte_compressdev/rte_comp.h
>index 4c802195f..9826086b1 100644
>--- a/lib/librte_compressdev/rte_comp.h
>+++ b/lib/librte_compressdev/rte_comp.h
>@@ -295,12 +295,19 @@ struct rte_comp_op {
> struct rte_mbuf *m_src;
> /**< source mbuf
> * The total size of the input buffer(s) can be retrieved using
>- * rte_pktmbuf_data_len(m_src)
>+ * rte_pktmbuf_data_len(m_src). The max data size which can fit in a
>+ * single mbuf is limited by the uint16_t rte_mbuf.data_len to 64k-1.
>+ * If the input data is bigger than this it can be passed to the PMD in
>+ * a chain of mbufs if the PMD's capabilities indicate it supports this.
> */
> struct rte_mbuf *m_dst;
> /**< destination mbuf
> * The total size of the output buffer(s) can be retrieved using
>- * rte_pktmbuf_data_len(m_dst)
>+ * rte_pktmbuf_data_len(m_dst). The max data size which can fit in a
>+ * single mbuf is limited by the uint16_t rte_mbuf.data_len to 64k-1.
>+ * If the output data is expected to be bigger than this a chain of
>+ * mbufs can be passed to the PMD if the PMD's capabilities indicate
>+ * it supports this.
> */
[Shally] It will be good idea to add bit more clarification regarding src.offset and dst.offset as well, that is, offset is offset from start of very first segment of m_src and m_dst in chained bufs.
>
> struct {
>--
>2.13.6
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] compressdev: clarify buffer size limitation
2018-05-17 6:10 ` Verma, Shally
@ 2018-05-21 22:32 ` De Lara Guarch, Pablo
2018-05-22 10:08 ` De Lara Guarch, Pablo
0 siblings, 1 reply; 4+ messages in thread
From: De Lara Guarch, Pablo @ 2018-05-21 22:32 UTC (permalink / raw)
To: Verma, Shally, Trahe, Fiona, dev; +Cc: Gupta, Ashish, Sahu, Sunila
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Verma, Shally
> Sent: Thursday, May 17, 2018 7:10 AM
> To: Trahe, Fiona <fiona.trahe@intel.com>; dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Gupta, Ashish
> <Ashish.Gupta@cavium.com>; Sahu, Sunila <Sunila.Sahu@cavium.com>
> Subject: Re: [dpdk-dev] [PATCH] compressdev: clarify buffer size limitation
>
>
>
> >-----Original Message-----
> >From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fiona Trahe
> >Sent: 16 May 2018 19:49
> >To: dev@dpdk.org
> >Cc: pablo.de.lara.guarch@intel.com; fiona.trahe@intel.com
> >Subject: [dpdk-dev] [PATCH] compressdev: clarify buffer size limitation
> >
> >Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> >---
> > lib/librte_compressdev/rte_comp.h | 11 +++++++++--
> > 1 file changed, 9 insertions(+), 2 deletions(-)
> >
> >diff --git a/lib/librte_compressdev/rte_comp.h
> b/lib/librte_compressdev/rte_comp.h
> >index 4c802195f..9826086b1 100644
> >--- a/lib/librte_compressdev/rte_comp.h
> >+++ b/lib/librte_compressdev/rte_comp.h
> >@@ -295,12 +295,19 @@ struct rte_comp_op {
> > struct rte_mbuf *m_src;
> > /**< source mbuf
> > * The total size of the input buffer(s) can be retrieved using
> >- * rte_pktmbuf_data_len(m_src)
> >+ * rte_pktmbuf_data_len(m_src). The max data size which can fit in a
> >+ * single mbuf is limited by the uint16_t rte_mbuf.data_len to 64k-1.
> >+ * If the input data is bigger than this it can be passed to the PMD in
> >+ * a chain of mbufs if the PMD's capabilities indicate it supports this.
> > */
> > struct rte_mbuf *m_dst;
> > /**< destination mbuf
> > * The total size of the output buffer(s) can be retrieved using
> >- * rte_pktmbuf_data_len(m_dst)
> >+ * rte_pktmbuf_data_len(m_dst). The max data size which can fit in a
> >+ * single mbuf is limited by the uint16_t rte_mbuf.data_len to 64k-1.
> >+ * If the output data is expected to be bigger than this a chain of
> >+ * mbufs can be passed to the PMD if the PMD's capabilities indicate
> >+ * it supports this.
> > */
> [Shally] It will be good idea to add bit more clarification regarding src.offset and
> dst.offset as well, that is, offset is offset from start of very first segment of
> m_src and m_dst in chained bufs.
I'd say there should be a separate patch addressing this comment.
This one looks ok to me.
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] compressdev: clarify buffer size limitation
2018-05-21 22:32 ` De Lara Guarch, Pablo
@ 2018-05-22 10:08 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 4+ messages in thread
From: De Lara Guarch, Pablo @ 2018-05-22 10:08 UTC (permalink / raw)
To: De Lara Guarch, Pablo, Verma, Shally, Trahe, Fiona, dev
Cc: Gupta, Ashish, Sahu, Sunila
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch, Pablo
> Sent: Monday, May 21, 2018 11:32 PM
> To: Verma, Shally <Shally.Verma@cavium.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; dev@dpdk.org
> Cc: Gupta, Ashish <Ashish.Gupta@cavium.com>; Sahu, Sunila
> <Sunila.Sahu@cavium.com>
> Subject: Re: [dpdk-dev] [PATCH] compressdev: clarify buffer size limitation
>
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Verma, Shally
> > Sent: Thursday, May 17, 2018 7:10 AM
> > To: Trahe, Fiona <fiona.trahe@intel.com>; dev@dpdk.org
> > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Gupta,
> > Ashish <Ashish.Gupta@cavium.com>; Sahu, Sunila
> > <Sunila.Sahu@cavium.com>
> > Subject: Re: [dpdk-dev] [PATCH] compressdev: clarify buffer size
> > limitation
> >
> >
> >
> > >-----Original Message-----
> > >From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fiona Trahe
> > >Sent: 16 May 2018 19:49
> > >To: dev@dpdk.org
> > >Cc: pablo.de.lara.guarch@intel.com; fiona.trahe@intel.com
> > >Subject: [dpdk-dev] [PATCH] compressdev: clarify buffer size
> > >limitation
> > >
> > >Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> > >---
> > > lib/librte_compressdev/rte_comp.h | 11 +++++++++--
> > > 1 file changed, 9 insertions(+), 2 deletions(-)
> > >
> > >diff --git a/lib/librte_compressdev/rte_comp.h
> > b/lib/librte_compressdev/rte_comp.h
> > >index 4c802195f..9826086b1 100644
> > >--- a/lib/librte_compressdev/rte_comp.h
> > >+++ b/lib/librte_compressdev/rte_comp.h
> > >@@ -295,12 +295,19 @@ struct rte_comp_op {
> > > struct rte_mbuf *m_src;
> > > /**< source mbuf
> > > * The total size of the input buffer(s) can be retrieved using
> > >- * rte_pktmbuf_data_len(m_src)
> > >+ * rte_pktmbuf_data_len(m_src). The max data size which can fit in a
> > >+ * single mbuf is limited by the uint16_t rte_mbuf.data_len to 64k-1.
> > >+ * If the input data is bigger than this it can be passed to the PMD in
> > >+ * a chain of mbufs if the PMD's capabilities indicate it supports this.
> > > */
> > > struct rte_mbuf *m_dst;
> > > /**< destination mbuf
> > > * The total size of the output buffer(s) can be retrieved using
> > >- * rte_pktmbuf_data_len(m_dst)
> > >+ * rte_pktmbuf_data_len(m_dst). The max data size which can fit in a
> > >+ * single mbuf is limited by the uint16_t rte_mbuf.data_len to 64k-1.
> > >+ * If the output data is expected to be bigger than this a chain of
> > >+ * mbufs can be passed to the PMD if the PMD's capabilities indicate
> > >+ * it supports this.
> > > */
> > [Shally] It will be good idea to add bit more clarification regarding
> > src.offset and dst.offset as well, that is, offset is offset from
> > start of very first segment of m_src and m_dst in chained bufs.
>
> I'd say there should be a separate patch addressing this comment.
> This one looks ok to me.
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Applied to dpdk-next-crypto.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-22 10:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-16 14:18 [dpdk-dev] [PATCH] compressdev: clarify buffer size limitation Fiona Trahe
2018-05-17 6:10 ` Verma, Shally
2018-05-21 22:32 ` De Lara Guarch, Pablo
2018-05-22 10:08 ` De Lara Guarch, Pablo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).