* [dpdk-dev] [PATCH] compressdev: clarify mbuf offsets
@ 2018-05-22 10:54 Pablo de Lara
2018-05-22 11:40 ` Verma, Shally
2018-05-22 12:58 ` Trahe, Fiona
0 siblings, 2 replies; 4+ messages in thread
From: Pablo de Lara @ 2018-05-22 10:54 UTC (permalink / raw)
To: fiona.trahe, ashish.gupta, shally.verma; +Cc: dev, Pablo de Lara
Add extra clarification about offset in source and
destination mbuf used in compressdev, when they
are a chain of mbufs.
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
lib/librte_compressdev/rte_comp.h | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/lib/librte_compressdev/rte_comp.h b/lib/librte_compressdev/rte_comp.h
index 9826086b1..5b513c77e 100644
--- a/lib/librte_compressdev/rte_comp.h
+++ b/lib/librte_compressdev/rte_comp.h
@@ -315,6 +315,8 @@ struct rte_comp_op {
/**< Starting point for compression or decompression,
* specified as number of bytes from start of packet in
* source buffer.
+ * This offset starts from the first segment
+ * of the buffer, in case the m_src is a chain of mbufs.
* Starting point for checksum generation in compress direction.
*/
uint32_t length;
@@ -328,7 +330,10 @@ struct rte_comp_op {
uint32_t offset;
/**< Starting point for writing output data, specified as
* number of bytes from start of packet in dest
- * buffer. Starting point for checksum generation in
+ * buffer.
+ * This offset starts from the first segment
+ * of the buffer, in case the m_dst is a chain of mbufs.
+ * Starting point for checksum generation in
* decompress direction.
*/
} dst;
--
2.17.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] compressdev: clarify mbuf offsets
2018-05-22 10:54 [dpdk-dev] [PATCH] compressdev: clarify mbuf offsets Pablo de Lara
@ 2018-05-22 11:40 ` Verma, Shally
2018-05-22 12:45 ` De Lara Guarch, Pablo
2018-05-22 12:58 ` Trahe, Fiona
1 sibling, 1 reply; 4+ messages in thread
From: Verma, Shally @ 2018-05-22 11:40 UTC (permalink / raw)
To: Pablo de Lara, fiona.trahe, Gupta, Ashish; +Cc: dev
>-----Original Message-----
>From: Pablo de Lara [mailto:pablo.de.lara.guarch@intel.com]
>Sent: 22 May 2018 16:25
>To: fiona.trahe@intel.com; Gupta, Ashish <Ashish.Gupta@cavium.com>; Verma, Shally <Shally.Verma@cavium.com>
>Cc: dev@dpdk.org; Pablo de Lara <pablo.de.lara.guarch@intel.com>
>Subject: [PATCH] compressdev: clarify mbuf offsets
>
>Add extra clarification about offset in source and
>destination mbuf used in compressdev, when they
>are a chain of mbufs.
>
>Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>---
Reviewed-by: Shally Verma <shally.verma@caviumnetworks.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] compressdev: clarify mbuf offsets
2018-05-22 11:40 ` Verma, Shally
@ 2018-05-22 12:45 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 4+ messages in thread
From: De Lara Guarch, Pablo @ 2018-05-22 12:45 UTC (permalink / raw)
To: Verma, Shally, Trahe, Fiona, Gupta, Ashish; +Cc: dev
> -----Original Message-----
> From: Verma, Shally [mailto:Shally.Verma@cavium.com]
> Sent: Tuesday, May 22, 2018 12:41 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; Gupta, Ashish <Ashish.Gupta@cavium.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] compressdev: clarify mbuf offsets
>
>
>
> >-----Original Message-----
> >From: Pablo de Lara [mailto:pablo.de.lara.guarch@intel.com]
> >Sent: 22 May 2018 16:25
> >To: fiona.trahe@intel.com; Gupta, Ashish <Ashish.Gupta@cavium.com>;
> >Verma, Shally <Shally.Verma@cavium.com>
> >Cc: dev@dpdk.org; Pablo de Lara <pablo.de.lara.guarch@intel.com>
> >Subject: [PATCH] compressdev: clarify mbuf offsets
> >
> >Add extra clarification about offset in source and destination mbuf
> >used in compressdev, when they are a chain of mbufs.
> >
> >Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> >---
> Reviewed-by: Shally Verma <shally.verma@caviumnetworks.com>
>
Applied to dpdk-next-crypto.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] compressdev: clarify mbuf offsets
2018-05-22 10:54 [dpdk-dev] [PATCH] compressdev: clarify mbuf offsets Pablo de Lara
2018-05-22 11:40 ` Verma, Shally
@ 2018-05-22 12:58 ` Trahe, Fiona
1 sibling, 0 replies; 4+ messages in thread
From: Trahe, Fiona @ 2018-05-22 12:58 UTC (permalink / raw)
To: De Lara Guarch, Pablo, ashish.gupta, shally.verma; +Cc: dev
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Tuesday, May 22, 2018 11:55 AM
> To: Trahe, Fiona <fiona.trahe@intel.com>; ashish.gupta@caviumnetworks.com;
> shally.verma@cavium.com
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH] compressdev: clarify mbuf offsets
>
> Add extra clarification about offset in source and
> destination mbuf used in compressdev, when they
> are a chain of mbufs.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-22 12:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-22 10:54 [dpdk-dev] [PATCH] compressdev: clarify mbuf offsets Pablo de Lara
2018-05-22 11:40 ` Verma, Shally
2018-05-22 12:45 ` De Lara Guarch, Pablo
2018-05-22 12:58 ` Trahe, Fiona
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).