[dpdk-dev] [PATCH] doc: announce ABI change for crypto info struct

[dpdk-dev] [PATCH] doc: announce ABI change for crypto info struct

[Pablo de Lara]

Since the API changes made in 17.08, the session mempool
is not created anymore in each crypto device.
Therefore, there is no need to have, in the cryptodev info
structure, the maximum number of sessions supported per device
and per queue pair.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 doc/guides/rel_notes/deprecation.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index d59ad5988..5588ba7c1 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -59,3 +59,8 @@ Deprecation Notices
   be added between the producer and consumer structures. The size of the
   structure and the offset of the fields will remain the same on
   platforms with 64B cache line, but will change on other platforms.
+
+* cryptodev: The structure ``sym``, including its fields ``max_nb_sessions``
+  and ``max_nb_sessions_per_qp``, in structure ``rte_cryptodev_info``,
+  will be removed in 18.05, as these fields are not relevant anymore
+  since the session mempool is not internal in the crypto device anymore.
-- 
2.14.3

Re: [dpdk-dev] [PATCH] doc: announce ABI change for crypto info struct

[Trahe, Fiona]

Hi Pablo,

> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Friday, January 26, 2018 9:04 AM
> To: akhil.goyal@nxp.com; hemant.agrawal@nxp.com; Doherty, Declan <declan.doherty@intel.com>;
> jerin.jacob@intel.com; Trahe, Fiona <fiona.trahe@intel.com>; Griffin, John <john.griffin@intel.com>; Jain,
> Deepak K <deepak.k.jain@intel.com>; jck@semihalf.com; tdu@semihalf.com; dima@marvell.com;
> nsamsono@marvell.com; jianbo.liu@arm.com
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH] doc: announce ABI change for crypto info struct
> 
> Since the API changes made in 17.08, the session mempool
> is not created anymore in each crypto device.
> Therefore, there is no need to have, in the cryptodev info
> structure, the maximum number of sessions supported per device
> and per queue pair.
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index d59ad5988..5588ba7c1 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -59,3 +59,8 @@ Deprecation Notices
>    be added between the producer and consumer structures. The size of the
>    structure and the offset of the fields will remain the same on
>    platforms with 64B cache line, but will change on other platforms.
> +
> +* cryptodev: The structure ``sym``, including its fields ``max_nb_sessions``
> +  and ``max_nb_sessions_per_qp``, in structure ``rte_cryptodev_info``,
> +  will be removed in 18.05, as these fields are not relevant anymore
> +  since the session mempool is not internal in the crypto device anymore.
> --
[Fiona] max_nb_sessions must be also removed from 
struct rte_cryptodev_pmd_init_params
Regards deprecation of max_nb_sessions from both structs:
Acked-by: Fiona Trahe <fiona.trahe@intel.com>

If removing the max_nb_sessions_per_qp, then the following functions should also be deprecated. 
rte_cryptodev_queue_pair_attach_sym_session
rte_cryptodev_queue_pair_detach_sym_session
These and the max_nb_session_per_qp were added here at request of NXP:
http://dpdk.org/ml/archives/dev/2017-March/060740.html

Re: [dpdk-dev] [PATCH] doc: announce ABI change for crypto info struct

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Trahe, Fiona
> Sent: Friday, January 26, 2018 10:45 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> akhil.goyal@nxp.com; hemant.agrawal@nxp.com; Doherty, Declan
> <declan.doherty@intel.com>; jerin.jacob@intel.com; Griffin, John
> <john.griffin@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>;
> jck@semihalf.com; tdu@semihalf.com; dima@marvell.com;
> nsamsono@marvell.com; jianbo.liu@arm.com
> Cc: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>
> Subject: RE: [PATCH] doc: announce ABI change for crypto info struct
> 
> Hi Pablo,
> 
> > -----Original Message-----
> > From: De Lara Guarch, Pablo
> > Sent: Friday, January 26, 2018 9:04 AM
> > To: akhil.goyal@nxp.com; hemant.agrawal@nxp.com; Doherty, Declan
> > <declan.doherty@intel.com>; jerin.jacob@intel.com; Trahe, Fiona
> > <fiona.trahe@intel.com>; Griffin, John <john.griffin@intel.com>; Jain,
> > Deepak K <deepak.k.jain@intel.com>; jck@semihalf.com;
> > tdu@semihalf.com; dima@marvell.com; nsamsono@marvell.com;
> > jianbo.liu@arm.com
> > Cc: dev@dpdk.org; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch@intel.com>
> > Subject: [PATCH] doc: announce ABI change for crypto info struct
> >
> > Since the API changes made in 17.08, the session mempool is not
> > created anymore in each crypto device.
> > Therefore, there is no need to have, in the cryptodev info structure,
> > the maximum number of sessions supported per device and per queue
> > pair.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---
> >  doc/guides/rel_notes/deprecation.rst | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst
> > b/doc/guides/rel_notes/deprecation.rst
> > index d59ad5988..5588ba7c1 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -59,3 +59,8 @@ Deprecation Notices
> >    be added between the producer and consumer structures. The size of
> the
> >    structure and the offset of the fields will remain the same on
> >    platforms with 64B cache line, but will change on other platforms.
> > +
> > +* cryptodev: The structure ``sym``, including its fields
> > +``max_nb_sessions``
> > +  and ``max_nb_sessions_per_qp``, in structure
> > +``rte_cryptodev_info``,
> > +  will be removed in 18.05, as these fields are not relevant anymore
> > +  since the session mempool is not internal in the crypto device
> anymore.
> > --
> [Fiona] max_nb_sessions must be also removed from struct
> rte_cryptodev_pmd_init_params 

Good point. Since this structure is internal, I guess we don't need a deprecation notice for it, 
but I will remove it in the patch for 18.05.

> Regards deprecation of max_nb_sessions from both structs:
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
> 
> If removing the max_nb_sessions_per_qp, then the following functions
> should also be deprecated.
> rte_cryptodev_queue_pair_attach_sym_session
> rte_cryptodev_queue_pair_detach_sym_session
> These and the max_nb_session_per_qp were added here at request of NXP:
> http://dpdk.org/ml/archives/dev/2017-March/060740.html

Akhil, do you agree on this change?

Thanks,
Pablo

Re: [dpdk-dev] [PATCH] doc: announce ABI change for crypto info struct

[Akhil Goyal]

Hi Pablo/Fiona,

On 1/26/2018 4:38 PM, De Lara Guarch, Pablo wrote:
> 
> 
>> -----Original Message-----
>> From: Trahe, Fiona
>> Sent: Friday, January 26, 2018 10:45 AM
>> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
>> akhil.goyal@nxp.com; hemant.agrawal@nxp.com; Doherty, Declan
>> <declan.doherty@intel.com>; jerin.jacob@intel.com; Griffin, John
>> <john.griffin@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>;
>> jck@semihalf.com; tdu@semihalf.com; dima@marvell.com;
>> nsamsono@marvell.com; jianbo.liu@arm.com
>> Cc: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>
>> Subject: RE: [PATCH] doc: announce ABI change for crypto info struct
>>
>> Hi Pablo,
>>
>>> -----Original Message-----
>>> From: De Lara Guarch, Pablo
>>> Sent: Friday, January 26, 2018 9:04 AM
>>> To: akhil.goyal@nxp.com; hemant.agrawal@nxp.com; Doherty, Declan
>>> <declan.doherty@intel.com>; jerin.jacob@intel.com; Trahe, Fiona
>>> <fiona.trahe@intel.com>; Griffin, John <john.griffin@intel.com>; Jain,
>>> Deepak K <deepak.k.jain@intel.com>; jck@semihalf.com;
>>> tdu@semihalf.com; dima@marvell.com; nsamsono@marvell.com;
>>> jianbo.liu@arm.com
>>> Cc: dev@dpdk.org; De Lara Guarch, Pablo
>>> <pablo.de.lara.guarch@intel.com>
>>> Subject: [PATCH] doc: announce ABI change for crypto info struct
>>>
>>> Since the API changes made in 17.08, the session mempool is not
>>> created anymore in each crypto device.
>>> Therefore, there is no need to have, in the cryptodev info structure,
>>> the maximum number of sessions supported per device and per queue
>>> pair.
>>>
>>> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>>> ---
>>>   doc/guides/rel_notes/deprecation.rst | 5 +++++
>>>   1 file changed, 5 insertions(+)
>>>
>>> diff --git a/doc/guides/rel_notes/deprecation.rst
>>> b/doc/guides/rel_notes/deprecation.rst
>>> index d59ad5988..5588ba7c1 100644
>>> --- a/doc/guides/rel_notes/deprecation.rst
>>> +++ b/doc/guides/rel_notes/deprecation.rst
>>> @@ -59,3 +59,8 @@ Deprecation Notices
>>>     be added between the producer and consumer structures. The size of
>> the
>>>     structure and the offset of the fields will remain the same on
>>>     platforms with 64B cache line, but will change on other platforms.
>>> +
>>> +* cryptodev: The structure ``sym``, including its fields
>>> +``max_nb_sessions``
>>> +  and ``max_nb_sessions_per_qp``, in structure
>>> +``rte_cryptodev_info``,
>>> +  will be removed in 18.05, as these fields are not relevant anymore
>>> +  since the session mempool is not internal in the crypto device
>> anymore.
>>> --
>> [Fiona] max_nb_sessions must be also removed from struct
>> rte_cryptodev_pmd_init_params
> 
> Good point. Since this structure is internal, I guess we don't need a deprecation notice for it,
> but I will remove it in the patch for 18.05.
> 
>> Regards deprecation of max_nb_sessions from both structs:
>> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
>>
>> If removing the max_nb_sessions_per_qp, then the following functions
>> should also be deprecated.
>> rte_cryptodev_queue_pair_attach_sym_session
>> rte_cryptodev_queue_pair_detach_sym_session
>> These and the max_nb_session_per_qp were added here at request of NXP:
>> http://dpdk.org/ml/archives/dev/2017-March/060740.html
> 
> Akhil, do you agree on this change?
> 

We recently did some changes in the driver to take care of the 
dependency for limit on max_nb_sessions_per_qp, but it is not removed 
completely. We will need to look into this. But sending the deprecation 
notice at this moment is fine. If something comes up, will let you know 
later.

-Akhil

Re: [dpdk-dev] [PATCH] doc: announce ABI change for crypto info struct

[Verma, Shally]

I do see current cryptodev unit testcase (inside \test dir) uses info.sym.max_nb_sessions param for session mempool_create. So, such testcases change are also in proposal?

Another point, we recently submitted an RFC patch on lib/cryptodev with asymmetric crypto support (https://dpdk.org/dev/patchwork/patch/34308/) which is awaiting review and these fields have role to play there. 
So, could this change be please viewed in conjunction with asym RFC?

Thanks
Shally

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Akhil Goyal
> Sent: 29 January 2018 14:57
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; hemant.agrawal@nxp.com; Doherty, Declan
> <declan.doherty@intel.com>; Griffin, John <john.griffin@intel.com>; Jain,
> Deepak K <deepak.k.jain@intel.com>; jck@semihalf.com;
> tdu@semihalf.com; dima@marvell.com; nsamsono@marvell.com;
> jianbo.liu@arm.com; Jacob, Jerin <Jerin.JacobKollanukkaran@cavium.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for crypto info
> struct
> 
> Hi Pablo/Fiona,
> 
> On 1/26/2018 4:38 PM, De Lara Guarch, Pablo wrote:
> >
> >
> >> -----Original Message-----
> >> From: Trahe, Fiona
> >> Sent: Friday, January 26, 2018 10:45 AM
> >> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> >> akhil.goyal@nxp.com; hemant.agrawal@nxp.com; Doherty, Declan
> >> <declan.doherty@intel.com>; jerin.jacob@intel.com; Griffin, John
> >> <john.griffin@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>;
> >> jck@semihalf.com; tdu@semihalf.com; dima@marvell.com;
> >> nsamsono@marvell.com; jianbo.liu@arm.com
> >> Cc: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>
> >> Subject: RE: [PATCH] doc: announce ABI change for crypto info struct
> >>
> >> Hi Pablo,
> >>
> >>> -----Original Message-----
> >>> From: De Lara Guarch, Pablo
> >>> Sent: Friday, January 26, 2018 9:04 AM
> >>> To: akhil.goyal@nxp.com; hemant.agrawal@nxp.com; Doherty, Declan
> >>> <declan.doherty@intel.com>; jerin.jacob@intel.com; Trahe, Fiona
> >>> <fiona.trahe@intel.com>; Griffin, John <john.griffin@intel.com>; Jain,
> >>> Deepak K <deepak.k.jain@intel.com>; jck@semihalf.com;
> >>> tdu@semihalf.com; dima@marvell.com; nsamsono@marvell.com;
> >>> jianbo.liu@arm.com
> >>> Cc: dev@dpdk.org; De Lara Guarch, Pablo
> >>> <pablo.de.lara.guarch@intel.com>
> >>> Subject: [PATCH] doc: announce ABI change for crypto info struct
> >>>
> >>> Since the API changes made in 17.08, the session mempool is not
> >>> created anymore in each crypto device.
> >>> Therefore, there is no need to have, in the cryptodev info structure,
> >>> the maximum number of sessions supported per device and per queue
> >>> pair.
> >>>
> >>> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> >>> ---
> >>>   doc/guides/rel_notes/deprecation.rst | 5 +++++
> >>>   1 file changed, 5 insertions(+)
> >>>
> >>> diff --git a/doc/guides/rel_notes/deprecation.rst
> >>> b/doc/guides/rel_notes/deprecation.rst
> >>> index d59ad5988..5588ba7c1 100644
> >>> --- a/doc/guides/rel_notes/deprecation.rst
> >>> +++ b/doc/guides/rel_notes/deprecation.rst
> >>> @@ -59,3 +59,8 @@ Deprecation Notices
> >>>     be added between the producer and consumer structures. The size of
> >> the
> >>>     structure and the offset of the fields will remain the same on
> >>>     platforms with 64B cache line, but will change on other platforms.
> >>> +
> >>> +* cryptodev: The structure ``sym``, including its fields
> >>> +``max_nb_sessions``
> >>> +  and ``max_nb_sessions_per_qp``, in structure
> >>> +``rte_cryptodev_info``,
> >>> +  will be removed in 18.05, as these fields are not relevant anymore
> >>> +  since the session mempool is not internal in the crypto device
> >> anymore.
> >>> --
> >> [Fiona] max_nb_sessions must be also removed from struct
> >> rte_cryptodev_pmd_init_params
> >
> > Good point. Since this structure is internal, I guess we don't need a
> deprecation notice for it,
> > but I will remove it in the patch for 18.05.
> >
> >> Regards deprecation of max_nb_sessions from both structs:
> >> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
> >>
> >> If removing the max_nb_sessions_per_qp, then the following functions
> >> should also be deprecated.
> >> rte_cryptodev_queue_pair_attach_sym_session
> >> rte_cryptodev_queue_pair_detach_sym_session
> >> These and the max_nb_session_per_qp were added here at request of
> NXP:
> >> http://dpdk.org/ml/archives/dev/2017-March/060740.html
> >
> > Akhil, do you agree on this change?
> >
> 
> We recently did some changes in the driver to take care of the
> dependency for limit on max_nb_sessions_per_qp, but it is not removed
> completely. We will need to look into this. But sending the deprecation
> notice at this moment is fine. If something comes up, will let you know
> later.
> 
> -Akhil

Re: [dpdk-dev] [PATCH] doc: announce ABI change for crypto info struct

[De Lara Guarch, Pablo]

Hi Shally/Ahkil,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Verma, Shally
> Sent: Tuesday, January 30, 2018 7:56 AM
> To: Akhil Goyal <akhil.goyal@nxp.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>;
> hemant.agrawal@nxp.com; Doherty, Declan <declan.doherty@intel.com>;
> Griffin, John <john.griffin@intel.com>; Jain, Deepak K
> <deepak.k.jain@intel.com>; jck@semihalf.com; tdu@semihalf.com;
> dima@marvell.com; nsamsono@marvell.com; jianbo.liu@arm.com; Jacob,
> Jerin <Jerin.JacobKollanukkaran@cavium.com>; Athreya, Narayana Prasad
> <NarayanaPrasad.Athreya@cavium.com>; Murthy, Nidadavolu
> <Nidadavolu.Murthy@cavium.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for crypto info
> struct
> 
> I do see current cryptodev unit testcase (inside \test dir) uses
> info.sym.max_nb_sessions param for session mempool_create. So, such
> testcases change are also in proposal?

Yes, for these tests, we can just define a macro in the tests, instead of using the info structure.
> 
> Another point, we recently submitted an RFC patch on lib/cryptodev with
> asymmetric crypto support
> (https://dpdk.org/dev/patchwork/patch/34308/) which is awaiting review
> and these fields have role to play there.
> So, could this change be please viewed in conjunction with asym RFC?

Do you need it for asymmetric? Anyway, this would remove the symmetric function and structures, not applicable for you.
> 
> Thanks
> Shally
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Akhil Goyal
> > Sent: 29 January 2018 14:57
> > To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe,
> > Fiona <fiona.trahe@intel.com>; hemant.agrawal@nxp.com; Doherty,
> Declan
> > <declan.doherty@intel.com>; Griffin, John <john.griffin@intel.com>;
> > Jain, Deepak K <deepak.k.jain@intel.com>; jck@semihalf.com;
> > tdu@semihalf.com; dima@marvell.com; nsamsono@marvell.com;
> > jianbo.liu@arm.com; Jacob, Jerin
> <Jerin.JacobKollanukkaran@cavium.com>
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for crypto
> > info struct
> >
> > Hi Pablo/Fiona,
> >
> > On 1/26/2018 4:38 PM, De Lara Guarch, Pablo wrote:
> > >
> > >
> > >> -----Original Message-----
> > >> From: Trahe, Fiona
> > >> Sent: Friday, January 26, 2018 10:45 AM
> > >> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> > >> akhil.goyal@nxp.com; hemant.agrawal@nxp.com; Doherty, Declan
> > >> <declan.doherty@intel.com>; jerin.jacob@intel.com; Griffin, John
> > >> <john.griffin@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>;
> > >> jck@semihalf.com; tdu@semihalf.com; dima@marvell.com;
> > >> nsamsono@marvell.com; jianbo.liu@arm.com
> > >> Cc: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>
> > >> Subject: RE: [PATCH] doc: announce ABI change for crypto info
> > >> struct
> > >>
> > >> Hi Pablo,
> > >>
> > >>> -----Original Message-----
> > >>> From: De Lara Guarch, Pablo
> > >>> Sent: Friday, January 26, 2018 9:04 AM
> > >>> To: akhil.goyal@nxp.com; hemant.agrawal@nxp.com; Doherty,
> Declan
> > >>> <declan.doherty@intel.com>; jerin.jacob@intel.com; Trahe, Fiona
> > >>> <fiona.trahe@intel.com>; Griffin, John <john.griffin@intel.com>;
> > >>> Jain, Deepak K <deepak.k.jain@intel.com>; jck@semihalf.com;
> > >>> tdu@semihalf.com; dima@marvell.com; nsamsono@marvell.com;
> > >>> jianbo.liu@arm.com
> > >>> Cc: dev@dpdk.org; De Lara Guarch, Pablo
> > >>> <pablo.de.lara.guarch@intel.com>
> > >>> Subject: [PATCH] doc: announce ABI change for crypto info struct
> > >>>
> > >>> Since the API changes made in 17.08, the session mempool is not
> > >>> created anymore in each crypto device.
> > >>> Therefore, there is no need to have, in the cryptodev info
> > >>> structure, the maximum number of sessions supported per device
> and
> > >>> per queue pair.
> > >>>
> > >>> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > >>> ---
> > >>>   doc/guides/rel_notes/deprecation.rst | 5 +++++
> > >>>   1 file changed, 5 insertions(+)
> > >>>
> > >>> diff --git a/doc/guides/rel_notes/deprecation.rst
> > >>> b/doc/guides/rel_notes/deprecation.rst
> > >>> index d59ad5988..5588ba7c1 100644
> > >>> --- a/doc/guides/rel_notes/deprecation.rst
> > >>> +++ b/doc/guides/rel_notes/deprecation.rst
> > >>> @@ -59,3 +59,8 @@ Deprecation Notices
> > >>>     be added between the producer and consumer structures. The
> > >>> size of
> > >> the
> > >>>     structure and the offset of the fields will remain the same on
> > >>>     platforms with 64B cache line, but will change on other platforms.
> > >>> +
> > >>> +* cryptodev: The structure ``sym``, including its fields
> > >>> +``max_nb_sessions``
> > >>> +  and ``max_nb_sessions_per_qp``, in structure
> > >>> +``rte_cryptodev_info``,
> > >>> +  will be removed in 18.05, as these fields are not relevant
> > >>> +anymore
> > >>> +  since the session mempool is not internal in the crypto device
> > >> anymore.
> > >>> --
> > >> [Fiona] max_nb_sessions must be also removed from struct
> > >> rte_cryptodev_pmd_init_params
> > >
> > > Good point. Since this structure is internal, I guess we don't need
> > > a
> > deprecation notice for it,
> > > but I will remove it in the patch for 18.05.
> > >
> > >> Regards deprecation of max_nb_sessions from both structs:
> > >> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
> > >>
> > >> If removing the max_nb_sessions_per_qp, then the following
> > >> functions should also be deprecated.
> > >> rte_cryptodev_queue_pair_attach_sym_session
> > >> rte_cryptodev_queue_pair_detach_sym_session
> > >> These and the max_nb_session_per_qp were added here at request of
> > NXP:
> > >> http://dpdk.org/ml/archives/dev/2017-March/060740.html
> > >
> > > Akhil, do you agree on this change?
> > >
> >
> > We recently did some changes in the driver to take care of the
> > dependency for limit on max_nb_sessions_per_qp, but it is not removed
> > completely. We will need to look into this. But sending the
> > deprecation notice at this moment is fine. If something comes up, will
> > let you know later.

Looks good to me. Could you ack this if you agree with it?

Thanks,
Pablo

> >
> > -Akhil

Re: [dpdk-dev] [PATCH] doc: announce ABI change for crypto info struct

[Akhil Goyal]

On 1/26/2018 2:33 PM, Pablo de Lara wrote:
> Since the API changes made in 17.08, the session mempool
> is not created anymore in each crypto device.
> Therefore, there is no need to have, in the cryptodev info
> structure, the maximum number of sessions supported per device
> and per queue pair.
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>   doc/guides/rel_notes/deprecation.rst | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index d59ad5988..5588ba7c1 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -59,3 +59,8 @@ Deprecation Notices
>     be added between the producer and consumer structures. The size of the
>     structure and the offset of the fields will remain the same on
>     platforms with 64B cache line, but will change on other platforms.
> +
> +* cryptodev: The structure ``sym``, including its fields ``max_nb_sessions``
> +  and ``max_nb_sessions_per_qp``, in structure ``rte_cryptodev_info``,
> +  will be removed in 18.05, as these fields are not relevant anymore
> +  since the session mempool is not internal in the crypto device anymore.
> 
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

Re: [dpdk-dev] [PATCH] doc: announce ABI change for crypto info struct

[Verma, Shally]

>-----Original Message-----
>From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com]
>Sent: 30 January 2018 16:51
>To: Verma, Shally <Shally.Verma@cavium.com>; Akhil Goyal <akhil.goyal@nxp.com>; Trahe, Fiona <fiona.trahe@intel.com>;
>hemant.agrawal@nxp.com; Doherty, Declan <declan.doherty@intel.com>; Griffin, John <john.griffin@intel.com>; Jain, Deepak K
><deepak.k.jain@intel.com>; jck@semihalf.com; tdu@semihalf.com; dima@marvell.com; nsamsono@marvell.com;
>jianbo.liu@arm.com; Jacob, Jerin <Jerin.JacobKollanukkaran@cavium.com>; Athreya, Narayana Prasad
><NarayanaPrasad.Athreya@cavium.com>; Murthy, Nidadavolu <Nidadavolu.Murthy@cavium.com>
>Cc: dev@dpdk.org
>Subject: RE: [dpdk-dev] [PATCH] doc: announce ABI change for crypto info struct
>
>Hi Shally/Ahkil,
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Verma, Shally
>> Sent: Tuesday, January 30, 2018 7:56 AM
>> To: Akhil Goyal <akhil.goyal@nxp.com>; De Lara Guarch, Pablo
>> <pablo.de.lara.guarch@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>;
>> hemant.agrawal@nxp.com; Doherty, Declan <declan.doherty@intel.com>;
>> Griffin, John <john.griffin@intel.com>; Jain, Deepak K
>> <deepak.k.jain@intel.com>; jck@semihalf.com; tdu@semihalf.com;
>> dima@marvell.com; nsamsono@marvell.com; jianbo.liu@arm.com; Jacob,
>> Jerin <Jerin.JacobKollanukkaran@cavium.com>; Athreya, Narayana Prasad
>> <NarayanaPrasad.Athreya@cavium.com>; Murthy, Nidadavolu
>> <Nidadavolu.Murthy@cavium.com>
>> Cc: dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for crypto info
>> struct
>>
>> I do see current cryptodev unit testcase (inside \test dir) uses
>> info.sym.max_nb_sessions param for session mempool_create. So, such
>> testcases change are also in proposal?
>
>Yes, for these tests, we can just define a macro in the tests, instead of using the info structure.

[Shally] Ok, then you mean applications will choose any random number during mempool_create and not dependent on device max_nb_sessions?

>>
>> Another point, we recently submitted an RFC patch on lib/cryptodev with
>> asymmetric crypto support
>> (https://dpdk.org/dev/patchwork/patch/34308/) which is awaiting review
>> and these fields have role to play there.
>> So, could this change be please viewed in conjunction with asym RFC?
>
>Do you need it for asymmetric? Anyway, this would remove the symmetric function and structures, not applicable for you.

[Shally] I would say addition of asym in lib/cryptodev is not entirely standalone, specifically for PMDs that can support both. 
My key concern are max_nb_sessions_per_qp and related qp_attach_sym/asym APIs which enable management of queue distribution among sym and asym in current proposal, specifically, for PMDs that can support both but have dedicated qp for each. Right now proposal is open for feedback and would prefer to be covered before sym related changes could be applied.

>>
>> Thanks
>> Shally
>>
>> > -----Original Message-----
>> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Akhil Goyal
>> > Sent: 29 January 2018 14:57
>> > To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe,
>> > Fiona <fiona.trahe@intel.com>; hemant.agrawal@nxp.com; Doherty,
>> Declan
>> > <declan.doherty@intel.com>; Griffin, John <john.griffin@intel.com>;
>> > Jain, Deepak K <deepak.k.jain@intel.com>; jck@semihalf.com;
>> > tdu@semihalf.com; dima@marvell.com; nsamsono@marvell.com;
>> > jianbo.liu@arm.com; Jacob, Jerin
>> <Jerin.JacobKollanukkaran@cavium.com>
>> > Cc: dev@dpdk.org
>> > Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for crypto
>> > info struct
>> >
>> > Hi Pablo/Fiona,
>> >
>> > On 1/26/2018 4:38 PM, De Lara Guarch, Pablo wrote:
>> > >
>> > >
>> > >> -----Original Message-----
>> > >> From: Trahe, Fiona
>> > >> Sent: Friday, January 26, 2018 10:45 AM
>> > >> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
>> > >> akhil.goyal@nxp.com; hemant.agrawal@nxp.com; Doherty, Declan
>> > >> <declan.doherty@intel.com>; jerin.jacob@intel.com; Griffin, John
>> > >> <john.griffin@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>;
>> > >> jck@semihalf.com; tdu@semihalf.com; dima@marvell.com;
>> > >> nsamsono@marvell.com; jianbo.liu@arm.com
>> > >> Cc: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>
>> > >> Subject: RE: [PATCH] doc: announce ABI change for crypto info
>> > >> struct
>> > >>
>> > >> Hi Pablo,
>> > >>
>> > >>> -----Original Message-----
>> > >>> From: De Lara Guarch, Pablo
>> > >>> Sent: Friday, January 26, 2018 9:04 AM
>> > >>> To: akhil.goyal@nxp.com; hemant.agrawal@nxp.com; Doherty,
>> Declan
>> > >>> <declan.doherty@intel.com>; jerin.jacob@intel.com; Trahe, Fiona
>> > >>> <fiona.trahe@intel.com>; Griffin, John <john.griffin@intel.com>;
>> > >>> Jain, Deepak K <deepak.k.jain@intel.com>; jck@semihalf.com;
>> > >>> tdu@semihalf.com; dima@marvell.com; nsamsono@marvell.com;
>> > >>> jianbo.liu@arm.com
>> > >>> Cc: dev@dpdk.org; De Lara Guarch, Pablo
>> > >>> <pablo.de.lara.guarch@intel.com>
>> > >>> Subject: [PATCH] doc: announce ABI change for crypto info struct
>> > >>>
>> > >>> Since the API changes made in 17.08, the session mempool is not
>> > >>> created anymore in each crypto device.
>> > >>> Therefore, there is no need to have, in the cryptodev info
>> > >>> structure, the maximum number of sessions supported per device
>> and
>> > >>> per queue pair.
>> > >>>
>> > >>> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>> > >>> ---
>> > >>>   doc/guides/rel_notes/deprecation.rst | 5 +++++
>> > >>>   1 file changed, 5 insertions(+)
>> > >>>
>> > >>> diff --git a/doc/guides/rel_notes/deprecation.rst
>> > >>> b/doc/guides/rel_notes/deprecation.rst
>> > >>> index d59ad5988..5588ba7c1 100644
>> > >>> --- a/doc/guides/rel_notes/deprecation.rst
>> > >>> +++ b/doc/guides/rel_notes/deprecation.rst
>> > >>> @@ -59,3 +59,8 @@ Deprecation Notices
>> > >>>     be added between the producer and consumer structures. The
>> > >>> size of
>> > >> the
>> > >>>     structure and the offset of the fields will remain the same on
>> > >>>     platforms with 64B cache line, but will change on other platforms.
>> > >>> +
>> > >>> +* cryptodev: The structure ``sym``, including its fields
>> > >>> +``max_nb_sessions``
>> > >>> +  and ``max_nb_sessions_per_qp``, in structure
>> > >>> +``rte_cryptodev_info``,
>> > >>> +  will be removed in 18.05, as these fields are not relevant
>> > >>> +anymore
>> > >>> +  since the session mempool is not internal in the crypto device
>> > >> anymore.
>> > >>> --
>> > >> [Fiona] max_nb_sessions must be also removed from struct
>> > >> rte_cryptodev_pmd_init_params
>> > >
>> > > Good point. Since this structure is internal, I guess we don't need
>> > > a
>> > deprecation notice for it,
>> > > but I will remove it in the patch for 18.05.
>> > >
>> > >> Regards deprecation of max_nb_sessions from both structs:
>> > >> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
>> > >>
>> > >> If removing the max_nb_sessions_per_qp, then the following
>> > >> functions should also be deprecated.
>> > >> rte_cryptodev_queue_pair_attach_sym_session
>> > >> rte_cryptodev_queue_pair_detach_sym_session
>> > >> These and the max_nb_session_per_qp were added here at request of
>> > NXP:
>> > >> http://dpdk.org/ml/archives/dev/2017-March/060740.html
>> > >
>> > > Akhil, do you agree on this change?
>> > >
>> >
>> > We recently did some changes in the driver to take care of the
>> > dependency for limit on max_nb_sessions_per_qp, but it is not removed
>> > completely. We will need to look into this. But sending the
>> > deprecation notice at this moment is fine. If something comes up, will
>> > let you know later.
>
>Looks good to me. Could you ack this if you agree with it?
>
>Thanks,
>Pablo
>
>> >
>> > -Akhil

[dpdk-dev] [PATCH v2 0/3] Cryptodev API/ABI deprecation notices

[Pablo de Lara]

v2:
- Added an extra deprecation announcement
- Bonded the other two deprecation notices with the new one in a
  patchset

Pablo de Lara (3):
  doc: announce ABI change for crypto info struct
  doc: announce deprecation for attach/detach crypto session
  doc: announce deprecation in crypto queue pair start/stop

 doc/guides/rel_notes/deprecation.rst | 15 +++++++++++++++
 lib/librte_cryptodev/rte_cryptodev.h |  4 ++++
 2 files changed, 19 insertions(+)

-- 
2.14.3

[dpdk-dev] [PATCH v2 1/3] doc: announce ABI change for crypto info struct

[Pablo de Lara]

Since the API changes made in 17.08, the session mempool
is not created anymore in each crypto device.
Therefore, there is no need to have, in the cryptodev info
structure, the maximum number of sessions supported per device
and per queue pair.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
---
 doc/guides/rel_notes/deprecation.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index d59ad5988..5588ba7c1 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -59,3 +59,8 @@ Deprecation Notices
   be added between the producer and consumer structures. The size of the
   structure and the offset of the fields will remain the same on
   platforms with 64B cache line, but will change on other platforms.
+
+* cryptodev: The structure ``sym``, including its fields ``max_nb_sessions``
+  and ``max_nb_sessions_per_qp``, in structure ``rte_cryptodev_info``,
+  will be removed in 18.05, as these fields are not relevant anymore
+  since the session mempool is not internal in the crypto device anymore.
-- 
2.14.3

[dpdk-dev] [PATCH v2 2/3] doc: announce deprecation for attach/detach crypto session

[Pablo de Lara]

Functions rte_cryptodev_queue_pair_attach_sym_session
and rte_cryptodev_queue_pair_detach_sym_sessions
are not really used in any of the crypto drivers
(only one driver implements it and it just return 0).
Therefore, this API can be deprecated from 18.02
and removed in 18.05.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 doc/guides/rel_notes/deprecation.rst | 5 +++++
 lib/librte_cryptodev/rte_cryptodev.h | 2 ++
 2 files changed, 7 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 5588ba7c1..bd4200bba 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -64,3 +64,8 @@ Deprecation Notices
   and ``max_nb_sessions_per_qp``, in structure ``rte_cryptodev_info``,
   will be removed in 18.05, as these fields are not relevant anymore
   since the session mempool is not internal in the crypto device anymore.
+
+* cryptodev: Functions ``rte_cryptodev_queue_pair_attach_sym_session()`` and
+  ``rte_cryptodev_queue_pair_dettach_sym_session()`` will be deprecated from
+  18.02 and removed in 18.05, as there are no drivers doing anything useful
+  with them.
diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
index c8fa68935..4597f864d 100644
--- a/lib/librte_cryptodev/rte_cryptodev.h
+++ b/lib/librte_cryptodev/rte_cryptodev.h
@@ -986,6 +986,7 @@ unsigned int
 rte_cryptodev_get_private_session_size(uint8_t dev_id);
 
 /**
+ * @deprecated
  * Attach queue pair with sym session.
  *
  * @param	dev_id		Device to which the session will be attached.
@@ -1002,6 +1003,7 @@ rte_cryptodev_queue_pair_attach_sym_session(uint8_t dev_id, uint16_t qp_id,
 		struct rte_cryptodev_sym_session *session);
 
 /**
+ * @deprecated
  * Detach queue pair with sym session.
  *
  * @param	dev_id		Device to which the session is attached.
-- 
2.14.3

[dpdk-dev] [PATCH v2 3/3] doc: announce deprecation in crypto queue pair start/stop

[Pablo de Lara]

Functions rte_cryptodev_queue_pair_start/stop
are not really used in any of the crypto drivers
(they all just return 0 or -ENOTSUP).
Therefore, this API can be deprecated from 18.02
and removed in 18.05.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
---
 doc/guides/rel_notes/deprecation.rst | 5 +++++
 lib/librte_cryptodev/rte_cryptodev.h | 2 ++
 2 files changed, 7 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index bd4200bba..805fb885e 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -69,3 +69,8 @@ Deprecation Notices
   ``rte_cryptodev_queue_pair_dettach_sym_session()`` will be deprecated from
   18.02 and removed in 18.05, as there are no drivers doing anything useful
   with them.
+
+* cryptodev: Functions ``rte_cryptodev_queue_pair_start()`` and
+  ``rte_cryptodev_queue_pair_stop()`` will be deprecated from 18.02
+  and removed in 18.05, as there are no drivers doing anything useful
+  with them.
diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
index 4597f864d..712342c72 100644
--- a/lib/librte_cryptodev/rte_cryptodev.h
+++ b/lib/librte_cryptodev/rte_cryptodev.h
@@ -602,6 +602,7 @@ rte_cryptodev_queue_pair_setup(uint8_t dev_id, uint16_t queue_pair_id,
 		struct rte_mempool *session_pool);
 
 /**
+ * @deprecated
  * Start a specified queue pair of a device. It is used
  * when deferred_start flag of the specified queue is true.
  *
@@ -619,6 +620,7 @@ extern int
 rte_cryptodev_queue_pair_start(uint8_t dev_id, uint16_t queue_pair_id);
 
 /**
+ * @deprecated
  * Stop specified queue pair of a device
  *
  * @param	dev_id		The identifier of the device
-- 
2.14.3

Re: [dpdk-dev] [PATCH] doc: announce ABI change for crypto info struct

[De Lara Guarch, Pablo]

Hi Shally,

> -----Original Message-----
> From: Verma, Shally [mailto:Shally.Verma@cavium.com]
> Sent: Tuesday, January 30, 2018 11:54 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Akhil Goyal
> <akhil.goyal@nxp.com>; Trahe, Fiona <fiona.trahe@intel.com>;
> hemant.agrawal@nxp.com; Doherty, Declan <declan.doherty@intel.com>;
> Griffin, John <john.griffin@intel.com>; Jain, Deepak K
> <deepak.k.jain@intel.com>; jck@semihalf.com; tdu@semihalf.com;
> dima@marvell.com; nsamsono@marvell.com; jianbo.liu@arm.com; Jacob,
> Jerin <Jerin.JacobKollanukkaran@cavium.com>; Athreya, Narayana Prasad
> <NarayanaPrasad.Athreya@cavium.com>; Murthy, Nidadavolu
> <Nidadavolu.Murthy@cavium.com>
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] doc: announce ABI change for crypto info
> struct
> 
> 
> 
> >-----Original Message-----
> >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com]
> >Sent: 30 January 2018 16:51
> >To: Verma, Shally <Shally.Verma@cavium.com>; Akhil Goyal
> ><akhil.goyal@nxp.com>; Trahe, Fiona <fiona.trahe@intel.com>;
> >hemant.agrawal@nxp.com; Doherty, Declan <declan.doherty@intel.com>;
> >Griffin, John <john.griffin@intel.com>; Jain, Deepak K
> ><deepak.k.jain@intel.com>; jck@semihalf.com; tdu@semihalf.com;
> >dima@marvell.com; nsamsono@marvell.com; jianbo.liu@arm.com; Jacob,
> >Jerin <Jerin.JacobKollanukkaran@cavium.com>; Athreya, Narayana Prasad
> ><NarayanaPrasad.Athreya@cavium.com>; Murthy, Nidadavolu
> ><Nidadavolu.Murthy@cavium.com>
> >Cc: dev@dpdk.org
> >Subject: RE: [dpdk-dev] [PATCH] doc: announce ABI change for crypto
> >info struct
> >
> >Hi Shally/Ahkil,
> >
> >> -----Original Message-----
> >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Verma, Shally
> >> Sent: Tuesday, January 30, 2018 7:56 AM
> >> To: Akhil Goyal <akhil.goyal@nxp.com>; De Lara Guarch, Pablo
> >> <pablo.de.lara.guarch@intel.com>; Trahe, Fiona
> >> <fiona.trahe@intel.com>; hemant.agrawal@nxp.com; Doherty, Declan
> >> <declan.doherty@intel.com>; Griffin, John <john.griffin@intel.com>;
> >> Jain, Deepak K <deepak.k.jain@intel.com>; jck@semihalf.com;
> >> tdu@semihalf.com; dima@marvell.com; nsamsono@marvell.com;
> >> jianbo.liu@arm.com; Jacob, Jerin
> >> <Jerin.JacobKollanukkaran@cavium.com>; Athreya, Narayana Prasad
> >> <NarayanaPrasad.Athreya@cavium.com>; Murthy, Nidadavolu
> >> <Nidadavolu.Murthy@cavium.com>
> >> Cc: dev@dpdk.org
> >> Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for crypto
> >> info struct
> >>
> >> I do see current cryptodev unit testcase (inside \test dir) uses
> >> info.sym.max_nb_sessions param for session mempool_create. So, such
> >> testcases change are also in proposal?
> >
> >Yes, for these tests, we can just define a macro in the tests, instead of
> using the info structure.
> 
> [Shally] Ok, then you mean applications will choose any random number
> during mempool_create and not dependent on device max_nb_sessions?

Yes, actually for the unit tests, even one session is enough.

> 
> >>
> >> Another point, we recently submitted an RFC patch on lib/cryptodev
> >> with asymmetric crypto support
> >> (https://dpdk.org/dev/patchwork/patch/34308/) which is awaiting
> >> review and these fields have role to play there.
> >> So, could this change be please viewed in conjunction with asym RFC?
> >
> >Do you need it for asymmetric? Anyway, this would remove the
> symmetric function and structures, not applicable for you.
> 
> [Shally] I would say addition of asym in lib/cryptodev is not entirely
> standalone, specifically for PMDs that can support both.
> My key concern are max_nb_sessions_per_qp and related
> qp_attach_sym/asym APIs which enable management of queue distribution
> among sym and asym in current proposal, specifically, for PMDs that can
> support both but have dedicated qp for each. Right now proposal is open
> for feedback and would prefer to be covered before sym related changes
> could be applied.

Actually, I have been thinking about this. Given the time we have until 18.02 is out,
and that this is not urgent to be applied (this is just code cleanup),
I am postponing this until next release. 

My other reason is that the info structure has a rte_pci_device pointer which should be removed.
However, I believe it is better to leave it for next release and discuss it with other libraries which has this, like ethdev.

Thanks,
Pablo

Re: [dpdk-dev] [PATCH] doc: announce ABI change for crypto info struct

[Verma, Shally]

>-----Original Message-----
>From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com]
>Sent: 02 February 2018 14:38
>To: Verma, Shally <Shally.Verma@cavium.com>; Akhil Goyal <akhil.goyal@nxp.com>; Trahe, Fiona <fiona.trahe@intel.com>;
>hemant.agrawal@nxp.com; Doherty, Declan <declan.doherty@intel.com>; Griffin, John <john.griffin@intel.com>; Jain, Deepak K
><deepak.k.jain@intel.com>; jck@semihalf.com; tdu@semihalf.com; dima@marvell.com; nsamsono@marvell.com;
>jianbo.liu@arm.com; Jacob, Jerin <Jerin.JacobKollanukkaran@cavium.com>; Athreya, Narayana Prasad
><NarayanaPrasad.Athreya@cavium.com>; Murthy, Nidadavolu <Nidadavolu.Murthy@cavium.com>
>Cc: dev@dpdk.org
>Subject: RE: [dpdk-dev] [PATCH] doc: announce ABI change for crypto info struct
>
>Hi Shally,
>
>> -----Original Message-----
>> From: Verma, Shally [mailto:Shally.Verma@cavium.com]
>> Sent: Tuesday, January 30, 2018 11:54 AM
>> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Akhil Goyal
>> <akhil.goyal@nxp.com>; Trahe, Fiona <fiona.trahe@intel.com>;
>> hemant.agrawal@nxp.com; Doherty, Declan <declan.doherty@intel.com>;
>> Griffin, John <john.griffin@intel.com>; Jain, Deepak K
>> <deepak.k.jain@intel.com>; jck@semihalf.com; tdu@semihalf.com;
>> dima@marvell.com; nsamsono@marvell.com; jianbo.liu@arm.com; Jacob,
>> Jerin <Jerin.JacobKollanukkaran@cavium.com>; Athreya, Narayana Prasad
>> <NarayanaPrasad.Athreya@cavium.com>; Murthy, Nidadavolu
>> <Nidadavolu.Murthy@cavium.com>
>> Cc: dev@dpdk.org
>> Subject: RE: [dpdk-dev] [PATCH] doc: announce ABI change for crypto info
>> struct
>>
>>
>>
>> >-----Original Message-----
>> >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com]
>> >Sent: 30 January 2018 16:51
>> >To: Verma, Shally <Shally.Verma@cavium.com>; Akhil Goyal
>> ><akhil.goyal@nxp.com>; Trahe, Fiona <fiona.trahe@intel.com>;
>> >hemant.agrawal@nxp.com; Doherty, Declan <declan.doherty@intel.com>;
>> >Griffin, John <john.griffin@intel.com>; Jain, Deepak K
>> ><deepak.k.jain@intel.com>; jck@semihalf.com; tdu@semihalf.com;
>> >dima@marvell.com; nsamsono@marvell.com; jianbo.liu@arm.com; Jacob,
>> >Jerin <Jerin.JacobKollanukkaran@cavium.com>; Athreya, Narayana Prasad
>> ><NarayanaPrasad.Athreya@cavium.com>; Murthy, Nidadavolu
>> ><Nidadavolu.Murthy@cavium.com>
>> >Cc: dev@dpdk.org
>> >Subject: RE: [dpdk-dev] [PATCH] doc: announce ABI change for crypto
>> >info struct
>> >
>> >Hi Shally/Ahkil,
>> >
>> >> -----Original Message-----
>> >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Verma, Shally
>> >> Sent: Tuesday, January 30, 2018 7:56 AM
>> >> To: Akhil Goyal <akhil.goyal@nxp.com>; De Lara Guarch, Pablo
>> >> <pablo.de.lara.guarch@intel.com>; Trahe, Fiona
>> >> <fiona.trahe@intel.com>; hemant.agrawal@nxp.com; Doherty, Declan
>> >> <declan.doherty@intel.com>; Griffin, John <john.griffin@intel.com>;
>> >> Jain, Deepak K <deepak.k.jain@intel.com>; jck@semihalf.com;
>> >> tdu@semihalf.com; dima@marvell.com; nsamsono@marvell.com;
>> >> jianbo.liu@arm.com; Jacob, Jerin
>> >> <Jerin.JacobKollanukkaran@cavium.com>; Athreya, Narayana Prasad
>> >> <NarayanaPrasad.Athreya@cavium.com>; Murthy, Nidadavolu
>> >> <Nidadavolu.Murthy@cavium.com>
>> >> Cc: dev@dpdk.org
>> >> Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for crypto
>> >> info struct
>> >>
>> >> I do see current cryptodev unit testcase (inside \test dir) uses
>> >> info.sym.max_nb_sessions param for session mempool_create. So, such
>> >> testcases change are also in proposal?
>> >
>> >Yes, for these tests, we can just define a macro in the tests, instead of
>> using the info structure.
>>
>> [Shally] Ok, then you mean applications will choose any random number
>> during mempool_create and not dependent on device max_nb_sessions?
>
>Yes, actually for the unit tests, even one session is enough.
>
>>
>> >>
>> >> Another point, we recently submitted an RFC patch on lib/cryptodev
>> >> with asymmetric crypto support
>> >> (https://dpdk.org/dev/patchwork/patch/34308/) which is awaiting
>> >> review and these fields have role to play there.
>> >> So, could this change be please viewed in conjunction with asym RFC?
>> >
>> >Do you need it for asymmetric? Anyway, this would remove the
>> symmetric function and structures, not applicable for you.
>>
>> [Shally] I would say addition of asym in lib/cryptodev is not entirely
>> standalone, specifically for PMDs that can support both.
>> My key concern are max_nb_sessions_per_qp and related
>> qp_attach_sym/asym APIs which enable management of queue distribution
>> among sym and asym in current proposal, specifically, for PMDs that can
>> support both but have dedicated qp for each. Right now proposal is open
>> for feedback and would prefer to be covered before sym related changes
>> could be applied.
>
>Actually, I have been thinking about this. Given the time we have until 18.02 is out,
>and that this is not urgent to be applied (this is just code cleanup),
>I am postponing this until next release.
>
[Shally] Ok. Thanks for acknowledging this.

>My other reason is that the info structure has a rte_pci_device pointer which should be removed.
>However, I believe it is better to leave it for next release and discuss it with other libraries which has this, like ethdev.
>
>Thanks,
>Pablo

Re: [dpdk-dev] [PATCH v2 0/3] Cryptodev API/ABI deprecation notices

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Tuesday, January 30, 2018 12:14 PM
> To: akhil.goyal@nxp.com; hemant.agrawal@nxp.com; Doherty, Declan
> <declan.doherty@intel.com>; jerin.jacob@caviumnetworks.com; Trahe,
> Fiona <fiona.trahe@intel.com>; Griffin, John <john.griffin@intel.com>; Jain,
> Deepak K <deepak.k.jain@intel.com>; jck@semihalf.com;
> tdu@semihalf.com; dima@marvell.com; nsamsono@marvell.com;
> jianbo.liu@arm.com
> Cc: dev@dpdk.org; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH v2 0/3] Cryptodev API/ABI deprecation notices
> 
> v2:
> - Added an extra deprecation announcement
> - Bonded the other two deprecation notices with the new one in a
>   patchset
> 
> Pablo de Lara (3):
>   doc: announce ABI change for crypto info struct
>   doc: announce deprecation for attach/detach crypto session
>   doc: announce deprecation in crypto queue pair start/stop
> 
>  doc/guides/rel_notes/deprecation.rst | 15 +++++++++++++++
> lib/librte_cryptodev/rte_cryptodev.h |  4 ++++
>  2 files changed, 19 insertions(+)
> 
> --
> 2.14.3

Deferring this to 18.05, so we could discuss a replacement for pci_dev structure
in the cryptodev info structure, also needed for ethdev.

Pablo

[dpdk-dev] [PATCH v3 0/4] Cryptodev API/ABI deprecation notices

[Pablo de Lara]

v3:
- Added an extra deprecation announcement (replacing rte_pci_device
  with rte_device)
- Rebased against latest DPDK code

v2:
- Added an extra deprecation announcement
- Bonded the other two deprecation notices with the new one in a
  patchset

Pablo de Lara (4):
  doc: announce ABI change for crypto sym info struct
  doc: announce ABI change for crypto info struct
  doc: announce deprecation for attach/detach crypto session
  doc: announce deprecation in crypto queue pair start/stop

 doc/guides/rel_notes/deprecation.rst | 17 +++++++++++++++++
 lib/librte_cryptodev/rte_cryptodev.h |  4 ++++
 2 files changed, 21 insertions(+)

-- 
2.17.0

[dpdk-dev] [PATCH v3 1/4] doc: announce ABI change for crypto sym info struct

[Pablo de Lara]

Since the API changes made in 17.08, the session mempool
is not created anymore in each crypto device.
Therefore, there is no need to have, in the cryptodev info
structure, the maximum number of sessions supported per device
and per queue pair.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
---
 doc/guides/rel_notes/deprecation.rst | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index c3b79a22f..d6cccbfde 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -71,3 +71,10 @@ Deprecation Notices
   - ``rte_pdump_set_socket_dir`` will be removed;
   - The parameter, ``path``, of ``rte_pdump_init`` will be removed;
   - The enum ``rte_pdump_socktype`` will be removed.
+
+* cryptodev: The following changes will be made in the library
+  for 18.08:
+
+  - Removal of ``sym`` structure in ``rte_cryptodev_info`` structure,
+    containing fields not relevant anymore since the session mempool
+    is not internal in the crypto device anymore.
-- 
2.17.0

[dpdk-dev] [PATCH v3 2/4] doc: announce ABI change for crypto info struct

[Pablo de Lara]

Cryptodev info structure currently contains
a pointer to an rte_pci_device structure.
This field depends on a specific bus type (PCI),
which is not following a bus independent design.
Following the same approach taken in ethdev, the field
will be replaced with a pointer to an rte_device structure.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 doc/guides/rel_notes/deprecation.rst | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index d6cccbfde..85945ee72 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -78,3 +78,5 @@ Deprecation Notices
   - Removal of ``sym`` structure in ``rte_cryptodev_info`` structure,
     containing fields not relevant anymore since the session mempool
     is not internal in the crypto device anymore.
+  - Replacement of ``pci_dev`` field with the more generic ``rte_device``
+    structure.
-- 
2.17.0

[dpdk-dev] [PATCH v3 3/4] doc: announce deprecation for attach/detach crypto session

[Pablo de Lara]

Functions rte_cryptodev_queue_pair_attach_sym_session
and rte_cryptodev_queue_pair_detach_sym_sessions
are not really used in any of the crypto drivers
(only one driver implements it and it just return 0).
Therefore, this API can be deprecated from 18.05
and removed in 18.08.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 lib/librte_cryptodev/rte_cryptodev.h | 2 ++
 2 files changed, 6 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 85945ee72..cd75150a6 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -80,3 +80,7 @@ Deprecation Notices
     is not internal in the crypto device anymore.
   - Replacement of ``pci_dev`` field with the more generic ``rte_device``
     structure.
+  - Functions ``rte_cryptodev_queue_pair_attach_sym_session()`` and
+    ``rte_cryptodev_queue_pair_dettach_sym_session()`` will be deprecated from
+    18.02 and removed in 18.05, as there are no drivers doing anything useful
+    with them.
diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
index 261a359dc..93eb9ffe2 100644
--- a/lib/librte_cryptodev/rte_cryptodev.h
+++ b/lib/librte_cryptodev/rte_cryptodev.h
@@ -986,6 +986,7 @@ unsigned int
 rte_cryptodev_get_private_session_size(uint8_t dev_id);
 
 /**
+ * @deprecated
  * Attach queue pair with sym session.
  *
  * @param	dev_id		Device to which the session will be attached.
@@ -1002,6 +1003,7 @@ rte_cryptodev_queue_pair_attach_sym_session(uint8_t dev_id, uint16_t qp_id,
 		struct rte_cryptodev_sym_session *session);
 
 /**
+ * @deprecated
  * Detach queue pair with sym session.
  *
  * @param	dev_id		Device to which the session is attached.
-- 
2.17.0

[dpdk-dev] [PATCH v3 4/4] doc: announce deprecation in crypto queue pair start/stop

[Pablo de Lara]

Functions rte_cryptodev_queue_pair_start/stop
are not really used in any of the crypto drivers
(they all just return 0 or -ENOTSUP).
Therefore, this API can be deprecated from 18.02
and removed in 18.05.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 lib/librte_cryptodev/rte_cryptodev.h | 2 ++
 2 files changed, 6 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index cd75150a6..6c7978d1b 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -84,3 +84,7 @@ Deprecation Notices
     ``rte_cryptodev_queue_pair_dettach_sym_session()`` will be deprecated from
     18.02 and removed in 18.05, as there are no drivers doing anything useful
     with them.
+  - Functions ``rte_cryptodev_queue_pair_start()`` and
+    ``rte_cryptodev_queue_pair_stop()`` will be deprecated from 18.02
+    and removed in 18.05, as there are no drivers doing anything useful
+    with them.
diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
index 93eb9ffe2..364cc4399 100644
--- a/lib/librte_cryptodev/rte_cryptodev.h
+++ b/lib/librte_cryptodev/rte_cryptodev.h
@@ -602,6 +602,7 @@ rte_cryptodev_queue_pair_setup(uint8_t dev_id, uint16_t queue_pair_id,
 		struct rte_mempool *session_pool);
 
 /**
+ * @deprecated
  * Start a specified queue pair of a device. It is used
  * when deferred_start flag of the specified queue is true.
  *
@@ -619,6 +620,7 @@ extern int
 rte_cryptodev_queue_pair_start(uint8_t dev_id, uint16_t queue_pair_id);
 
 /**
+ * @deprecated
  * Stop specified queue pair of a device
  *
  * @param	dev_id		The identifier of the device
-- 
2.17.0

Re: [dpdk-dev] [PATCH v3 3/4] doc: announce deprecation for attach/detach crypto session

[Trahe, Fiona]

Hi Pablo,



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Thursday, May 17, 2018 10:01 AM
> To: Doherty, Declan <declan.doherty@intel.com>; akhil.goyal@nxp.com
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [dpdk-dev] [PATCH v3 3/4] doc: announce deprecation for attach/detach crypto session
> 
> Functions rte_cryptodev_queue_pair_attach_sym_session
> and rte_cryptodev_queue_pair_detach_sym_sessions
> are not really used in any of the crypto drivers
> (only one driver implements it and it just return 0).
> Therefore, this API can be deprecated from 18.05
> and removed in 18.08.
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 4 ++++
>  lib/librte_cryptodev/rte_cryptodev.h | 2 ++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 85945ee72..cd75150a6 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -80,3 +80,7 @@ Deprecation Notices
>      is not internal in the crypto device anymore.
>    - Replacement of ``pci_dev`` field with the more generic ``rte_device``
>      structure.
> +  - Functions ``rte_cryptodev_queue_pair_attach_sym_session()`` and
> +    ``rte_cryptodev_queue_pair_dettach_sym_session()`` will be deprecated from
> +    18.02 and removed in 18.05, as there are no drivers doing anything useful
[Fiona] This should read 18.05 / 18.08

Apart from that 
Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Re: [dpdk-dev] [PATCH v3 2/4] doc: announce ABI change for crypto info struct

[Trahe, Fiona]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Thursday, May 17, 2018 10:01 AM
> To: Doherty, Declan <declan.doherty@intel.com>; akhil.goyal@nxp.com
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [dpdk-dev] [PATCH v3 2/4] doc: announce ABI change for crypto info struct
> 
> Cryptodev info structure currently contains
> a pointer to an rte_pci_device structure.
> This field depends on a specific bus type (PCI),
> which is not following a bus independent design.
> Following the same approach taken in ethdev, the field
> will be replaced with a pointer to an rte_device structure.
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Re: [dpdk-dev] [PATCH v3 4/4] doc: announce deprecation in crypto queue pair start/stop

[Trahe, Fiona]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Thursday, May 17, 2018 10:01 AM
> To: Doherty, Declan <declan.doherty@intel.com>; akhil.goyal@nxp.com
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [dpdk-dev] [PATCH v3 4/4] doc: announce deprecation in crypto queue pair start/stop
> 
> Functions rte_cryptodev_queue_pair_start/stop
> are not really used in any of the crypto drivers
> (they all just return 0 or -ENOTSUP).
> Therefore, this API can be deprecated from 18.02
> and removed in 18.05.
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
[Fiona] I guess you mean 18.05/18.08. Apart from that 
Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Re: [dpdk-dev] [PATCH v3 2/4] doc: announce ABI change for crypto info struct

[Akhil Goyal]

On 5/17/2018 2:30 PM, Pablo de Lara wrote:
> Cryptodev info structure currently contains
> a pointer to an rte_pci_device structure.
> This field depends on a specific bus type (PCI),
> which is not following a bus independent design.
> Following the same approach taken in ethdev, the field
> will be replaced with a pointer to an rte_device structure.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

Re: [dpdk-dev] [PATCH v3 1/4] doc: announce ABI change for crypto sym info struct

[Akhil Goyal]

On 5/17/2018 2:30 PM, Pablo de Lara wrote:
> Since the API changes made in 17.08, the session mempool
> is not created anymore in each crypto device.
> Therefore, there is no need to have, in the cryptodev info
> structure, the maximum number of sessions supported per device
> and per queue pair.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
> ---
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

Re: [dpdk-dev] [PATCH v3 3/4] doc: announce deprecation for attach/detach crypto session

[Akhil Goyal]

>> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
>> index 85945ee72..cd75150a6 100644
>> --- a/doc/guides/rel_notes/deprecation.rst
>> +++ b/doc/guides/rel_notes/deprecation.rst
>> @@ -80,3 +80,7 @@ Deprecation Notices
>>      is not internal in the crypto device anymore.
>>    - Replacement of ``pci_dev`` field with the more generic ``rte_device``
>>      structure.
>> +  - Functions ``rte_cryptodev_queue_pair_attach_sym_session()`` and
>> +    ``rte_cryptodev_queue_pair_dettach_sym_session()`` will be deprecated from
>> +    18.02 and removed in 18.05, as there are no drivers doing anything useful
> [Fiona] This should read 18.05 / 18.08
>
> Apart from that
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
>
With the above change
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

[dpdk-dev] [PATCH v4 0/6] Cryptodev API/ABI deprecation notices

[Pablo de Lara]

v4:
- Fixed DPDK versions called out to deprecate/remove API.
- Removed rte_cryptodev_queue_pair_attach_sym_session call
  from the IPSec gw app, since the function is deprecated now.
- Added patch announcing a replacement of some of the crypto
  feature flags
- Added patch renaming two symmetric specific functions
  from *_session_* to *_sym_session_*.

v3:
- Added an extra deprecation announcement (replacing rte_pci_device
  with rte_device)
- Rebased against latest DPDK code

v2:
- Added an extra deprecation announcement
- Bonded the other two deprecation notices with the new one in a
  patchset


Pablo de Lara (6):
  doc: announce ABI change for crypto sym info struct
  doc: announce ABI change for crypto info struct
  doc: announce deprecation for attach/detach crypto session
  doc: announce deprecation in crypto queue pair start/stop
  doc: announce deprecation in crypto feature flags
  cryptodev: rename get session size API

 app/test-crypto-perf/main.c                   |  2 +-
 doc/guides/prog_guide/cryptodev_lib.rst       |  6 ++--
 doc/guides/rel_notes/deprecation.rst          | 25 +++++++++++++
 drivers/crypto/aesni_gcm/aesni_gcm_pmd.c      |  2 +-
 drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c    |  2 +-
 drivers/crypto/armv8/rte_armv8_pmd.c          |  2 +-
 drivers/crypto/kasumi/rte_kasumi_pmd.c        |  2 +-
 drivers/crypto/openssl/rte_openssl_pmd.c      |  2 +-
 drivers/crypto/snow3g/rte_snow3g_pmd.c        |  2 +-
 drivers/crypto/zuc/rte_zuc_pmd.c              |  2 +-
 examples/ipsec-secgw/ipsec-secgw.c            |  2 +-
 examples/ipsec-secgw/ipsec.c                  | 12 -------
 examples/l2fwd-crypto/main.c                  |  2 +-
 examples/vhost_crypto/main.c                  |  2 +-
 lib/librte_cryptodev/rte_cryptodev.c          | 12 +++++++
 lib/librte_cryptodev/rte_cryptodev.h          | 35 +++++++++++++++++++
 .../rte_cryptodev_version.map                 |  8 +++++
 test/test/test_cryptodev.c                    |  6 ++--
 test/test/test_event_crypto_adapter.c         |  2 +-
 19 files changed, 99 insertions(+), 29 deletions(-)

-- 
2.17.0

[dpdk-dev] [PATCH v4 1/6] doc: announce ABI change for crypto sym info struct

[Pablo de Lara]

Since the API changes made in 17.08, the session mempool
is not created anymore in each crypto device.
Therefore, there is no need to have, in the cryptodev info
structure, the maximum number of sessions supported per device
and per queue pair.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
---
 doc/guides/rel_notes/deprecation.rst | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index c3b79a22f..d6cccbfde 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -71,3 +71,10 @@ Deprecation Notices
   - ``rte_pdump_set_socket_dir`` will be removed;
   - The parameter, ``path``, of ``rte_pdump_init`` will be removed;
   - The enum ``rte_pdump_socktype`` will be removed.
+
+* cryptodev: The following changes will be made in the library
+  for 18.08:
+
+  - Removal of ``sym`` structure in ``rte_cryptodev_info`` structure,
+    containing fields not relevant anymore since the session mempool
+    is not internal in the crypto device anymore.
-- 
2.17.0

[dpdk-dev] [PATCH v4 2/6] doc: announce ABI change for crypto info struct

[Pablo de Lara]

Cryptodev info structure currently contains
a pointer to an rte_pci_device structure.
This field depends on a specific bus type (PCI),
which is not following a bus independent design.
Following the same approach taken in ethdev, the field
will be replaced with a pointer to an rte_device structure.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
---
 doc/guides/rel_notes/deprecation.rst | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index d6cccbfde..85945ee72 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -78,3 +78,5 @@ Deprecation Notices
   - Removal of ``sym`` structure in ``rte_cryptodev_info`` structure,
     containing fields not relevant anymore since the session mempool
     is not internal in the crypto device anymore.
+  - Replacement of ``pci_dev`` field with the more generic ``rte_device``
+    structure.
-- 
2.17.0

[dpdk-dev] [PATCH v4 3/6] doc: announce deprecation for attach/detach crypto session

[Pablo de Lara]

Functions rte_cryptodev_queue_pair_attach_sym_session
and rte_cryptodev_queue_pair_detach_sym_sessions
are not really used in any of the crypto drivers
(only one driver implements it and it just return 0).
Therefore, this API can be deprecated from 18.05
and removed in 18.08.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
---
 doc/guides/rel_notes/deprecation.rst |  4 ++++
 examples/ipsec-secgw/ipsec.c         | 12 ------------
 lib/librte_cryptodev/rte_cryptodev.h |  4 ++++
 3 files changed, 8 insertions(+), 12 deletions(-)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 85945ee72..b5d1cc0d5 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -80,3 +80,7 @@ Deprecation Notices
     is not internal in the crypto device anymore.
   - Replacement of ``pci_dev`` field with the more generic ``rte_device``
     structure.
+  - Functions ``rte_cryptodev_queue_pair_attach_sym_session()`` and
+    ``rte_cryptodev_queue_pair_dettach_sym_session()`` will be deprecated from
+    18.05 and removed in 18.08, as there are no drivers doing anything useful
+    with them.
diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c
index 6c896477c..3d415f1af 100644
--- a/examples/ipsec-secgw/ipsec.c
+++ b/examples/ipsec-secgw/ipsec.c
@@ -327,18 +327,6 @@ create_session(struct ipsec_ctx *ipsec_ctx, struct ipsec_sa *sa)
 
 		rte_cryptodev_info_get(ipsec_ctx->tbl[cdev_id_qp].id,
 				&cdev_info);
-		if (cdev_info.sym.max_nb_sessions_per_qp > 0) {
-			ret = rte_cryptodev_queue_pair_attach_sym_session(
-					ipsec_ctx->tbl[cdev_id_qp].id,
-					ipsec_ctx->tbl[cdev_id_qp].qp,
-					sa->crypto_session);
-			if (ret < 0) {
-				RTE_LOG(ERR, IPSEC,
-					"Session cannot be attached to qp %u\n",
-					ipsec_ctx->tbl[cdev_id_qp].qp);
-				return -1;
-			}
-		}
 	}
 	sa->cdev_id_qp = cdev_id_qp;
 
diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
index 261a359dc..efd3270e5 100644
--- a/lib/librte_cryptodev/rte_cryptodev.h
+++ b/lib/librte_cryptodev/rte_cryptodev.h
@@ -986,6 +986,7 @@ unsigned int
 rte_cryptodev_get_private_session_size(uint8_t dev_id);
 
 /**
+ * @deprecated
  * Attach queue pair with sym session.
  *
  * @param	dev_id		Device to which the session will be attached.
@@ -997,11 +998,13 @@ rte_cryptodev_get_private_session_size(uint8_t dev_id);
  *  - On success, zero.
  *  - On failure, a negative value.
  */
+__rte_deprecated
 int
 rte_cryptodev_queue_pair_attach_sym_session(uint8_t dev_id, uint16_t qp_id,
 		struct rte_cryptodev_sym_session *session);
 
 /**
+ * @deprecated
  * Detach queue pair with sym session.
  *
  * @param	dev_id		Device to which the session is attached.
@@ -1013,6 +1016,7 @@ rte_cryptodev_queue_pair_attach_sym_session(uint8_t dev_id, uint16_t qp_id,
  *  - On success, zero.
  *  - On failure, a negative value.
  */
+__rte_deprecated
 int
 rte_cryptodev_queue_pair_detach_sym_session(uint8_t dev_id, uint16_t qp_id,
 		struct rte_cryptodev_sym_session *session);
-- 
2.17.0

[dpdk-dev] [PATCH v4 4/6] doc: announce deprecation in crypto queue pair start/stop

[Pablo de Lara]

Functions rte_cryptodev_queue_pair_start/stop
are not really used in any of the crypto drivers
(they all just return 0 or -ENOTSUP).
Therefore, this API can be deprecated from 18.05
and removed in 18.08.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 lib/librte_cryptodev/rte_cryptodev.h | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index b5d1cc0d5..66168812c 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -84,3 +84,7 @@ Deprecation Notices
     ``rte_cryptodev_queue_pair_dettach_sym_session()`` will be deprecated from
     18.05 and removed in 18.08, as there are no drivers doing anything useful
     with them.
+  - Functions ``rte_cryptodev_queue_pair_start()`` and
+    ``rte_cryptodev_queue_pair_stop()`` will be deprecated from 18.05
+    and removed in 18.08, as there are no drivers doing anything useful
+    with them.
diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
index efd3270e5..db367a1f8 100644
--- a/lib/librte_cryptodev/rte_cryptodev.h
+++ b/lib/librte_cryptodev/rte_cryptodev.h
@@ -602,6 +602,7 @@ rte_cryptodev_queue_pair_setup(uint8_t dev_id, uint16_t queue_pair_id,
 		struct rte_mempool *session_pool);
 
 /**
+ * @deprecated
  * Start a specified queue pair of a device. It is used
  * when deferred_start flag of the specified queue is true.
  *
@@ -615,10 +616,12 @@ rte_cryptodev_queue_pair_setup(uint8_t dev_id, uint16_t queue_pair_id,
  *   - -EINVAL: The dev_id or the queue_id out of range.
  *   - -ENOTSUP: The function not supported in PMD driver.
  */
+__rte_deprecated
 extern int
 rte_cryptodev_queue_pair_start(uint8_t dev_id, uint16_t queue_pair_id);
 
 /**
+ * @deprecated
  * Stop specified queue pair of a device
  *
  * @param	dev_id		The identifier of the device
@@ -631,6 +634,7 @@ rte_cryptodev_queue_pair_start(uint8_t dev_id, uint16_t queue_pair_id);
  *   - -EINVAL: The dev_id or the queue_id out of range.
  *   - -ENOTSUP: The function not supported in PMD driver.
  */
+__rte_deprecated
 extern int
 rte_cryptodev_queue_pair_stop(uint8_t dev_id, uint16_t queue_pair_id);
 
-- 
2.17.0

[dpdk-dev] [PATCH v4 5/6] doc: announce deprecation in crypto feature flags

[Pablo de Lara]

Some feature flags, such as RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER
are ambiguous. In this case, it is not clear if Scatter Gather lists
are supported in the input buffer and/or output buffer.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 doc/guides/rel_notes/deprecation.rst | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 66168812c..2819b4864 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -88,3 +88,5 @@ Deprecation Notices
     ``rte_cryptodev_queue_pair_stop()`` will be deprecated from 18.05
     and removed in 18.08, as there are no drivers doing anything useful
     with them.
+  - Some feature flags such as ``RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER`` are ambiguous,
+    so some will be replaced by more explicit flags.
-- 
2.17.0

[dpdk-dev] [PATCH v4 6/6] cryptodev: rename get session size API

[Pablo de Lara]

rte_cryptodev_get_header_session_size() and
rte_cryptodev_get_private_session_size() functions are
targetting symmetric sessions.

With the future addition of asymmetric operations,
these functions need to be renamed from *_session_*
to *_sym_session_* to be symmetric specific.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 app/test-crypto-perf/main.c                   |  2 +-
 doc/guides/prog_guide/cryptodev_lib.rst       |  6 ++---
 doc/guides/rel_notes/deprecation.rst          |  6 +++++
 drivers/crypto/aesni_gcm/aesni_gcm_pmd.c      |  2 +-
 drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c    |  2 +-
 drivers/crypto/armv8/rte_armv8_pmd.c          |  2 +-
 drivers/crypto/kasumi/rte_kasumi_pmd.c        |  2 +-
 drivers/crypto/openssl/rte_openssl_pmd.c      |  2 +-
 drivers/crypto/snow3g/rte_snow3g_pmd.c        |  2 +-
 drivers/crypto/zuc/rte_zuc_pmd.c              |  2 +-
 examples/ipsec-secgw/ipsec-secgw.c            |  2 +-
 examples/l2fwd-crypto/main.c                  |  2 +-
 examples/vhost_crypto/main.c                  |  2 +-
 lib/librte_cryptodev/rte_cryptodev.c          | 12 +++++++++
 lib/librte_cryptodev/rte_cryptodev.h          | 27 +++++++++++++++++++
 .../rte_cryptodev_version.map                 |  8 ++++++
 test/test/test_cryptodev.c                    |  6 +++--
 test/test/test_event_crypto_adapter.c         |  2 +-
 18 files changed, 72 insertions(+), 17 deletions(-)

diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c
index 26e78ff43..bb040a3d6 100644
--- a/app/test-crypto-perf/main.c
+++ b/app/test-crypto-perf/main.c
@@ -97,7 +97,7 @@ cperf_initialize_cryptodev(struct cperf_options *opts, uint8_t *enabled_cdevs,
 	uint32_t max_sess_size = 0, sess_size;
 
 	for (cdev_id = 0; cdev_id < rte_cryptodev_count(); cdev_id++) {
-		sess_size = rte_cryptodev_get_private_session_size(cdev_id);
+		sess_size = rte_cryptodev_get_private_sym_session_size(cdev_id);
 		if (sess_size > max_sess_size)
 			max_sess_size = sess_size;
 	}
diff --git a/doc/guides/prog_guide/cryptodev_lib.rst b/doc/guides/prog_guide/cryptodev_lib.rst
index b279a20e5..3bccea6d7 100644
--- a/doc/guides/prog_guide/cryptodev_lib.rst
+++ b/doc/guides/prog_guide/cryptodev_lib.rst
@@ -454,12 +454,12 @@ mempool for all crypto devices (where the mempool object size is big
 enough to hold the private session of any crypto device), as well as having
 multiple session mempools of different sizes for better memory usage.
 
-An application can use ``rte_cryptodev_get_private_session_size()`` to
+An application can use ``rte_cryptodev_get_private_sym_session_size()`` to
 get the private session size of given crypto device. This function would allow
 an application to calculate the max device session size of all crypto devices
 to create a single session mempool.
 If instead an application creates multiple session mempools, the Crypto device
-framework also provides ``rte_cryptodev_get_header_session_size`` to get
+framework also provides ``rte_cryptodev_get_header_sym_session_size`` to get
 the size of an uninitialized session.
 
 Once the session mempools have been created, ``rte_cryptodev_sym_session_create()``
@@ -662,7 +662,7 @@ using one of the crypto PMDs available in DPDK.
     uint8_t cdev_id = rte_cryptodev_get_dev_id(crypto_name);
 
     /* Get private session data size. */
-    session_size = rte_cryptodev_get_private_session_size(cdev_id);
+    session_size = rte_cryptodev_get_private_sym_session_size(cdev_id);
 
     /*
      * Create session mempool, with two objects per session,
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 2819b4864..710a3966a 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -90,3 +90,9 @@ Deprecation Notices
     with them.
   - Some feature flags such as ``RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER`` are ambiguous,
     so some will be replaced by more explicit flags.
+  - Function ``rte_cryptodev_get_header_session_size()`` will be deprecated
+    in 18.05, and it gets replaced with ``rte_cryptodev_get_header_sym_session_size()``.
+    It will be removed in 18.08.
+  - Function ``rte_cryptodev_get_private_session_size()`` will be deprecated
+    in 18.05, and it gets replaced with ``rte_cryptodev_get_private_sym_session_size()``.
+    It will be removed in 18.08.
diff --git a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
index bc5ee1b73..33fe2bdf0 100644
--- a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
+++ b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
@@ -392,7 +392,7 @@ handle_completed_gcm_crypto_op(struct aesni_gcm_qp *qp,
 	if (op->sess_type == RTE_CRYPTO_OP_SESSIONLESS) {
 		memset(sess, 0, sizeof(struct aesni_gcm_session));
 		memset(op->sym->session, 0,
-				rte_cryptodev_get_header_session_size());
+				rte_cryptodev_get_header_sym_session_size());
 		rte_mempool_put(qp->sess_mp, sess);
 		rte_mempool_put(qp->sess_mp, op->sym->session);
 		op->sym->session = NULL;
diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c
index 2e500784d..c86698b85 100644
--- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c
+++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c
@@ -682,7 +682,7 @@ post_process_mb_job(struct aesni_mb_qp *qp, JOB_AES_HMAC *job)
 	if (op->sess_type == RTE_CRYPTO_OP_SESSIONLESS) {
 		memset(sess, 0, sizeof(struct aesni_mb_session));
 		memset(op->sym->session, 0,
-				rte_cryptodev_get_header_session_size());
+				rte_cryptodev_get_header_sym_session_size());
 		rte_mempool_put(qp->sess_mp, sess);
 		rte_mempool_put(qp->sess_mp, op->sym->session);
 		op->sym->session = NULL;
diff --git a/drivers/crypto/armv8/rte_armv8_pmd.c b/drivers/crypto/armv8/rte_armv8_pmd.c
index 1fe82ccad..389f234ce 100644
--- a/drivers/crypto/armv8/rte_armv8_pmd.c
+++ b/drivers/crypto/armv8/rte_armv8_pmd.c
@@ -654,7 +654,7 @@ process_op(struct armv8_crypto_qp *qp, struct rte_crypto_op *op,
 	if (op->sess_type == RTE_CRYPTO_OP_SESSIONLESS) {
 		memset(sess, 0, sizeof(struct armv8_crypto_session));
 		memset(op->sym->session, 0,
-				rte_cryptodev_get_header_session_size());
+				rte_cryptodev_get_header_sym_session_size());
 		rte_mempool_put(qp->sess_mp, sess);
 		rte_mempool_put(qp->sess_mp, op->sym->session);
 		op->sym->session = NULL;
diff --git a/drivers/crypto/kasumi/rte_kasumi_pmd.c b/drivers/crypto/kasumi/rte_kasumi_pmd.c
index 08ee90051..e01e081dc 100644
--- a/drivers/crypto/kasumi/rte_kasumi_pmd.c
+++ b/drivers/crypto/kasumi/rte_kasumi_pmd.c
@@ -320,7 +320,7 @@ process_ops(struct rte_crypto_op **ops, struct kasumi_session *session,
 		if (ops[i]->sess_type == RTE_CRYPTO_OP_SESSIONLESS) {
 			memset(session, 0, sizeof(struct kasumi_session));
 			memset(ops[i]->sym->session, 0,
-					rte_cryptodev_get_header_session_size());
+					rte_cryptodev_get_header_sym_session_size());
 			rte_mempool_put(qp->sess_mp, session);
 			rte_mempool_put(qp->sess_mp, ops[i]->sym->session);
 			ops[i]->sym->session = NULL;
diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c
index f584d0d6f..37d2b688c 100644
--- a/drivers/crypto/openssl/rte_openssl_pmd.c
+++ b/drivers/crypto/openssl/rte_openssl_pmd.c
@@ -1569,7 +1569,7 @@ process_op(struct openssl_qp *qp, struct rte_crypto_op *op,
 		openssl_reset_session(sess);
 		memset(sess, 0, sizeof(struct openssl_session));
 		memset(op->sym->session, 0,
-				rte_cryptodev_get_header_session_size());
+				rte_cryptodev_get_header_sym_session_size());
 		rte_mempool_put(qp->sess_mp, sess);
 		rte_mempool_put(qp->sess_mp, op->sym->session);
 		op->sym->session = NULL;
diff --git a/drivers/crypto/snow3g/rte_snow3g_pmd.c b/drivers/crypto/snow3g/rte_snow3g_pmd.c
index 5edc0fa0f..d77267956 100644
--- a/drivers/crypto/snow3g/rte_snow3g_pmd.c
+++ b/drivers/crypto/snow3g/rte_snow3g_pmd.c
@@ -339,7 +339,7 @@ process_ops(struct rte_crypto_op **ops, struct snow3g_session *session,
 		if (ops[i]->sess_type == RTE_CRYPTO_OP_SESSIONLESS) {
 			memset(session, 0, sizeof(struct snow3g_session));
 			memset(ops[i]->sym->session, 0,
-					rte_cryptodev_get_header_session_size());
+					rte_cryptodev_get_header_sym_session_size());
 			rte_mempool_put(qp->sess_mp, session);
 			rte_mempool_put(qp->sess_mp, ops[i]->sym->session);
 			ops[i]->sym->session = NULL;
diff --git a/drivers/crypto/zuc/rte_zuc_pmd.c b/drivers/crypto/zuc/rte_zuc_pmd.c
index cd38f3030..4bc961161 100644
--- a/drivers/crypto/zuc/rte_zuc_pmd.c
+++ b/drivers/crypto/zuc/rte_zuc_pmd.c
@@ -327,7 +327,7 @@ process_ops(struct rte_crypto_op **ops, enum zuc_operation op_type,
 		if (ops[i]->sess_type == RTE_CRYPTO_OP_SESSIONLESS) {
 			memset(sessions[i], 0, sizeof(struct zuc_session));
 			memset(ops[i]->sym->session, 0,
-					rte_cryptodev_get_header_session_size());
+					rte_cryptodev_get_header_sym_session_size());
 			rte_mempool_put(qp->sess_mp, sessions[i]);
 			rte_mempool_put(qp->sess_mp, ops[i]->sym->session);
 			ops[i]->sym->session = NULL;
diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c
index c94118ef5..f54064cec 100644
--- a/examples/ipsec-secgw/ipsec-secgw.c
+++ b/examples/ipsec-secgw/ipsec-secgw.c
@@ -1390,7 +1390,7 @@ cryptodevs_init(void)
 
 	uint32_t max_sess_sz = 0, sess_sz;
 	for (cdev_id = 0; cdev_id < rte_cryptodev_count(); cdev_id++) {
-		sess_sz = rte_cryptodev_get_private_session_size(cdev_id);
+		sess_sz = rte_cryptodev_get_private_sym_session_size(cdev_id);
 		if (sess_sz > max_sess_sz)
 			max_sess_sz = sess_sz;
 	}
diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c
index f4e3e0b10..1bbfd4cf2 100644
--- a/examples/l2fwd-crypto/main.c
+++ b/examples/l2fwd-crypto/main.c
@@ -1982,7 +1982,7 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports,
 	}
 
 	for (cdev_id = 0; cdev_id < cdev_count; cdev_id++) {
-		sess_sz = rte_cryptodev_get_private_session_size(cdev_id);
+		sess_sz = rte_cryptodev_get_private_sym_session_size(cdev_id);
 		if (sess_sz > max_sess_sz)
 			max_sess_sz = sess_sz;
 	}
diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c
index 860200e29..9639c00a8 100644
--- a/examples/vhost_crypto/main.c
+++ b/examples/vhost_crypto/main.c
@@ -450,7 +450,7 @@ main(int argc, char *argv[])
 
 	snprintf(name, 127, "SESS_POOL_%u", worker_lcore);
 	info.sess_pool = rte_mempool_create(name, SESSION_MAP_ENTRIES,
-			rte_cryptodev_get_private_session_size(
+			rte_cryptodev_get_private_sym_session_size(
 			cryptodev_id), 64, 0, NULL, NULL, NULL, NULL,
 			rte_lcore_to_socket_id(worker_lcore), 0);
 	if (!info.sess_pool) {
diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c
index 4959f2ae6..6c20bdd74 100644
--- a/lib/librte_cryptodev/rte_cryptodev.c
+++ b/lib/librte_cryptodev/rte_cryptodev.c
@@ -1224,6 +1224,12 @@ rte_cryptodev_sym_session_free(struct rte_cryptodev_sym_session *sess)
 
 unsigned int
 rte_cryptodev_get_header_session_size(void)
+{
+	return rte_cryptodev_get_header_sym_session_size();
+}
+
+unsigned int
+rte_cryptodev_get_header_sym_session_size(void)
 {
 	/*
 	 * Header contains pointers to the private data
@@ -1235,6 +1241,12 @@ rte_cryptodev_get_header_session_size(void)
 
 unsigned int
 rte_cryptodev_get_private_session_size(uint8_t dev_id)
+{
+	return rte_cryptodev_get_private_sym_session_size(dev_id);
+}
+
+unsigned int
+rte_cryptodev_get_private_sym_session_size(uint8_t dev_id)
 {
 	struct rte_cryptodev *dev;
 	unsigned int header_size = sizeof(void *) * nb_drivers;
diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
index db367a1f8..e02b474d7 100644
--- a/lib/librte_cryptodev/rte_cryptodev.h
+++ b/lib/librte_cryptodev/rte_cryptodev.h
@@ -969,15 +969,18 @@ rte_cryptodev_sym_session_clear(uint8_t dev_id,
 			struct rte_cryptodev_sym_session *sess);
 
 /**
+ * deprecated
  * Get the size of the header session, for all registered drivers.
  *
  * @return
  *   Size of the header session.
  */
+__rte_deprecated
 unsigned int
 rte_cryptodev_get_header_session_size(void);
 
 /**
+ * @deprecated
  * Get the size of the private session data for a device.
  *
  * @param	dev_id		The device identifier.
@@ -986,9 +989,33 @@ rte_cryptodev_get_header_session_size(void);
  *   - Size of the private data, if successful
  *   - 0 if device is invalid or does not have private session
  */
+__rte_deprecated
 unsigned int
 rte_cryptodev_get_private_session_size(uint8_t dev_id);
 
+/**
+ * Get the size of the header session, for all registered drivers.
+ *
+ * @return
+ *   Size of the symmetric eader session.
+ */
+unsigned int
+rte_cryptodev_get_header_sym_session_size(void);
+
+/**
+ * Get the size of the private symmetric session data
+ * for a device.
+ *
+ * @param	dev_id		The device identifier.
+ *
+ * @return
+ *   - Size of the private data, if successful
+ *   - 0 if device is invalid or does not have private
+ *   symmetric session
+ */
+unsigned int
+rte_cryptodev_get_private_sym_session_size(uint8_t dev_id);
+
 /**
  * @deprecated
  * Attach queue pair with sym session.
diff --git a/lib/librte_cryptodev/rte_cryptodev_version.map b/lib/librte_cryptodev/rte_cryptodev_version.map
index da6905ee6..ed8426c32 100644
--- a/lib/librte_cryptodev/rte_cryptodev_version.map
+++ b/lib/librte_cryptodev/rte_cryptodev_version.map
@@ -86,6 +86,14 @@ DPDK_17.11 {
 
 } DPDK_17.08;
 
+DPDK_18.05 {
+	global:
+
+	rte_cryptodev_get_header_sym_session_size;
+	rte_cryptodev_get_private_sym_session_size;
+
+} DPDK_17.11;
+
 EXPERIMENTAL {
         global:
 
diff --git a/test/test/test_cryptodev.c b/test/test/test_cryptodev.c
index 940e3378a..42127246a 100644
--- a/test/test/test_cryptodev.c
+++ b/test/test/test_cryptodev.c
@@ -428,7 +428,8 @@ testsuite_setup(void)
 	ts_params->conf.nb_queue_pairs = info.max_nb_queue_pairs;
 	ts_params->conf.socket_id = SOCKET_ID_ANY;
 
-	unsigned int session_size = rte_cryptodev_get_private_session_size(dev_id);
+	unsigned int session_size =
+		rte_cryptodev_get_private_sym_session_size(dev_id);
 
 	/*
 	 * Create mempool with maximum number of sessions * 2,
@@ -8534,7 +8535,8 @@ test_scheduler_attach_slave_op(void)
 			rte_mempool_free(ts_params->session_mpool);
 			ts_params->session_mpool = NULL;
 		}
-		unsigned int session_size = rte_cryptodev_get_private_session_size(i);
+		unsigned int session_size =
+			rte_cryptodev_get_private_sym_session_size(i);
 
 		/*
 		 * Create mempool with maximum number of sessions * 2,
diff --git a/test/test/test_event_crypto_adapter.c b/test/test/test_event_crypto_adapter.c
index 6f0e79460..464d01790 100644
--- a/test/test/test_event_crypto_adapter.c
+++ b/test/test/test_event_crypto_adapter.c
@@ -523,7 +523,7 @@ configure_cryptodev(void)
 	 * Create mempool with maximum number of sessions * 2,
 	 * to include the session headers & private data
 	 */
-	session_size = rte_cryptodev_get_private_session_size(TEST_CDEV_ID);
+	session_size = rte_cryptodev_get_private_sym_session_size(TEST_CDEV_ID);
 	session_size += sizeof(union rte_event_crypto_metadata);
 
 	params.session_mpool = rte_mempool_create(
-- 
2.17.0

Re: [dpdk-dev] [PATCH v4 6/6] cryptodev: rename get session size API

[Akhil Goyal]

On 5/21/2018 4:36 PM, Pablo de Lara wrote:
> rte_cryptodev_get_header_session_size() and
> rte_cryptodev_get_private_session_size() functions are
> targetting symmetric sessions.
>
> With the future addition of asymmetric operations,
> these functions need to be renamed from *_session_*
> to *_sym_session_* to be symmetric specific.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

Re: [dpdk-dev] [PATCH v4 5/6] doc: announce deprecation in crypto feature flags

[Akhil Goyal]

On 5/21/2018 4:36 PM, Pablo de Lara wrote:
> Some feature flags, such as RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER
> are ambiguous. In this case, it is not clear if Scatter Gather lists
> are supported in the input buffer and/or output buffer.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---

Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

Re: [dpdk-dev] [PATCH v4 6/6] cryptodev: rename get session size API

[Verma, Shally]

>-----Original Message-----
>From: Pablo de Lara [mailto:pablo.de.lara.guarch@intel.com]
>Sent: 21 May 2018 16:37
>To: declan.doherty@intel.com; akhil.goyal@nxp.com; Verma, Shally <Shally.Verma@cavium.com>
>Cc: dev@dpdk.org; Pablo de Lara <pablo.de.lara.guarch@intel.com>
>Subject: [PATCH v4 6/6] cryptodev: rename get session size API
>
>rte_cryptodev_get_header_session_size() and
>rte_cryptodev_get_private_session_size() functions are
>targetting symmetric sessions.
>
>With the future addition of asymmetric operations,
>these functions need to be renamed from *_session_*
>to *_sym_session_* to be symmetric specific.
>
>Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>---
//snip

>diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
>index db367a1f8..e02b474d7 100644
>--- a/lib/librte_cryptodev/rte_cryptodev.h
>+++ b/lib/librte_cryptodev/rte_cryptodev.h
>@@ -969,15 +969,18 @@ rte_cryptodev_sym_session_clear(uint8_t dev_id,
> 			struct rte_cryptodev_sym_session *sess);
>
> /**
>+ * deprecated
>  * Get the size of the header session, for all registered drivers.
>  *
>  * @return
>  *   Size of the header session.
>  */
>+__rte_deprecated
> unsigned int
> rte_cryptodev_get_header_session_size(void);
>
> /**
>+ * @deprecated
>  * Get the size of the private session data for a device.
>  *
>  * @param	dev_id		The device identifier.
>@@ -986,9 +989,33 @@ rte_cryptodev_get_header_session_size(void);
>  *   - Size of the private data, if successful
>  *   - 0 if device is invalid or does not have private session
>  */
>+__rte_deprecated
> unsigned int
> rte_cryptodev_get_private_session_size(uint8_t dev_id);
>
>+/**
>+ * Get the size of the header session, for all registered drivers.
>+ *
>+ * @return
>+ *   Size of the symmetric eader session.
>+ */
>+unsigned int
>+rte_cryptodev_get_header_sym_session_size(void);
>+
[Shally] To keep consistency in naming convention, we can rename API to rte_cryptodev_sym_get_header_session_size  and rte_cryptodev_sym_get_private_session_size  

Thanks
Shally

Re: [dpdk-dev] [PATCH v4 6/6] cryptodev: rename get session size API

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Verma, Shally [mailto:Shally.Verma@cavium.com]
> Sent: Monday, May 21, 2018 1:05 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>; akhil.goyal@nxp.com
> Cc: dev@dpdk.org
> Subject: RE: [PATCH v4 6/6] cryptodev: rename get session size API
> 
> 
> 
> >-----Original Message-----
> >From: Pablo de Lara [mailto:pablo.de.lara.guarch@intel.com]
> >Sent: 21 May 2018 16:37
> >To: declan.doherty@intel.com; akhil.goyal@nxp.com; Verma, Shally
> ><Shally.Verma@cavium.com>
> >Cc: dev@dpdk.org; Pablo de Lara <pablo.de.lara.guarch@intel.com>
> >Subject: [PATCH v4 6/6] cryptodev: rename get session size API
> >
> >rte_cryptodev_get_header_session_size() and
> >rte_cryptodev_get_private_session_size() functions are targetting
> >symmetric sessions.
> >
> >With the future addition of asymmetric operations, these functions need
> >to be renamed from *_session_* to *_sym_session_* to be symmetric
> >specific.
> >
> >Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> >---
> //snip
> 
> >diff --git a/lib/librte_cryptodev/rte_cryptodev.h
> >b/lib/librte_cryptodev/rte_cryptodev.h
> >index db367a1f8..e02b474d7 100644
> >--- a/lib/librte_cryptodev/rte_cryptodev.h
> >+++ b/lib/librte_cryptodev/rte_cryptodev.h
> >@@ -969,15 +969,18 @@ rte_cryptodev_sym_session_clear(uint8_t dev_id,
> > 			struct rte_cryptodev_sym_session *sess);
> >
> > /**
> >+ * deprecated
> >  * Get the size of the header session, for all registered drivers.
> >  *
> >  * @return
> >  *   Size of the header session.
> >  */
> >+__rte_deprecated
> > unsigned int
> > rte_cryptodev_get_header_session_size(void);
> >
> > /**
> >+ * @deprecated
> >  * Get the size of the private session data for a device.
> >  *
> >  * @param	dev_id		The device identifier.
> >@@ -986,9 +989,33 @@ rte_cryptodev_get_header_session_size(void);
> >  *   - Size of the private data, if successful
> >  *   - 0 if device is invalid or does not have private session
> >  */
> >+__rte_deprecated
> > unsigned int
> > rte_cryptodev_get_private_session_size(uint8_t dev_id);
> >
> >+/**
> >+ * Get the size of the header session, for all registered drivers.
> >+ *
> >+ * @return
> >+ *   Size of the symmetric eader session.
> >+ */
> >+unsigned int
> >+rte_cryptodev_get_header_sym_session_size(void);
> >+
> [Shally] To keep consistency in naming convention, we can rename API to
> rte_cryptodev_sym_get_header_session_size  and
> rte_cryptodev_sym_get_private_session_size

Agree. Will send a v7 with the change.

Thanks!
Pablo

> 
> Thanks
> Shally

[dpdk-dev] [PATCH v5 0/6] Cryptodev API/ABI deprecation notices

[Pablo de Lara]

v5:
- Renamed rte_cryptodev_get_header_session_size with
  rte_cryptodev_sym_get_header_session_size, and
  rte_cryptodev_get_private_session_size with
  rte_cryptodev_sym_get_private_session_size.

v4:
- Fixed DPDK versions called out to deprecate/remove API.
- Removed rte_cryptodev_queue_pair_attach_sym_session call
  from the IPSec gw app, since the function is deprecated now.
- Added patch announcing a replacement of some of the crypto
  feature flags
- Added patch renaming two symmetric specific functions
  from *_session_* to *_sym_session_*.

v3:
- Added an extra deprecation announcement (replacing rte_pci_device
  with rte_device)
- Rebased against latest DPDK code

v2:
- Added an extra deprecation announcement
- Bonded the other two deprecation notices with the new one in a
  patchset

Pablo de Lara (6):
  doc: announce ABI change for crypto sym info struct
  doc: announce ABI change for crypto info struct
  doc: announce deprecation for attach/detach crypto session
  doc: announce deprecation in crypto queue pair start/stop
  doc: announce deprecation in crypto feature flags
  cryptodev: rename get session size API

 app/test-crypto-perf/main.c                   |  2 +-
 doc/guides/prog_guide/cryptodev_lib.rst       |  6 ++--
 doc/guides/rel_notes/deprecation.rst          | 25 +++++++++++++
 drivers/crypto/aesni_gcm/aesni_gcm_pmd.c      |  2 +-
 drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c    |  2 +-
 drivers/crypto/armv8/rte_armv8_pmd.c          |  2 +-
 drivers/crypto/kasumi/rte_kasumi_pmd.c        |  2 +-
 drivers/crypto/openssl/rte_openssl_pmd.c      |  2 +-
 drivers/crypto/snow3g/rte_snow3g_pmd.c        |  2 +-
 drivers/crypto/zuc/rte_zuc_pmd.c              |  2 +-
 examples/ipsec-secgw/ipsec-secgw.c            |  2 +-
 examples/ipsec-secgw/ipsec.c                  | 12 -------
 examples/l2fwd-crypto/main.c                  |  2 +-
 examples/vhost_crypto/main.c                  |  2 +-
 lib/librte_cryptodev/rte_cryptodev.c          | 12 +++++++
 lib/librte_cryptodev/rte_cryptodev.h          | 35 +++++++++++++++++++
 .../rte_cryptodev_version.map                 |  8 +++++
 test/test/test_cryptodev.c                    |  6 ++--
 test/test/test_event_crypto_adapter.c         |  2 +-
 19 files changed, 99 insertions(+), 29 deletions(-)

-- 
2.17.0

[dpdk-dev] [PATCH v5 1/6] doc: announce ABI change for crypto sym info struct

[Pablo de Lara]

Since the API changes made in 17.08, the session mempool
is not created anymore in each crypto device.
Therefore, there is no need to have, in the cryptodev info
structure, the maximum number of sessions supported per device
and per queue pair.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
---
 doc/guides/rel_notes/deprecation.rst | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index c3b79a22f..d6cccbfde 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -71,3 +71,10 @@ Deprecation Notices
   - ``rte_pdump_set_socket_dir`` will be removed;
   - The parameter, ``path``, of ``rte_pdump_init`` will be removed;
   - The enum ``rte_pdump_socktype`` will be removed.
+
+* cryptodev: The following changes will be made in the library
+  for 18.08:
+
+  - Removal of ``sym`` structure in ``rte_cryptodev_info`` structure,
+    containing fields not relevant anymore since the session mempool
+    is not internal in the crypto device anymore.
-- 
2.17.0

[dpdk-dev] [PATCH v5 2/6] doc: announce ABI change for crypto info struct

[Pablo de Lara]

Cryptodev info structure currently contains
a pointer to an rte_pci_device structure.
This field depends on a specific bus type (PCI),
which is not following a bus independent design.
Following the same approach taken in ethdev, the field
will be replaced with a pointer to an rte_device structure.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
---
 doc/guides/rel_notes/deprecation.rst | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index d6cccbfde..85945ee72 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -78,3 +78,5 @@ Deprecation Notices
   - Removal of ``sym`` structure in ``rte_cryptodev_info`` structure,
     containing fields not relevant anymore since the session mempool
     is not internal in the crypto device anymore.
+  - Replacement of ``pci_dev`` field with the more generic ``rte_device``
+    structure.
-- 
2.17.0

[dpdk-dev] [PATCH v5 3/6] doc: announce deprecation for attach/detach crypto session

[Pablo de Lara]

Functions rte_cryptodev_queue_pair_attach_sym_session
and rte_cryptodev_queue_pair_detach_sym_sessions
are not really used in any of the crypto drivers
(only one driver implements it and it just return 0).
Therefore, this API can be deprecated from 18.05
and removed in 18.08.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
---
 doc/guides/rel_notes/deprecation.rst |  4 ++++
 examples/ipsec-secgw/ipsec.c         | 12 ------------
 lib/librte_cryptodev/rte_cryptodev.h |  4 ++++
 3 files changed, 8 insertions(+), 12 deletions(-)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 85945ee72..b5d1cc0d5 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -80,3 +80,7 @@ Deprecation Notices
     is not internal in the crypto device anymore.
   - Replacement of ``pci_dev`` field with the more generic ``rte_device``
     structure.
+  - Functions ``rte_cryptodev_queue_pair_attach_sym_session()`` and
+    ``rte_cryptodev_queue_pair_dettach_sym_session()`` will be deprecated from
+    18.05 and removed in 18.08, as there are no drivers doing anything useful
+    with them.
diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c
index 6c896477c..3d415f1af 100644
--- a/examples/ipsec-secgw/ipsec.c
+++ b/examples/ipsec-secgw/ipsec.c
@@ -327,18 +327,6 @@ create_session(struct ipsec_ctx *ipsec_ctx, struct ipsec_sa *sa)
 
 		rte_cryptodev_info_get(ipsec_ctx->tbl[cdev_id_qp].id,
 				&cdev_info);
-		if (cdev_info.sym.max_nb_sessions_per_qp > 0) {
-			ret = rte_cryptodev_queue_pair_attach_sym_session(
-					ipsec_ctx->tbl[cdev_id_qp].id,
-					ipsec_ctx->tbl[cdev_id_qp].qp,
-					sa->crypto_session);
-			if (ret < 0) {
-				RTE_LOG(ERR, IPSEC,
-					"Session cannot be attached to qp %u\n",
-					ipsec_ctx->tbl[cdev_id_qp].qp);
-				return -1;
-			}
-		}
 	}
 	sa->cdev_id_qp = cdev_id_qp;
 
diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
index 261a359dc..efd3270e5 100644
--- a/lib/librte_cryptodev/rte_cryptodev.h
+++ b/lib/librte_cryptodev/rte_cryptodev.h
@@ -986,6 +986,7 @@ unsigned int
 rte_cryptodev_get_private_session_size(uint8_t dev_id);
 
 /**
+ * @deprecated
  * Attach queue pair with sym session.
  *
  * @param	dev_id		Device to which the session will be attached.
@@ -997,11 +998,13 @@ rte_cryptodev_get_private_session_size(uint8_t dev_id);
  *  - On success, zero.
  *  - On failure, a negative value.
  */
+__rte_deprecated
 int
 rte_cryptodev_queue_pair_attach_sym_session(uint8_t dev_id, uint16_t qp_id,
 		struct rte_cryptodev_sym_session *session);
 
 /**
+ * @deprecated
  * Detach queue pair with sym session.
  *
  * @param	dev_id		Device to which the session is attached.
@@ -1013,6 +1016,7 @@ rte_cryptodev_queue_pair_attach_sym_session(uint8_t dev_id, uint16_t qp_id,
  *  - On success, zero.
  *  - On failure, a negative value.
  */
+__rte_deprecated
 int
 rte_cryptodev_queue_pair_detach_sym_session(uint8_t dev_id, uint16_t qp_id,
 		struct rte_cryptodev_sym_session *session);
-- 
2.17.0

[dpdk-dev] [PATCH v5 4/6] doc: announce deprecation in crypto queue pair start/stop

[Pablo de Lara]

Functions rte_cryptodev_queue_pair_start/stop
are not really used in any of the crypto drivers
(they all just return 0 or -ENOTSUP).
Therefore, this API can be deprecated from 18.05
and removed in 18.08.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 lib/librte_cryptodev/rte_cryptodev.h | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index b5d1cc0d5..66168812c 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -84,3 +84,7 @@ Deprecation Notices
     ``rte_cryptodev_queue_pair_dettach_sym_session()`` will be deprecated from
     18.05 and removed in 18.08, as there are no drivers doing anything useful
     with them.
+  - Functions ``rte_cryptodev_queue_pair_start()`` and
+    ``rte_cryptodev_queue_pair_stop()`` will be deprecated from 18.05
+    and removed in 18.08, as there are no drivers doing anything useful
+    with them.
diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
index efd3270e5..db367a1f8 100644
--- a/lib/librte_cryptodev/rte_cryptodev.h
+++ b/lib/librte_cryptodev/rte_cryptodev.h
@@ -602,6 +602,7 @@ rte_cryptodev_queue_pair_setup(uint8_t dev_id, uint16_t queue_pair_id,
 		struct rte_mempool *session_pool);
 
 /**
+ * @deprecated
  * Start a specified queue pair of a device. It is used
  * when deferred_start flag of the specified queue is true.
  *
@@ -615,10 +616,12 @@ rte_cryptodev_queue_pair_setup(uint8_t dev_id, uint16_t queue_pair_id,
  *   - -EINVAL: The dev_id or the queue_id out of range.
  *   - -ENOTSUP: The function not supported in PMD driver.
  */
+__rte_deprecated
 extern int
 rte_cryptodev_queue_pair_start(uint8_t dev_id, uint16_t queue_pair_id);
 
 /**
+ * @deprecated
  * Stop specified queue pair of a device
  *
  * @param	dev_id		The identifier of the device
@@ -631,6 +634,7 @@ rte_cryptodev_queue_pair_start(uint8_t dev_id, uint16_t queue_pair_id);
  *   - -EINVAL: The dev_id or the queue_id out of range.
  *   - -ENOTSUP: The function not supported in PMD driver.
  */
+__rte_deprecated
 extern int
 rte_cryptodev_queue_pair_stop(uint8_t dev_id, uint16_t queue_pair_id);
 
-- 
2.17.0

[dpdk-dev] [PATCH v5 5/6] doc: announce deprecation in crypto feature flags

[Pablo de Lara]

Some feature flags, such as RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER
are ambiguous. In this case, it is not clear if Scatter Gather lists
are supported in the input buffer and/or output buffer.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 doc/guides/rel_notes/deprecation.rst | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 66168812c..2819b4864 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -88,3 +88,5 @@ Deprecation Notices
     ``rte_cryptodev_queue_pair_stop()`` will be deprecated from 18.05
     and removed in 18.08, as there are no drivers doing anything useful
     with them.
+  - Some feature flags such as ``RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER`` are ambiguous,
+    so some will be replaced by more explicit flags.
-- 
2.17.0

[dpdk-dev] [PATCH v5 6/6] cryptodev: rename get session size API

[Pablo de Lara]

rte_cryptodev_get_header_session_size() and
rte_cryptodev_get_private_session_size() functions are
targeting symmetric sessions.

With the future addition of asymmetric operations,
these functions need to be renamed from *cryptodev_*_session_*
to *cryptodev_sym_*_session_* to be symmetric specific.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 app/test-crypto-perf/main.c                   |  2 +-
 doc/guides/prog_guide/cryptodev_lib.rst       |  6 ++---
 doc/guides/rel_notes/deprecation.rst          |  6 +++++
 drivers/crypto/aesni_gcm/aesni_gcm_pmd.c      |  2 +-
 drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c    |  2 +-
 drivers/crypto/armv8/rte_armv8_pmd.c          |  2 +-
 drivers/crypto/kasumi/rte_kasumi_pmd.c        |  2 +-
 drivers/crypto/openssl/rte_openssl_pmd.c      |  2 +-
 drivers/crypto/snow3g/rte_snow3g_pmd.c        |  2 +-
 drivers/crypto/zuc/rte_zuc_pmd.c              |  2 +-
 examples/ipsec-secgw/ipsec-secgw.c            |  2 +-
 examples/l2fwd-crypto/main.c                  |  2 +-
 examples/vhost_crypto/main.c                  |  2 +-
 lib/librte_cryptodev/rte_cryptodev.c          | 12 +++++++++
 lib/librte_cryptodev/rte_cryptodev.h          | 27 +++++++++++++++++++
 .../rte_cryptodev_version.map                 |  8 ++++++
 test/test/test_cryptodev.c                    |  6 +++--
 test/test/test_event_crypto_adapter.c         |  2 +-
 18 files changed, 72 insertions(+), 17 deletions(-)

diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c
index 26e78ff43..4ae14390b 100644
--- a/app/test-crypto-perf/main.c
+++ b/app/test-crypto-perf/main.c
@@ -97,7 +97,7 @@ cperf_initialize_cryptodev(struct cperf_options *opts, uint8_t *enabled_cdevs,
 	uint32_t max_sess_size = 0, sess_size;
 
 	for (cdev_id = 0; cdev_id < rte_cryptodev_count(); cdev_id++) {
-		sess_size = rte_cryptodev_get_private_session_size(cdev_id);
+		sess_size = rte_cryptodev_sym_get_private_session_size(cdev_id);
 		if (sess_size > max_sess_size)
 			max_sess_size = sess_size;
 	}
diff --git a/doc/guides/prog_guide/cryptodev_lib.rst b/doc/guides/prog_guide/cryptodev_lib.rst
index b279a20e5..30f0bcf7a 100644
--- a/doc/guides/prog_guide/cryptodev_lib.rst
+++ b/doc/guides/prog_guide/cryptodev_lib.rst
@@ -454,12 +454,12 @@ mempool for all crypto devices (where the mempool object size is big
 enough to hold the private session of any crypto device), as well as having
 multiple session mempools of different sizes for better memory usage.
 
-An application can use ``rte_cryptodev_get_private_session_size()`` to
+An application can use ``rte_cryptodev_sym_get_private_session_size()`` to
 get the private session size of given crypto device. This function would allow
 an application to calculate the max device session size of all crypto devices
 to create a single session mempool.
 If instead an application creates multiple session mempools, the Crypto device
-framework also provides ``rte_cryptodev_get_header_session_size`` to get
+framework also provides ``rte_cryptodev_sym_get_header_session_size`` to get
 the size of an uninitialized session.
 
 Once the session mempools have been created, ``rte_cryptodev_sym_session_create()``
@@ -662,7 +662,7 @@ using one of the crypto PMDs available in DPDK.
     uint8_t cdev_id = rte_cryptodev_get_dev_id(crypto_name);
 
     /* Get private session data size. */
-    session_size = rte_cryptodev_get_private_session_size(cdev_id);
+    session_size = rte_cryptodev_sym_get_private_session_size(cdev_id);
 
     /*
      * Create session mempool, with two objects per session,
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 2819b4864..1e2443c76 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -90,3 +90,9 @@ Deprecation Notices
     with them.
   - Some feature flags such as ``RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER`` are ambiguous,
     so some will be replaced by more explicit flags.
+  - Function ``rte_cryptodev_get_header_session_size()`` will be deprecated
+    in 18.05, and it gets replaced with ``rte_cryptodev_sym_get_header_session_size()``.
+    It will be removed in 18.08.
+  - Function ``rte_cryptodev_get_private_session_size()`` will be deprecated
+    in 18.05, and it gets replaced with ``rte_cryptodev_sym_get_private_session_size()``.
+    It will be removed in 18.08.
diff --git a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
index bc5ee1b73..80360dd9c 100644
--- a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
+++ b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
@@ -392,7 +392,7 @@ handle_completed_gcm_crypto_op(struct aesni_gcm_qp *qp,
 	if (op->sess_type == RTE_CRYPTO_OP_SESSIONLESS) {
 		memset(sess, 0, sizeof(struct aesni_gcm_session));
 		memset(op->sym->session, 0,
-				rte_cryptodev_get_header_session_size());
+				rte_cryptodev_sym_get_header_session_size());
 		rte_mempool_put(qp->sess_mp, sess);
 		rte_mempool_put(qp->sess_mp, op->sym->session);
 		op->sym->session = NULL;
diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c
index 2e500784d..bb35c66ab 100644
--- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c
+++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c
@@ -682,7 +682,7 @@ post_process_mb_job(struct aesni_mb_qp *qp, JOB_AES_HMAC *job)
 	if (op->sess_type == RTE_CRYPTO_OP_SESSIONLESS) {
 		memset(sess, 0, sizeof(struct aesni_mb_session));
 		memset(op->sym->session, 0,
-				rte_cryptodev_get_header_session_size());
+				rte_cryptodev_sym_get_header_session_size());
 		rte_mempool_put(qp->sess_mp, sess);
 		rte_mempool_put(qp->sess_mp, op->sym->session);
 		op->sym->session = NULL;
diff --git a/drivers/crypto/armv8/rte_armv8_pmd.c b/drivers/crypto/armv8/rte_armv8_pmd.c
index 1fe82ccad..fbb08f729 100644
--- a/drivers/crypto/armv8/rte_armv8_pmd.c
+++ b/drivers/crypto/armv8/rte_armv8_pmd.c
@@ -654,7 +654,7 @@ process_op(struct armv8_crypto_qp *qp, struct rte_crypto_op *op,
 	if (op->sess_type == RTE_CRYPTO_OP_SESSIONLESS) {
 		memset(sess, 0, sizeof(struct armv8_crypto_session));
 		memset(op->sym->session, 0,
-				rte_cryptodev_get_header_session_size());
+				rte_cryptodev_sym_get_header_session_size());
 		rte_mempool_put(qp->sess_mp, sess);
 		rte_mempool_put(qp->sess_mp, op->sym->session);
 		op->sym->session = NULL;
diff --git a/drivers/crypto/kasumi/rte_kasumi_pmd.c b/drivers/crypto/kasumi/rte_kasumi_pmd.c
index 08ee90051..205dc1de7 100644
--- a/drivers/crypto/kasumi/rte_kasumi_pmd.c
+++ b/drivers/crypto/kasumi/rte_kasumi_pmd.c
@@ -320,7 +320,7 @@ process_ops(struct rte_crypto_op **ops, struct kasumi_session *session,
 		if (ops[i]->sess_type == RTE_CRYPTO_OP_SESSIONLESS) {
 			memset(session, 0, sizeof(struct kasumi_session));
 			memset(ops[i]->sym->session, 0,
-					rte_cryptodev_get_header_session_size());
+					rte_cryptodev_sym_get_header_session_size());
 			rte_mempool_put(qp->sess_mp, session);
 			rte_mempool_put(qp->sess_mp, ops[i]->sym->session);
 			ops[i]->sym->session = NULL;
diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c
index f584d0d6f..93c6d7e5d 100644
--- a/drivers/crypto/openssl/rte_openssl_pmd.c
+++ b/drivers/crypto/openssl/rte_openssl_pmd.c
@@ -1569,7 +1569,7 @@ process_op(struct openssl_qp *qp, struct rte_crypto_op *op,
 		openssl_reset_session(sess);
 		memset(sess, 0, sizeof(struct openssl_session));
 		memset(op->sym->session, 0,
-				rte_cryptodev_get_header_session_size());
+				rte_cryptodev_sym_get_header_session_size());
 		rte_mempool_put(qp->sess_mp, sess);
 		rte_mempool_put(qp->sess_mp, op->sym->session);
 		op->sym->session = NULL;
diff --git a/drivers/crypto/snow3g/rte_snow3g_pmd.c b/drivers/crypto/snow3g/rte_snow3g_pmd.c
index 5edc0fa0f..72751e35e 100644
--- a/drivers/crypto/snow3g/rte_snow3g_pmd.c
+++ b/drivers/crypto/snow3g/rte_snow3g_pmd.c
@@ -339,7 +339,7 @@ process_ops(struct rte_crypto_op **ops, struct snow3g_session *session,
 		if (ops[i]->sess_type == RTE_CRYPTO_OP_SESSIONLESS) {
 			memset(session, 0, sizeof(struct snow3g_session));
 			memset(ops[i]->sym->session, 0,
-					rte_cryptodev_get_header_session_size());
+					rte_cryptodev_sym_get_header_session_size());
 			rte_mempool_put(qp->sess_mp, session);
 			rte_mempool_put(qp->sess_mp, ops[i]->sym->session);
 			ops[i]->sym->session = NULL;
diff --git a/drivers/crypto/zuc/rte_zuc_pmd.c b/drivers/crypto/zuc/rte_zuc_pmd.c
index cd38f3030..a805b2278 100644
--- a/drivers/crypto/zuc/rte_zuc_pmd.c
+++ b/drivers/crypto/zuc/rte_zuc_pmd.c
@@ -327,7 +327,7 @@ process_ops(struct rte_crypto_op **ops, enum zuc_operation op_type,
 		if (ops[i]->sess_type == RTE_CRYPTO_OP_SESSIONLESS) {
 			memset(sessions[i], 0, sizeof(struct zuc_session));
 			memset(ops[i]->sym->session, 0,
-					rte_cryptodev_get_header_session_size());
+					rte_cryptodev_sym_get_header_session_size());
 			rte_mempool_put(qp->sess_mp, sessions[i]);
 			rte_mempool_put(qp->sess_mp, ops[i]->sym->session);
 			ops[i]->sym->session = NULL;
diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c
index c94118ef5..a5da8b280 100644
--- a/examples/ipsec-secgw/ipsec-secgw.c
+++ b/examples/ipsec-secgw/ipsec-secgw.c
@@ -1390,7 +1390,7 @@ cryptodevs_init(void)
 
 	uint32_t max_sess_sz = 0, sess_sz;
 	for (cdev_id = 0; cdev_id < rte_cryptodev_count(); cdev_id++) {
-		sess_sz = rte_cryptodev_get_private_session_size(cdev_id);
+		sess_sz = rte_cryptodev_sym_get_private_session_size(cdev_id);
 		if (sess_sz > max_sess_sz)
 			max_sess_sz = sess_sz;
 	}
diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c
index f4e3e0b10..4bca87b19 100644
--- a/examples/l2fwd-crypto/main.c
+++ b/examples/l2fwd-crypto/main.c
@@ -1982,7 +1982,7 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports,
 	}
 
 	for (cdev_id = 0; cdev_id < cdev_count; cdev_id++) {
-		sess_sz = rte_cryptodev_get_private_session_size(cdev_id);
+		sess_sz = rte_cryptodev_sym_get_private_session_size(cdev_id);
 		if (sess_sz > max_sess_sz)
 			max_sess_sz = sess_sz;
 	}
diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c
index 860200e29..f334d7123 100644
--- a/examples/vhost_crypto/main.c
+++ b/examples/vhost_crypto/main.c
@@ -450,7 +450,7 @@ main(int argc, char *argv[])
 
 	snprintf(name, 127, "SESS_POOL_%u", worker_lcore);
 	info.sess_pool = rte_mempool_create(name, SESSION_MAP_ENTRIES,
-			rte_cryptodev_get_private_session_size(
+			rte_cryptodev_sym_get_private_session_size(
 			cryptodev_id), 64, 0, NULL, NULL, NULL, NULL,
 			rte_lcore_to_socket_id(worker_lcore), 0);
 	if (!info.sess_pool) {
diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c
index 4959f2ae6..e678fe8d9 100644
--- a/lib/librte_cryptodev/rte_cryptodev.c
+++ b/lib/librte_cryptodev/rte_cryptodev.c
@@ -1224,6 +1224,12 @@ rte_cryptodev_sym_session_free(struct rte_cryptodev_sym_session *sess)
 
 unsigned int
 rte_cryptodev_get_header_session_size(void)
+{
+	return rte_cryptodev_sym_get_header_session_size();
+}
+
+unsigned int
+rte_cryptodev_sym_get_header_session_size(void)
 {
 	/*
 	 * Header contains pointers to the private data
@@ -1235,6 +1241,12 @@ rte_cryptodev_get_header_session_size(void)
 
 unsigned int
 rte_cryptodev_get_private_session_size(uint8_t dev_id)
+{
+	return rte_cryptodev_sym_get_private_session_size(dev_id);
+}
+
+unsigned int
+rte_cryptodev_sym_get_private_session_size(uint8_t dev_id)
 {
 	struct rte_cryptodev *dev;
 	unsigned int header_size = sizeof(void *) * nb_drivers;
diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
index db367a1f8..542f93d99 100644
--- a/lib/librte_cryptodev/rte_cryptodev.h
+++ b/lib/librte_cryptodev/rte_cryptodev.h
@@ -969,15 +969,18 @@ rte_cryptodev_sym_session_clear(uint8_t dev_id,
 			struct rte_cryptodev_sym_session *sess);
 
 /**
+ * deprecated
  * Get the size of the header session, for all registered drivers.
  *
  * @return
  *   Size of the header session.
  */
+__rte_deprecated
 unsigned int
 rte_cryptodev_get_header_session_size(void);
 
 /**
+ * @deprecated
  * Get the size of the private session data for a device.
  *
  * @param	dev_id		The device identifier.
@@ -986,9 +989,33 @@ rte_cryptodev_get_header_session_size(void);
  *   - Size of the private data, if successful
  *   - 0 if device is invalid or does not have private session
  */
+__rte_deprecated
 unsigned int
 rte_cryptodev_get_private_session_size(uint8_t dev_id);
 
+/**
+ * Get the size of the header session, for all registered drivers.
+ *
+ * @return
+ *   Size of the symmetric eader session.
+ */
+unsigned int
+rte_cryptodev_sym_get_header_session_size(void);
+
+/**
+ * Get the size of the private symmetric session data
+ * for a device.
+ *
+ * @param	dev_id		The device identifier.
+ *
+ * @return
+ *   - Size of the private data, if successful
+ *   - 0 if device is invalid or does not have private
+ *   symmetric session
+ */
+unsigned int
+rte_cryptodev_sym_get_private_session_size(uint8_t dev_id);
+
 /**
  * @deprecated
  * Attach queue pair with sym session.
diff --git a/lib/librte_cryptodev/rte_cryptodev_version.map b/lib/librte_cryptodev/rte_cryptodev_version.map
index da6905ee6..be8f4c1a7 100644
--- a/lib/librte_cryptodev/rte_cryptodev_version.map
+++ b/lib/librte_cryptodev/rte_cryptodev_version.map
@@ -86,6 +86,14 @@ DPDK_17.11 {
 
 } DPDK_17.08;
 
+DPDK_18.05 {
+	global:
+
+	rte_cryptodev_sym_get_header_session_size;
+	rte_cryptodev_sym_get_private_session_size;
+
+} DPDK_17.11;
+
 EXPERIMENTAL {
         global:
 
diff --git a/test/test/test_cryptodev.c b/test/test/test_cryptodev.c
index 940e3378a..389f79677 100644
--- a/test/test/test_cryptodev.c
+++ b/test/test/test_cryptodev.c
@@ -428,7 +428,8 @@ testsuite_setup(void)
 	ts_params->conf.nb_queue_pairs = info.max_nb_queue_pairs;
 	ts_params->conf.socket_id = SOCKET_ID_ANY;
 
-	unsigned int session_size = rte_cryptodev_get_private_session_size(dev_id);
+	unsigned int session_size =
+		rte_cryptodev_sym_get_private_session_size(dev_id);
 
 	/*
 	 * Create mempool with maximum number of sessions * 2,
@@ -8534,7 +8535,8 @@ test_scheduler_attach_slave_op(void)
 			rte_mempool_free(ts_params->session_mpool);
 			ts_params->session_mpool = NULL;
 		}
-		unsigned int session_size = rte_cryptodev_get_private_session_size(i);
+		unsigned int session_size =
+			rte_cryptodev_sym_get_private_session_size(i);
 
 		/*
 		 * Create mempool with maximum number of sessions * 2,
diff --git a/test/test/test_event_crypto_adapter.c b/test/test/test_event_crypto_adapter.c
index 6f0e79460..066b0adef 100644
--- a/test/test/test_event_crypto_adapter.c
+++ b/test/test/test_event_crypto_adapter.c
@@ -523,7 +523,7 @@ configure_cryptodev(void)
 	 * Create mempool with maximum number of sessions * 2,
 	 * to include the session headers & private data
 	 */
-	session_size = rte_cryptodev_get_private_session_size(TEST_CDEV_ID);
+	session_size = rte_cryptodev_sym_get_private_session_size(TEST_CDEV_ID);
 	session_size += sizeof(union rte_event_crypto_metadata);
 
 	params.session_mpool = rte_mempool_create(
-- 
2.17.0

Re: [dpdk-dev] [PATCH v5 5/6] doc: announce deprecation in crypto feature flags

[Trahe, Fiona]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Monday, May 21, 2018 2:09 PM
> To: Doherty, Declan <declan.doherty@intel.com>; akhil.goyal@nxp.com; shally.verma@cavium.com
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [dpdk-dev] [PATCH v5 5/6] doc: announce deprecation in crypto feature flags
> 
> Some feature flags, such as RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER
> are ambiguous. In this case, it is not clear if Scatter Gather lists
> are supported in the input buffer and/or output buffer.
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Re: [dpdk-dev] [PATCH v5 6/6] cryptodev: rename get session size API

[Verma, Shally]

>-----Original Message-----
>From: Pablo de Lara [mailto:pablo.de.lara.guarch@intel.com]
>Sent: 21 May 2018 18:39
>To: declan.doherty@intel.com; akhil.goyal@nxp.com; Verma, Shally <Shally.Verma@cavium.com>
>Cc: dev@dpdk.org; Pablo de Lara <pablo.de.lara.guarch@intel.com>
>Subject: [PATCH v5 6/6] cryptodev: rename get session size API
>
>rte_cryptodev_get_header_session_size() and
>rte_cryptodev_get_private_session_size() functions are
>targeting symmetric sessions.
>
>With the future addition of asymmetric operations,
>these functions need to be renamed from *cryptodev_*_session_*
>to *cryptodev_sym_*_session_* to be symmetric specific.
>
>Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>---
Acked-by: Shally Verma <shally.verma@caviumnetworks.com>

Re: [dpdk-dev] [PATCH v5 6/6] cryptodev: rename get session size API

[Trahe, Fiona]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Monday, May 21, 2018 2:09 PM
> To: Doherty, Declan <declan.doherty@intel.com>; akhil.goyal@nxp.com; shally.verma@cavium.com
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [dpdk-dev] [PATCH v5 6/6] cryptodev: rename get session size API
> 
> rte_cryptodev_get_header_session_size() and
> rte_cryptodev_get_private_session_size() functions are
> targeting symmetric sessions.
> 
> With the future addition of asymmetric operations,
> these functions need to be renamed from *cryptodev_*_session_*
> to *cryptodev_sym_*_session_* to be symmetric specific.
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Maybe mention is commit msg that the old fn is still kept but marked deprecated
and will be removed in next release.
Apart from that 
Acked-by: Fiona Trahe <fiona.trahe@intel.com> 

Re: [dpdk-dev] [PATCH v5 0/6] Cryptodev API/ABI deprecation notices

[Jain, Deepak K]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Monday, May 21, 2018 2:09 PM
> To: Doherty, Declan <declan.doherty@intel.com>; akhil.goyal@nxp.com;
> shally.verma@cavium.com
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [dpdk-dev] [PATCH v5 0/6] Cryptodev API/ABI deprecation notices
> 
> v5:
> - Renamed rte_cryptodev_get_header_session_size with
>   rte_cryptodev_sym_get_header_session_size, and
>   rte_cryptodev_get_private_session_size with
>   rte_cryptodev_sym_get_private_session_size.
> 
> v4:
> - Fixed DPDK versions called out to deprecate/remove API.
> - Removed rte_cryptodev_queue_pair_attach_sym_session call
>   from the IPSec gw app, since the function is deprecated now.
> - Added patch announcing a replacement of some of the crypto
>   feature flags
> - Added patch renaming two symmetric specific functions
>   from *_session_* to *_sym_session_*.
> 
> v3:
> - Added an extra deprecation announcement (replacing rte_pci_device
>   with rte_device)
> - Rebased against latest DPDK code
> 
> v2:
> - Added an extra deprecation announcement
> - Bonded the other two deprecation notices with the new one in a
>   patchset
> 
> Pablo de Lara (6):
>   doc: announce ABI change for crypto sym info struct
>   doc: announce ABI change for crypto info struct
>   doc: announce deprecation for attach/detach crypto session
>   doc: announce deprecation in crypto queue pair start/stop
>   doc: announce deprecation in crypto feature flags
>   cryptodev: rename get session size API
> 
>  app/test-crypto-perf/main.c                   |  2 +-
>  doc/guides/prog_guide/cryptodev_lib.rst       |  6 ++--
>  doc/guides/rel_notes/deprecation.rst          | 25 +++++++++++++
>  drivers/crypto/aesni_gcm/aesni_gcm_pmd.c      |  2 +-
>  drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c    |  2 +-
>  drivers/crypto/armv8/rte_armv8_pmd.c          |  2 +-
>  drivers/crypto/kasumi/rte_kasumi_pmd.c        |  2 +-
>  drivers/crypto/openssl/rte_openssl_pmd.c      |  2 +-
>  drivers/crypto/snow3g/rte_snow3g_pmd.c        |  2 +-
>  drivers/crypto/zuc/rte_zuc_pmd.c              |  2 +-
>  examples/ipsec-secgw/ipsec-secgw.c            |  2 +-
>  examples/ipsec-secgw/ipsec.c                  | 12 -------
>  examples/l2fwd-crypto/main.c                  |  2 +-
>  examples/vhost_crypto/main.c                  |  2 +-
>  lib/librte_cryptodev/rte_cryptodev.c          | 12 +++++++
>  lib/librte_cryptodev/rte_cryptodev.h          | 35 +++++++++++++++++++
>  .../rte_cryptodev_version.map                 |  8 +++++
>  test/test/test_cryptodev.c                    |  6 ++--
>  test/test/test_event_crypto_adapter.c         |  2 +-
>  19 files changed, 99 insertions(+), 29 deletions(-)
> 
> --
> 2.17.0

Series Acked-by: Deepak Kumar Jain <deepak.k.jain@intel.com>

Re: [dpdk-dev] [PATCH v5 0/6] Cryptodev API/ABI deprecation notices

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Jain, Deepak K
> Sent: Tuesday, May 22, 2018 3:30 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>; akhil.goyal@nxp.com; shally.verma@cavium.com
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v5 0/6] Cryptodev API/ABI deprecation notices
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> > Sent: Monday, May 21, 2018 2:09 PM
> > To: Doherty, Declan <declan.doherty@intel.com>; akhil.goyal@nxp.com;
> > shally.verma@cavium.com
> > Cc: dev@dpdk.org; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch@intel.com>
> > Subject: [dpdk-dev] [PATCH v5 0/6] Cryptodev API/ABI deprecation
> > notices
> >
> > v5:
> > - Renamed rte_cryptodev_get_header_session_size with
> >   rte_cryptodev_sym_get_header_session_size, and
> >   rte_cryptodev_get_private_session_size with
> >   rte_cryptodev_sym_get_private_session_size.
> >
> > v4:
> > - Fixed DPDK versions called out to deprecate/remove API.
> > - Removed rte_cryptodev_queue_pair_attach_sym_session call
> >   from the IPSec gw app, since the function is deprecated now.
> > - Added patch announcing a replacement of some of the crypto
> >   feature flags
> > - Added patch renaming two symmetric specific functions
> >   from *_session_* to *_sym_session_*.
> >
> > v3:
> > - Added an extra deprecation announcement (replacing rte_pci_device
> >   with rte_device)
> > - Rebased against latest DPDK code
> >
> > v2:
> > - Added an extra deprecation announcement
> > - Bonded the other two deprecation notices with the new one in a
> >   patchset
> >
> > Pablo de Lara (6):
> >   doc: announce ABI change for crypto sym info struct
> >   doc: announce ABI change for crypto info struct
> >   doc: announce deprecation for attach/detach crypto session
> >   doc: announce deprecation in crypto queue pair start/stop
> >   doc: announce deprecation in crypto feature flags
> >   cryptodev: rename get session size API
> >
> >  app/test-crypto-perf/main.c                   |  2 +-
> >  doc/guides/prog_guide/cryptodev_lib.rst       |  6 ++--
> >  doc/guides/rel_notes/deprecation.rst          | 25 +++++++++++++
> >  drivers/crypto/aesni_gcm/aesni_gcm_pmd.c      |  2 +-
> >  drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c    |  2 +-
> >  drivers/crypto/armv8/rte_armv8_pmd.c          |  2 +-
> >  drivers/crypto/kasumi/rte_kasumi_pmd.c        |  2 +-
> >  drivers/crypto/openssl/rte_openssl_pmd.c      |  2 +-
> >  drivers/crypto/snow3g/rte_snow3g_pmd.c        |  2 +-
> >  drivers/crypto/zuc/rte_zuc_pmd.c              |  2 +-
> >  examples/ipsec-secgw/ipsec-secgw.c            |  2 +-
> >  examples/ipsec-secgw/ipsec.c                  | 12 -------
> >  examples/l2fwd-crypto/main.c                  |  2 +-
> >  examples/vhost_crypto/main.c                  |  2 +-
> >  lib/librte_cryptodev/rte_cryptodev.c          | 12 +++++++
> >  lib/librte_cryptodev/rte_cryptodev.h          | 35 +++++++++++++++++++
> >  .../rte_cryptodev_version.map                 |  8 +++++
> >  test/test/test_cryptodev.c                    |  6 ++--
> >  test/test/test_event_crypto_adapter.c         |  2 +-
> >  19 files changed, 99 insertions(+), 29 deletions(-)
> >
> > --
> > 2.17.0
> 
> Series Acked-by: Deepak Kumar Jain <deepak.k.jain@intel.com>

Applied to dpdk-next-crypto.
Thanks,

Pablo

Re: [dpdk-dev] [PATCH v5 6/6] cryptodev: rename get session size API

[Thomas Monjalon]

21/05/2018 15:08, Pablo de Lara:
>  /**
> + * deprecated

@ is missing here.
Will fix when pulling the tree.

>   * Get the size of the header session, for all registered drivers.
>   *
>   * @return
>   *   Size of the header session.
>   */
> +__rte_deprecated
>  unsigned int
>  rte_cryptodev_get_header_session_size(void);