From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id DD2AD1E2B8 for ; Tue, 12 Jun 2018 17:54:49 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jun 2018 08:54:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,215,1526367600"; d="scan'208";a="63945700" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga001.jf.intel.com with ESMTP; 12 Jun 2018 08:54:46 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by IRSMSX107.ger.corp.intel.com ([169.254.10.238]) with mapi id 14.03.0319.002; Tue, 12 Jun 2018 16:54:45 +0100 From: "De Lara Guarch, Pablo" To: "Trahe, Fiona" , "dev@dpdk.org" CC: "Jozwiak, TomaszX" Thread-Topic: [PATCH 2/5] crypto/qat: move to dynamic logging for non-dp trace Thread-Index: AQHT6Ru58Vcuh3HddEivqP6d+9/2nKRc989g Date: Tue, 12 Jun 2018 15:54:45 +0000 Message-ID: References: <1526038308-12043-1-git-send-email-fiona.trahe@intel.com> <1526038308-12043-3-git-send-email-fiona.trahe@intel.com> In-Reply-To: <1526038308-12043-3-git-send-email-fiona.trahe@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWE0YWY1ZjctZDA5Yy00MThiLWFiYzEtYjgwYTI4ZDgxYzUwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSzhyOGR4SldyXC9WdmxuR3JkQVlLc0paU0xTUG41akdxXC9rWXd5bkZxWWlKamZzNEpmTUlucFpCTzBrZndxS2xSIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/5] crypto/qat: move to dynamic logging for non-dp trace X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jun 2018 15:54:50 -0000 Hi, > -----Original Message----- > From: Trahe, Fiona > Sent: Friday, May 11, 2018 12:32 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Trahe, Fiona > ; Jozwiak, TomaszX > Subject: [PATCH 2/5] crypto/qat: move to dynamic logging for non-dp trace >=20 > From: Tomasz Jozwiak >=20 > For all trace not on the data-path move to dynamic logging. >=20 > Signed-off-by: Tomasz Jozwiak > Signed-off-by: Fiona Trahe ... > +++ b/drivers/crypto/qat/qat_logs.c > @@ -0,0 +1,18 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2018 Intel Corporation > + */ > + > +#include > + > +int qat_gen_logtype; > + > +static void > +qat_pci_init_log(void) > +{ > + /* Non-data-path logging for pci device and all services */ > + qat_gen_logtype =3D rte_log_register("pmd.qat_general"); > + if (qat_gen_logtype >=3D 0) > + rte_log_set_level(qat_gen_logtype, RTE_LOG_NOTICE); } > + > +RTE_INIT(qat_pci_init_log); I am seeing a compilation error on clang: drivers/crypto/qat/qat_logs.c:18:1: error: attribute declaration must precede definition [-Werror,-Wignored-attributes= ] RTE_INIT(qat_pci_init_log); ^ Thanks, Pablo