From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 6E4BC1B055 for ; Sun, 17 Jun 2018 21:38:36 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jun 2018 12:38:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,236,1526367600"; d="scan'208";a="48451869" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga008.fm.intel.com with ESMTP; 17 Jun 2018 12:38:33 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 17 Jun 2018 20:38:33 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by irsmsx155.ger.corp.intel.com ([169.254.14.241]) with mapi id 14.03.0319.002; Sun, 17 Jun 2018 20:38:32 +0100 From: "De Lara Guarch, Pablo" To: "Verma, Shally" CC: "Trahe, Fiona" , "akhil.goyal@nxp.com" , "dev@dpdk.org" , "Athreya, Narayana Prasad" , "Sahu, Sunila" , "Gupta, Ashish" Thread-Topic: [PATCH v3 5/6] crypto/openssl: add asym crypto support Thread-Index: AQHT7NwQJS1xOYB9VUuOTltSRnz3NqRkm6rggAAfFoCAAFCL0A== Date: Sun, 17 Jun 2018 19:38:32 +0000 Message-ID: References: <1526450713-17299-1-git-send-email-shally.verma@caviumnetworks.com> <1526450713-17299-6-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmY1YjE3ZTgtNTZlMy00YTVkLTljMTAtN2MyZDYwMTE2YjIyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiamhJdlNNeFwveXcyTXNtSFFwTFR1UW1EaVRhOEJOcHlCbTRyeE9ETnlaNWNCRzZ1SEZiY3R3NHJ0aFB6dmlTdTgifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 5/6] crypto/openssl: add asym crypto support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Jun 2018 19:38:37 -0000 > -----Original Message----- > From: Verma, Shally [mailto:Shally.Verma@cavium.com] > Sent: Sunday, June 17, 2018 4:48 PM > To: De Lara Guarch, Pablo > Cc: Trahe, Fiona ; akhil.goyal@nxp.com; > dev@dpdk.org; Athreya, Narayana Prasad > ; Sahu, Sunila > ; Gupta, Ashish > Subject: RE: [PATCH v3 5/6] crypto/openssl: add asym crypto support >=20 > Hi Pablo >=20 > >-----Original Message----- > >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com] > >Sent: 17 June 2018 18:55 > >To: Verma, Shally > >Cc: Trahe, Fiona ; akhil.goyal@nxp.com; > >dev@dpdk.org; Athreya, Narayana Prasad > >; Sahu, Sunila > >; Gupta, Ashish > >Subject: RE: [PATCH v3 5/6] crypto/openssl: add asym crypto support > > > >External Email > > > >> -----Original Message----- > >> From: Shally Verma [mailto:shally.verma@caviumnetworks.com] > >> Sent: Wednesday, May 16, 2018 7:05 AM > >> To: De Lara Guarch, Pablo > >> Cc: Trahe, Fiona ; akhil.goyal@nxp.com; > >> dev@dpdk.org; pathreya@caviumnetworks.com; Sunila Sahu > >> ; Ashish Gupta > >> > >> Subject: [PATCH v3 5/6] crypto/openssl: add asym crypto support > >> > >> Add asymmetric crypto operation support in openssl PMD. > >> Current list of supported asym xforms: > >> * RSA > >> * DSA > >> * Deffie-hellman > >> * Modular Operations > >> > >> changes from v2: > >> - Update the pmd capability as per new capability structure > >> > >> changes from v1: > >> - resolve new line error in dod/guides/cryptodevs/openssl.rst > >> > >> Signed-off-by: Shally Verma > >> Signed-off-by: Sunila Sahu > >> Signed-off-by: Ashish Gupta > >> --- > .. [snip] .. >=20 > >> +; > >> +; Supported Asymmetric algorithms of the 'openssl' crypto driver. > >> +; > >> +[Asymmetric] > >> +RSA =3D Y > >> +DSA =3D Y > >> +Modular Exponentiation =3D Y > >> +Modular Inversion =3D Y > >> +Deffie-hellman =3D Y > > > >You need to add these parameters in default.ini file, otherwise they > >are not shown when building the documentation. > > > [Shally] Ok >=20 > ..[snip].. >=20 > >> > >> diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c > >> b/drivers/crypto/openssl/rte_openssl_pmd.c > >> index f584d0d6f..527e42773 100644 > >> --- a/drivers/crypto/openssl/rte_openssl_pmd.c > >> +++ b/drivers/crypto/openssl/rte_openssl_pmd.c > > > >... > > > >> + } > >> + dh_key->priv_key =3D BN_bin2bn(op->priv_key.data, > >> + op->priv_key.length, > >> + dh_key->priv_key); > > > >As on the previous patch, I am getting a compilation issue: > > > >drivers/crypto/openssl/rte_openssl_pmd.c:1711:9: error: > >dereferencing pointer to incomplete type 'DH {aka struct dh_st}' > > dh_key->priv_key =3D BN_bin2bn(op->priv_key.data, > > > [Shally] as I mentioned before Openssl PMD support 1.0.2 version > series(http://doc.dpdk.org/guides/cryptodevs/openssl.html) and thus the e= rror >=20 > >... > > > >> diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c > >> b/drivers/crypto/openssl/rte_openssl_pmd_ops.c > >> index 1cb87d59a..76f7410cb 100644 > >> --- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c > >> +++ b/drivers/crypto/openssl/rte_openssl_pmd_ops.c > > > >... > > > >> struct rte_cryptodev_ops openssl_pmd_ops =3D { > >> .dev_configure =3D openssl_pmd_config, > >> .dev_start =3D openssl_pmd_start, > >> @@ -750,8 +1138,11 @@ struct rte_cryptodev_ops openssl_pmd_ops =3D { > >> .queue_pair_count =3D openssl_pmd_qp_count, > >> > >> .session_get_size =3D openssl_pmd_session_get_size= , > >> + .asym_session_get_size =3D > >> openssl_pmd_asym_session_get_size, > >> .session_configure =3D openssl_pmd_session_configur= e, > >> - .session_clear =3D openssl_pmd_session_clear > >> + .asym_session_configure =3D > >> openssl_pmd_asym_session_configure, > >> + .session_clear =3D openssl_pmd_session_clear, > >> + .asym_session_clear =3D openssl_pmd_asym_session_cle= ar > >> }; > > > >I think session_get_size, session_configure and session_clear should be > >renamed to sym_session_*, to avoid confusion. Could you add another patc= h > renaming these? > > > [Shally] I see in latest cryptodev these typedefs are already named to > cryptodev_sym_configure_session_t, _sym_get_session_private_size_t and > _sym_free_.. so these changes would come while rebase. > or you are referring to change openssl_pmd_session_configure to > openssl_pmd_sym_session_configure and so others? Yes, but the name is still session_configure/clear, not sym_session_configu= re/clear, right? And also, I think we should rename the OpenSSL functions, openssl_pmd_sessi= on_*, to openssl_pmd_sym_session_*. Pablo >=20 > Thanks for review. >=20 > >Thanks, > >Pablo > >