From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id B392C1B3A0 for ; Wed, 20 Jun 2018 00:30:16 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jun 2018 15:30:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,244,1526367600"; d="scan'208";a="233941204" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga005.jf.intel.com with ESMTP; 19 Jun 2018 15:30:05 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by IRSMSX104.ger.corp.intel.com ([169.254.5.212]) with mapi id 14.03.0319.002; Tue, 19 Jun 2018 23:30:04 +0100 From: "De Lara Guarch, Pablo" To: Shally Verma CC: "Trahe, Fiona" , "dev@dpdk.org" , "pathreya@caviumnetworks.com" , "mchalla@caviumnetworks.com" , Ashish Gupta , Sunila Sahu Thread-Topic: [PATCH v1 7/7] drivers/compress: add meson.build support Thread-Index: AQHT/LkXWvD1C4ljTkirijIKQicpNaRoPrdA Date: Tue, 19 Jun 2018 22:30:03 +0000 Message-ID: References: <1528194913-25893-1-git-send-email-shally.verma@caviumnetworks.com> <1528194913-25893-8-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: <1528194913-25893-8-git-send-email-shally.verma@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjQ2OTJjNzItOTI1Mi00NjczLWJiYTAtNDkyZGFkMDI3ZWYwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiN1Buc0t5Z3J2eDdlTVorMjE4TWJMazZVVlNNYkp2MXVhTDA3cUZsYU92V1E2OUlrcmlhemJUdzJOaU9cLzQ1ZkoifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 7/7] drivers/compress: add meson.build support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jun 2018 22:30:17 -0000 > -----Original Message----- > From: Shally Verma [mailto:shally.verma@caviumnetworks.com] > Sent: Tuesday, June 5, 2018 11:35 AM > To: De Lara Guarch, Pablo > Cc: Trahe, Fiona ; dev@dpdk.org; > pathreya@caviumnetworks.com; mchalla@caviumnetworks.com; Ashish Gupta > ; Sunila Sahu > > Subject: [PATCH v1 7/7] drivers/compress: add meson.build support >=20 > Add octeontx in drivers/compress/meson.build. This should be added in patch 1. >=20 > Also change the config and drv format flags to append _compress to use > compression specific format for global filenames. This also require chang= e in > compression PMDs to rename their version.map files as rte_pmd_ name>_compress.map ex. Isal should rename as > rte_pmd_isal_compress_version.map. >=20 > Currently the drivers/compress/meson.build use the generic config names w= ith > no compress specific specifier. This breaks meson build when vendor uses = same > name for different PMDs, where all belongs to same platform. > Ex. drivers/net/octeontx, drivers/event/octeontx, drivers/compress/octeon= tx > where, net, event and compress carry PMD for eth, event and compression > devices for Octeontx platform. Thus, differentiate globally used files us= ing > module specific specifier ex. rte_pmd_octeontx_compress_version.map > and rte_pmd_octeontx_event_version.map I think instead of forcing all the PMDs to use that suffix, if there are dr= ivers with the same PMD, they can add the "compres" suffix, without imposing it to others.