From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id E53231BB3A for ; Sat, 23 Jun 2018 20:16:57 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Jun 2018 11:16:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,262,1526367600"; d="scan'208";a="61619372" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga003.jf.intel.com with ESMTP; 23 Jun 2018 11:16:45 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by IRSMSX104.ger.corp.intel.com ([169.254.5.212]) with mapi id 14.03.0319.002; Sat, 23 Jun 2018 19:16:44 +0100 From: "De Lara Guarch, Pablo" To: "Verma, Shally" CC: "Trahe, Fiona" , "akhil.goyal@nxp.com" , "dev@dpdk.org" , "Athreya, Narayana Prasad" , "Sahu, Sunila" , "Gupta, Ashish" Thread-Topic: [PATCH v3 5/6] crypto/openssl: add asym crypto support Thread-Index: AQHT7NwQJS1xOYB9VUuOTltSRnz3NqRkm6rggAAfFoCAAFCL0IAAlSoAgAhUKQCAAGvi0A== Date: Sat, 23 Jun 2018 18:16:44 +0000 Message-ID: References: <1526450713-17299-1-git-send-email-shally.verma@caviumnetworks.com> <1526450713-17299-6-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGU1YjIwOGItN2VlOS00ZjYwLTg0Y2MtZWY5M2Q0ZDUxNmZkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSUNIM01sRHFzMGhCcE9iaTFhU0U2R2x4alI5Q200OWhGaXgyNFMrUzNMbWtRK2Z6YkN4QU1VTU12YUx5dUNDcCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 5/6] crypto/openssl: add asym crypto support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jun 2018 18:16:58 -0000 > -----Original Message----- > From: Verma, Shally [mailto:Shally.Verma@cavium.com] > Sent: Saturday, June 23, 2018 1:42 PM > To: De Lara Guarch, Pablo > Cc: Trahe, Fiona ; akhil.goyal@nxp.com; > dev@dpdk.org; Athreya, Narayana Prasad > ; Sahu, Sunila > ; Gupta, Ashish > Subject: RE: [PATCH v3 5/6] crypto/openssl: add asym crypto support >=20 > Hi Pablo >=20 > >-----Original Message----- > >From: Verma, Shally > >Sent: 18 June 2018 11:00 > >To: 'De Lara Guarch, Pablo' > >Cc: Trahe, Fiona ; akhil.goyal@nxp.com; > >dev@dpdk.org; Athreya, Narayana Prasad > >; Sahu, Sunila > >; Gupta, Ashish > >Subject: RE: [PATCH v3 5/6] crypto/openssl: add asym crypto support > > > //snip >=20 > >>> >> > >>> >> .session_get_size =3D openssl_pmd_session_get_= size, > >>> >> + .asym_session_get_size =3D > >>> >> openssl_pmd_asym_session_get_size, > >>> >> .session_configure =3D openssl_pmd_session_conf= igure, > >>> >> - .session_clear =3D openssl_pmd_session_clea= r > >>> >> + .asym_session_configure =3D > >>> >> openssl_pmd_asym_session_configure, > >>> >> + .session_clear =3D openssl_pmd_session_clea= r, > >>> >> + .asym_session_clear =3D openssl_pmd_asym_session= _clear > >>> >> }; > >>> > > >>> >I think session_get_size, session_configure and session_clear > >>> >should be renamed to sym_session_*, to avoid confusion. Could you > >>> >add another patch > >>> renaming these? > >>> > > >>> [Shally] I see in latest cryptodev these typedefs are already named > >>> to cryptodev_sym_configure_session_t, > >>> _sym_get_session_private_size_t and _sym_free_.. so these changes wou= ld > come while rebase. > >>> or you are referring to change openssl_pmd_session_configure to > >>> openssl_pmd_sym_session_configure and so others? > >> > >>Yes, but the name is still session_configure/clear, not > sym_session_configure/clear, right? > >>And also, I think we should rename the OpenSSL functions, > >>openssl_pmd_session_*, to openssl_pmd_sym_session_*. > >> > >[Shally] Ok. I will look into this. > > > [Shally] if I change these names in struct rte_cryptodev_ops, then we wil= l need > to change all drivers. I think that should be done in a separate patch se= ries > specific to rename these. For now, I will rename only openssl pmd APIs to= use > _sym version for this patch series. Right. I think a separate patch is a good idea, but it has to be done in on= e patch, to avoid breaking the compilation. Could you send this patch soon? Thanks, Pablo >=20 > >Thanks > >Shally > > > >>Pablo > >> > >>> > >>> Thanks for review. > >>> > >>> >Thanks, > >>> >Pablo > >>> >