From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id D9BA644C3 for ; Mon, 25 Jun 2018 18:35:34 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jun 2018 09:35:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,270,1526367600"; d="scan'208";a="52764964" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga006.jf.intel.com with ESMTP; 25 Jun 2018 09:35:31 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by irsmsx105.ger.corp.intel.com ([169.254.7.126]) with mapi id 14.03.0319.002; Mon, 25 Jun 2018 17:35:30 +0100 From: "De Lara Guarch, Pablo" To: "Verma, Shally" CC: "Trahe, Fiona" , "akhil.goyal@nxp.com" , "dev@dpdk.org" , "Athreya, Narayana Prasad" , "Sahu, Sunila" , "Gupta, Ashish" Thread-Topic: [PATCH v3 5/6] crypto/openssl: add asym crypto support Thread-Index: AQHT7NwQJS1xOYB9VUuOTltSRnz3NqRkm6rggAAfFoCAAFCL0IAAlSoAgAhUKQCAAGvi0P//9GgAgAMWJIA= Date: Mon, 25 Jun 2018 16:35:29 +0000 Message-ID: References: <1526450713-17299-1-git-send-email-shally.verma@caviumnetworks.com> <1526450713-17299-6-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODg4YjE0YjMtNjE1ZC00MjMxLWE0NTUtMWIzZGJlNTgyNmYzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQTc2WXpJNVV1WVVMTXRLT2swYzJWYVZWcCtRR2ZtTU9MbXFTMXUxbjNLcWpiS2Q3UTMwdVprRDBGTDFka2NsMSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 5/6] crypto/openssl: add asym crypto support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jun 2018 16:35:35 -0000 > -----Original Message----- > From: Verma, Shally [mailto:Shally.Verma@cavium.com] > Sent: Saturday, June 23, 2018 7:26 PM > To: De Lara Guarch, Pablo > Cc: Trahe, Fiona ; akhil.goyal@nxp.com; > dev@dpdk.org; Athreya, Narayana Prasad > ; Sahu, Sunila > ; Gupta, Ashish > Subject: RE: [PATCH v3 5/6] crypto/openssl: add asym crypto support >=20 >=20 >=20 > >-----Original Message----- > >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com] > >Sent: 23 June 2018 23:47 > >To: Verma, Shally > >Cc: Trahe, Fiona ; akhil.goyal@nxp.com; > >dev@dpdk.org; Athreya, Narayana Prasad > >; Sahu, Sunila > >; Gupta, Ashish > >Subject: RE: [PATCH v3 5/6] crypto/openssl: add asym crypto support > > > >External Email > // snip >=20 > >> >>Yes, but the name is still session_configure/clear, not > >> sym_session_configure/clear, right? > >> >>And also, I think we should rename the OpenSSL functions, > >> >>openssl_pmd_session_*, to openssl_pmd_sym_session_*. > >> >> > >> >[Shally] Ok. I will look into this. > >> > > >> [Shally] if I change these names in struct rte_cryptodev_ops, then we > >> will need to change all drivers. I think that should be done in a > >> separate patch series specific to rename these. For now, I will > >> rename only openssl pmd APIs to use _sym version for this patch series= . > > > >Right. I think a separate patch is a good idea, but it has to be done > >in one patch, to avoid breaking the compilation. Could you send this pat= ch > soon? > > > I can send openssl asym related patch soon. Can't commit on right now for= sym_ > session name in pmd ops changes. > Sorry about that. I will send a patch renaming these functions as part of cryptodev API chang= es http://patches.dpdk.org/cover/40958/ Thanks, Pablo >=20 > Thanks > Shally >=20 > >Thanks, > >Pablo > > > >> > >> >Thanks > >> >Shally > >> > > >> >>Pablo > >> >> > >> >>> > >> >>> Thanks for review. > >> >>> > >> >>> >Thanks, > >> >>> >Pablo > >> >>> >