From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 169D737A2 for ; Mon, 25 Jun 2018 23:34:18 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jun 2018 14:34:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,271,1526367600"; d="scan'208";a="51838707" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga007.jf.intel.com with ESMTP; 25 Jun 2018 14:34:16 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by IRSMSX103.ger.corp.intel.com ([169.254.3.136]) with mapi id 14.03.0319.002; Mon, 25 Jun 2018 22:34:15 +0100 From: "De Lara Guarch, Pablo" To: "Verma, Shally" CC: "Trahe, Fiona" , "akhil.goyal@nxp.com" , "dev@dpdk.org" , "Athreya, Narayana Prasad" , "Sahu, Sunila" , "Gupta, Ashish" Thread-Topic: [PATCH v3 1/6] lib/cryptodev: add asymmetric algos in cryptodev Thread-Index: AQHT7NwNhuZPQD0ndUiCQwXA0CbzaaRf+QvAgAyatACABShnoA== Date: Mon, 25 Jun 2018 21:34:14 +0000 Message-ID: References: <1526450713-17299-1-git-send-email-shally.verma@caviumnetworks.com> <1526450713-17299-2-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDQ5MTNlNzAtYjRkYi00YmI3LWI3YTktN2Q2MTA1NGQ0YmU4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTWptWlwvM1M0NUVWYkEwVGE2Y3I0VEVFRVRVN2RcL2NlaE9HN1BBaytEQXZraEdGWEpWaU1RY2dqcTdvQW1uR0tDIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/6] lib/cryptodev: add asymmetric algos in cryptodev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jun 2018 21:34:19 -0000 Hi Shally, > -----Original Message----- > From: Verma, Shally [mailto:Shally.Verma@cavium.com] > Sent: Friday, June 22, 2018 4:39 PM > To: De Lara Guarch, Pablo > Cc: Trahe, Fiona ; akhil.goyal@nxp.com; > dev@dpdk.org; Athreya, Narayana Prasad > ; Sahu, Sunila > ; Gupta, Ashish > Subject: RE: [PATCH v3 1/6] lib/cryptodev: add asymmetric algos in crypto= dev >=20 > Hi Pablo >=20 > >-----Original Message----- > >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com] > >Sent: 15 June 2018 14:10 > >To: Verma, Shally > >Cc: Trahe, Fiona ; akhil.goyal@nxp.com; > >dev@dpdk.org; Athreya, Narayana Prasad > >; Sahu, Sunila > >; Gupta, Ashish > >Subject: RE: [PATCH v3 1/6] lib/cryptodev: add asymmetric algos in > >cryptodev > > > //snip >=20 > > > >... > > > >> +/** > >> + * Asymmetric Cryptographic Operation. > >> + * > >> + * Structure describing asymmetric crypto operation params. > >> + * > >> + */ > >> +struct rte_crypto_asym_op { > >> + struct rte_cryptodev_asym_session *session; > >> + /**< Handle for the initialised session context */ > >> + > > > >Looking at the xform structure, it looks like a chain of xforms is possi= ble. > >Looking at this union, this case wouldn't be possible, as only one item = from the > union can be set. >=20 > [Shally] xforms, which support chaining, would need to have op_type in th= eir > respective xform struct. > Example struct rte_crypto_dh_xform, where app can chain Deffie-hellman > public and/or shared secret compute and DSA sign compute. >=20 > +struct rte_crypto_dh_xform { > + enum rte_crypto_asym_op_type type; > + /**< Setup xform for key generate or shared secret compute */ and DSA > +xforms struct >=20 > test_cryptodev_asym illustrates how to setup chained dh+dsa ops. Are you talking about test_dh_gen_kp? Because this is the only function where I see that there is a chain of xforms. In this case, both xforms are the same type (RTE_CRYPTO_ASYM_XFORM_DH), and the operation only sets parameters for rte_crypto_dh_op_param. I would expect that dh_op_param and dsa_op_param would need to be set, whic= h couldn't be done. Thanks, Pablo >=20 > Thanks > Shally >=20 >=20 > > > //snip