Re: [dpdk-dev] [PATCH v3 5/6] crypto/openssl: add asym crypto support

["De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>]

> -----Original Message-----
> From: Shally Verma [mailto:shally.verma@caviumnetworks.com]
> Sent: Wednesday, May 16, 2018 7:05 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: Trahe, Fiona <fiona.trahe@intel.com>; akhil.goyal@nxp.com;
> dev@dpdk.org; pathreya@caviumnetworks.com; Sunila Sahu
> <sunila.sahu@caviumnetworks.com>; Ashish Gupta
> <ashish.gupta@caviumnetworks.com>
> Subject: [PATCH v3 5/6] crypto/openssl: add asym crypto support
> 
> Add asymmetric crypto operation support in openssl PMD.
> Current list of supported asym xforms:
> * RSA
> * DSA
> * Deffie-hellman
> * Modular Operations
> 
> changes from v2:
> - Update the pmd capability as per new capability structure
> 
> changes from v1:
> - resolve new line error in dod/guides/cryptodevs/openssl.rst
> 
> Signed-off-by: Shally Verma <shally.verma@caviumnetworks.com>
> Signed-off-by: Sunila Sahu <sunila.sahu@caviumnetworks.com>
> Signed-off-by: Ashish Gupta <ashish.gupta@caviumnetworks.com>
> ---
>  doc/guides/cryptodevs/features/openssl.ini       |  11 +
>  doc/guides/cryptodevs/openssl.rst                |   1 +
>  drivers/crypto/openssl/rte_openssl_pmd.c         | 377 ++++++++++++++++++++-
>  drivers/crypto/openssl/rte_openssl_pmd_ops.c     | 395
> ++++++++++++++++++++++-
>  drivers/crypto/openssl/rte_openssl_pmd_private.h |  29 ++
>  5 files changed, 801 insertions(+), 12 deletions(-)

...

> @@ -1606,7 +1957,12 @@ openssl_pmd_enqueue_burst(void *queue_pair,
> struct rte_crypto_op **ops,
>  		if (unlikely(sess == NULL))
>  			goto enqueue_err;
> 
> -		retval = process_op(qp, ops[i], sess);
> +		if (ops[i]->type == RTE_CRYPTO_OP_TYPE_SYMMETRIC)
> +			retval = process_op(qp, ops[i],
> +					(struct openssl_session *) sess);

Could you rename process_op to process_sym_op?

Also, I think we need this check for the other PMDs.
I will send a patch to check if op type is equal to symmetric.

Pablo