From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 7FAA31B46E for ; Tue, 26 Jun 2018 11:23:08 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jun 2018 02:23:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,274,1526367600"; d="scan'208";a="52957727" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga006.jf.intel.com with ESMTP; 26 Jun 2018 02:23:05 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by IRSMSX101.ger.corp.intel.com ([169.254.1.148]) with mapi id 14.03.0319.002; Tue, 26 Jun 2018 10:23:05 +0100 From: "De Lara Guarch, Pablo" To: Shally Verma CC: "Trahe, Fiona" , "akhil.goyal@nxp.com" , "dev@dpdk.org" , "pathreya@caviumnetworks.com" , Sunila Sahu , Ashish Gupta Thread-Topic: [PATCH v3 5/6] crypto/openssl: add asym crypto support Thread-Index: AQHT7NwQJS1xOYB9VUuOTltSRnz3NqRyhBSw Date: Tue, 26 Jun 2018 09:23:04 +0000 Message-ID: References: <1526450713-17299-1-git-send-email-shally.verma@caviumnetworks.com> <1526450713-17299-6-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: <1526450713-17299-6-git-send-email-shally.verma@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjZhNTAzMWUtNTczYi00ZmY5LTgwOTAtM2IyNWU1NjM5MzczIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMitwREpGYVlRYVwvUUIzUHRxR2NvVktiblFINUJtdFFJWmNla2crWEVxWVBUTlpKSjZMRW42RDlxbllBVEFsU1IifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 5/6] crypto/openssl: add asym crypto support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jun 2018 09:23:09 -0000 > -----Original Message----- > From: Shally Verma [mailto:shally.verma@caviumnetworks.com] > Sent: Wednesday, May 16, 2018 7:05 AM > To: De Lara Guarch, Pablo > Cc: Trahe, Fiona ; akhil.goyal@nxp.com; > dev@dpdk.org; pathreya@caviumnetworks.com; Sunila Sahu > ; Ashish Gupta > > Subject: [PATCH v3 5/6] crypto/openssl: add asym crypto support >=20 > Add asymmetric crypto operation support in openssl PMD. > Current list of supported asym xforms: > * RSA > * DSA > * Deffie-hellman > * Modular Operations >=20 > changes from v2: > - Update the pmd capability as per new capability structure >=20 > changes from v1: > - resolve new line error in dod/guides/cryptodevs/openssl.rst >=20 > Signed-off-by: Shally Verma > Signed-off-by: Sunila Sahu > Signed-off-by: Ashish Gupta > --- > doc/guides/cryptodevs/features/openssl.ini | 11 + > doc/guides/cryptodevs/openssl.rst | 1 + > drivers/crypto/openssl/rte_openssl_pmd.c | 377 +++++++++++++++++= +++- > drivers/crypto/openssl/rte_openssl_pmd_ops.c | 395 > ++++++++++++++++++++++- > drivers/crypto/openssl/rte_openssl_pmd_private.h | 29 ++ > 5 files changed, 801 insertions(+), 12 deletions(-) ... > @@ -1606,7 +1957,12 @@ openssl_pmd_enqueue_burst(void *queue_pair, > struct rte_crypto_op **ops, > if (unlikely(sess =3D=3D NULL)) > goto enqueue_err; >=20 > - retval =3D process_op(qp, ops[i], sess); > + if (ops[i]->type =3D=3D RTE_CRYPTO_OP_TYPE_SYMMETRIC) > + retval =3D process_op(qp, ops[i], > + (struct openssl_session *) sess); Could you rename process_op to process_sym_op? Also, I think we need this check for the other PMDs. I will send a patch to check if op type is equal to symmetric. Pablo