From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id F0F4A1BACB for ; Wed, 27 Jun 2018 16:44:49 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2018 07:44:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,279,1526367600"; d="scan'208";a="66791867" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by fmsmga004.fm.intel.com with ESMTP; 27 Jun 2018 07:44:48 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by irsmsx105.ger.corp.intel.com ([169.254.7.126]) with mapi id 14.03.0319.002; Wed, 27 Jun 2018 15:44:47 +0100 From: "De Lara Guarch, Pablo" To: "Vemula, Hari KumarX" , "dev@dpdk.org" CC: "Pattan, Reshma" Thread-Topic: [PATCH v2] crypto/scheduler: add dynamic logging to scheduler Thread-Index: AQHUAg8xZNZxDQP5r0iUGSPdxbEZ66R0PXQg Date: Wed, 27 Jun 2018 14:44:46 +0000 Message-ID: References: <1528440991-11638-1-git-send-email-hari.kumarx.vemula@intel.com> <1528781694-9020-1-git-send-email-hari.kumarx.vemula@intel.com> In-Reply-To: <1528781694-9020-1-git-send-email-hari.kumarx.vemula@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGRkZTczN2QtNzlmMC00YzhmLTljMWEtN2JmMjFiZTI4NzVjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSTFLUjVxemZPWGZRU2NXWTAreFZBUzVLWmh1RTBCRHZnSjV6NEd5bFdhdG4zU3ROUFEwcmxoSTdFeGJYN3FUZyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] crypto/scheduler: add dynamic logging to scheduler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 14:44:50 -0000 Hi Hari, > -----Original Message----- > From: Vemula, Hari KumarX > Sent: Tuesday, June 12, 2018 6:35 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Pattan, Reshm= a > ; Vemula, Hari KumarX > > Subject: [PATCH v2] crypto/scheduler: add dynamic logging to scheduler >=20 > From: hvemulax >=20 > 1.added new logtype for driver. > 2.registered the new logtype. > 3.CS_LOG_ERR and RTE_LOG logtypes are replaced with new logtype name. >=20 > Signed-off-by: Hari Kumar > Reviewed-by: Reshma Pattan Some lines are too long now, due to the new macro. Could you change it to a shorter name? Maybe "CR_SCHED_LOG". Also, make the following changes: - Change title to: "crypto/scheduler: add dynamic logging", to avoid duplic= ations - Modify author to "Hari Kumar" - Remove unused " CONFIG_RTE_LIBRTE_PMD_CRYPTO_SCHEDULER_DEBUG" from config file. - Remove extra blank line at the end of rte_cryptodev_scheduler.c Thanks, Pablo