From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 530A21BE8A for ; Wed, 27 Jun 2018 16:54:44 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2018 07:54:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,279,1526367600"; d="scan'208";a="236048668" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga005.jf.intel.com with ESMTP; 27 Jun 2018 07:54:42 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by IRSMSX101.ger.corp.intel.com ([169.254.1.148]) with mapi id 14.03.0319.002; Wed, 27 Jun 2018 15:54:41 +0100 From: "De Lara Guarch, Pablo" To: "Somarowthu, Naga SureshX" , "dev@dpdk.org" CC: "Pattan, Reshma" Thread-Topic: [PATCH] crypto/openssl: add dynamic logging to openssl Thread-Index: AQHUAhCKFxyihnP2l0eoA+rGb8mz8qR0QlGQ Date: Wed, 27 Jun 2018 14:54:40 +0000 Message-ID: References: <1528782287-16670-1-git-send-email-naga.sureshx.somarowthu@intel.com> In-Reply-To: <1528782287-16670-1-git-send-email-naga.sureshx.somarowthu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTkxNmMwOTktZjMzMi00YzI1LWI5M2YtZDMxODlhOWVkNGE2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiR00xdkRlcGs2VCswcmtkc3RSVW9ydG9Pdk5lQ3M1OTNqUXVFTE9yUk8xck1GY1JDbFVGYWpkZDNlRDBjTVlyZyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] crypto/openssl: add dynamic logging to openssl X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 14:54:45 -0000 Hi Naga, > -----Original Message----- > From: Somarowthu, Naga SureshX > Sent: Tuesday, June 12, 2018 6:45 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Pattan, Reshm= a > ; Somarowthu, Naga SureshX > > Subject: [PATCH] crypto/openssl: add dynamic logging to openssl >=20 > 1.added new logtype for openssl driver. > 2.registered new logtype. > 3.OPENSSL_LOG_ERR and CDEV_LOG_ERR are > replaced with new logtype name OPENSSL_PMD_LOG. >=20 > Signed-off-by: Naga Suresh Somarowthu > Could you make the following changes? - Change the macro to OPENSSL_LOG, to make it shorter. - Change title to: crypto/openssl: add dynamic logging - Remove unused "CONFIG_RTE_LIBRTE_PMD_OPENSSL_DEBUG" from config file. - Remove extra blank line at the end of rte_openssl_pmd.c, - Set log level of the new type to INFO (see isal_compress_pmd.c) Thanks, Pablo