From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id B92DE1BFD5 for ; Wed, 27 Jun 2018 17:13:25 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2018 08:13:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,279,1526367600"; d="scan'208";a="68192118" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga001.jf.intel.com with ESMTP; 27 Jun 2018 08:13:23 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by IRSMSX152.ger.corp.intel.com ([163.33.192.66]) with mapi id 14.03.0319.002; Wed, 27 Jun 2018 16:13:23 +0100 From: "De Lara Guarch, Pablo" To: "Somarowthu, Naga SureshX" , "dev@dpdk.org" CC: "Pattan, Reshma" , "Chaitanya Babu, TalluriX" Thread-Topic: [PATCH] crypto/aesni_gcm: add dynamic logging to aesni_gcm Thread-Index: AQHUAhnQWnE1pP5/Gku+BGSMJ434e6R0TDfg Date: Wed, 27 Jun 2018 15:13:22 +0000 Message-ID: References: <1528786244-24821-1-git-send-email-naga.sureshx.somarowthu@intel.com> In-Reply-To: <1528786244-24821-1-git-send-email-naga.sureshx.somarowthu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODcxZWYyY2QtNThmNC00ZjUwLWEwMWEtNWYwMjEwMzQzOTI4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoic1VKcXhmcUxWQ2I2eHo0QlwvMlwvYVdaWVQ1dVd4djFSMHFxR3hKcERPVWdocDBCUnE5d2JkUzlwdStGQlFoSkdxIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] crypto/aesni_gcm: add dynamic logging to aesni_gcm X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 15:13:26 -0000 Hi Naga/Talluri, > -----Original Message----- > From: Somarowthu, Naga SureshX > Sent: Tuesday, June 12, 2018 7:51 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Pattan, Reshm= a > ; Chaitanya Babu, TalluriX > > Subject: [PATCH] crypto/aesni_gcm: add dynamic logging to aesni_gcm >=20 > From: tchaitax >=20 > 1.added new logtype for aesni_gcm driver. > 2.registered new logtype. > 3.GCM_LOG_ERR and CDEV_LOG_ERR are replaced with > new logtype name AESNI_GCM_PMD_LOG. >=20 > Signed-off-by: Talluri Chaitanya > Reviewed-by: Reshma Pattan Could you make the following changes? - Change the macro to AESNI_GCM_LOG, to make it shorter. - Change title to: crypto/aesni_gcm: add dynamic logging - Change the author name to "Talluri Chaitanya" - Remove unused "CONFIG_RTE_LIBRTE_PMD_AESNI_GCM_DEBUG=3Dn" from config file. - Set log level of the new type to INFO (see isal_compress_pmd.c) Thanks, Pablo