Re: [dpdk-dev] [PATCH] crypto/kasumi: add dynamic logging to kasumi

["De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>]

Hi Naga,

> -----Original Message-----
> From: Somarowthu, Naga SureshX
> Sent: Monday, June 25, 2018 6:23 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Pattan, Reshma
> <reshma.pattan@intel.com>; Somarowthu, Naga SureshX
> <naga.sureshx.somarowthu@intel.com>
> Subject: [PATCH] crypto/kasumi: add dynamic logging to kasumi
> 
> 1.added new logtype for kasumi driver.
> 2.registered new logtype.
> 3.KASUMI_LOG_ERR and CDEV_LOG_ERR are
>   replaced with new logtype name KASUMI_PMD_LOG.
> 
> Signed-off-by: Naga Suresh Somarowthu
> <naga.sureshx.somarowthu@intel.com>
> Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
> ---
>  drivers/crypto/kasumi/rte_kasumi_pmd.c         | 29 +++++++++++++++++---------
>  drivers/crypto/kasumi/rte_kasumi_pmd_ops.c     | 14 ++++++-------
>  drivers/crypto/kasumi/rte_kasumi_pmd_private.h | 26 +++++++----------------
>  3 files changed, 33 insertions(+), 36 deletions(-)

Could you make the following changes?

- Change the macro to KASUMI_LOG, to make it shorter.
- Change title to: crypto/kasumi: add dynamic logging
- Remove unused "CONFIG_RTE_LIBRTE_PMD_KASUMI_DEBUG=n"
from config file.
- Set log level of the new type to INFO (see isal_compress_pmd.c)

Thanks,
Pablo