From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 609461B593 for ; Wed, 27 Jun 2018 17:15:39 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2018 08:15:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,279,1526367600"; d="scan'208";a="60587928" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by FMSMGA003.fm.intel.com with ESMTP; 27 Jun 2018 08:15:36 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by IRSMSX151.ger.corp.intel.com ([169.254.4.216]) with mapi id 14.03.0319.002; Wed, 27 Jun 2018 16:15:35 +0100 From: "De Lara Guarch, Pablo" To: "Somarowthu, Naga SureshX" , "dev@dpdk.org" CC: "Pattan, Reshma" Thread-Topic: [PATCH] crypto/kasumi: add dynamic logging to kasumi Thread-Index: AQHUDEScUTfplQmC7Ei0XzjbWMCiNqR0OlQQ Date: Wed, 27 Jun 2018 15:15:35 +0000 Message-ID: References: <1529904182-8878-1-git-send-email-naga.sureshx.somarowthu@intel.com> In-Reply-To: <1529904182-8878-1-git-send-email-naga.sureshx.somarowthu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWM0ZjY1NDQtOWY2NS00YWFhLTgwZjctOWM1Y2IxNGRjOTg2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiek4xeGRRXC9Md0hOTU9vVmNLeUF4UEtRR2pLSnRkazBEbXFkcUxmR3ZaVFRIdmpHVjJcL0UzdHJZRGRYVmFHSmt3In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] crypto/kasumi: add dynamic logging to kasumi X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 15:15:40 -0000 Hi Naga, > -----Original Message----- > From: Somarowthu, Naga SureshX > Sent: Monday, June 25, 2018 6:23 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Pattan, Reshm= a > ; Somarowthu, Naga SureshX > > Subject: [PATCH] crypto/kasumi: add dynamic logging to kasumi >=20 > 1.added new logtype for kasumi driver. > 2.registered new logtype. > 3.KASUMI_LOG_ERR and CDEV_LOG_ERR are > replaced with new logtype name KASUMI_PMD_LOG. >=20 > Signed-off-by: Naga Suresh Somarowthu > > Reviewed-by: Reshma Pattan > --- > drivers/crypto/kasumi/rte_kasumi_pmd.c | 29 +++++++++++++++++---= ------ > drivers/crypto/kasumi/rte_kasumi_pmd_ops.c | 14 ++++++------- > drivers/crypto/kasumi/rte_kasumi_pmd_private.h | 26 +++++++-------------= --- > 3 files changed, 33 insertions(+), 36 deletions(-) Could you make the following changes? - Change the macro to KASUMI_LOG, to make it shorter. - Change title to: crypto/kasumi: add dynamic logging - Remove unused "CONFIG_RTE_LIBRTE_PMD_KASUMI_DEBUG=3Dn" from config file. - Set log level of the new type to INFO (see isal_compress_pmd.c) Thanks, Pablo