From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 01EBF1C02A for ; Wed, 27 Jun 2018 17:33:20 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2018 08:33:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,279,1526367600"; d="scan'208";a="66805025" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga004.fm.intel.com with ESMTP; 27 Jun 2018 08:33:08 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by IRSMSX151.ger.corp.intel.com ([169.254.4.216]) with mapi id 14.03.0319.002; Wed, 27 Jun 2018 16:33:07 +0100 From: "De Lara Guarch, Pablo" To: "Trahe, Fiona" , "ashish.gupta@caviumnetworks.com" , "Daly, Lee" CC: "dev@dpdk.org" Thread-Topic: [PATCH 1/2] compressdev: replace mbuf scatter gather flag Thread-Index: AQHUDimKPQMU6ylsk0O8hgdET3DWTqR0O7sA Date: Wed, 27 Jun 2018 15:33:07 +0000 Message-ID: References: <20180627055031.24394-1-pablo.de.lara.guarch@intel.com> <348A99DA5F5B7549AA880327E580B435895B5DFB@IRSMSX101.ger.corp.intel.com> In-Reply-To: <348A99DA5F5B7549AA880327E580B435895B5DFB@IRSMSX101.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjNmM2Q0NWYtMDUzOS00NDRjLWFkNDctMWNlNzgzMTU0MTUyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZ2ZFcU1ESzc4ZnlQR1I0XC9wRnM2Mlc1eVdwSEhIdyt0SFVnODA4U0NESU40dUNzSTYweWtcL2M3cWlVOWNCSGx3In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] compressdev: replace mbuf scatter gather flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 15:33:21 -0000 > -----Original Message----- > From: Trahe, Fiona > Sent: Wednesday, June 27, 2018 4:14 PM > To: De Lara Guarch, Pablo ; > ashish.gupta@caviumnetworks.com; Daly, Lee > Cc: dev@dpdk.org; Trahe, Fiona > Subject: RE: [PATCH 1/2] compressdev: replace mbuf scatter gather flag >=20 > Hi Pablo, >=20 > > -----Original Message----- > > From: De Lara Guarch, Pablo > > Sent: Wednesday, June 27, 2018 6:51 AM > > To: Trahe, Fiona ; > > ashish.gupta@caviumnetworks.com; Daly, Lee > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > > > > Subject: [PATCH 1/2] compressdev: replace mbuf scatter gather flag > > > > The current mbuf scatter gatter feature flag is > [Fiona] typo - gather Will fix. >=20 > > too ambiguous, as it is not clear if input and/or output buffers can > > be scatter gather mbufs or not. > > > > Therefore, three new flags will replace this flag: > > - RTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_SGL_OUT > > - RTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_FB_OUT > > - RTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_SGL_OUT > [Fiona] oops! CRYPTODEV?? Here and below in docs Oops... will fix!! :P >=20 > > > > Note that out-of-place flat buffers is supported by default and > > in-place is not supported by the library. > > > > Signed-off-by: Pablo de Lara > > --- > > doc/guides/rel_notes/release_18_08.rst | 6 ++++++ > > lib/librte_compressdev/rte_comp.c | 8 ++++++-- > > lib/librte_compressdev/rte_comp.h | 30 ++++++++++++++++++++------= ---- > > 3 files changed, 32 insertions(+), 12 deletions(-) > > > > diff --git a/doc/guides/rel_notes/release_18_08.rst > > b/doc/guides/rel_notes/release_18_08.rst > > index bc0124295..1fc38418a 100644 > > --- a/doc/guides/rel_notes/release_18_08.rst > > +++ b/doc/guides/rel_notes/release_18_08.rst > > @@ -60,6 +60,12 @@ API Changes > > Also, make sure to start the actual text at the margin. > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > > +* compressdev: Feature flag ``RTE_COMP_FF_MBUF_SCATTER_GATHER`` is > > + replaced with the following more explicit flags: > > + - ``RTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_SGL_OUT`` > > + - ``RTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_FB_OUT`` > > + - ``RTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_SGL_OUT`` > > + > > >=20 > > +#define RTE_COMP_FF_OUT_OF_PLACE_SGL_IN_SGL_OUT (1ULL << 2) > > +/**< Out-of-place Scatter-gather (SGL) mbufs are > > + * supported in input and output > > + */ > > +#define RTE_COMP_FF_OUT_OF_PLACE_SGL_IN_FB_OUT (1ULL << 3) > > +/**< Out-of-place Scatter-gather (SGL) mbufs are supported > > + * in input, but only flat buffers (FB) are supported in output */ > [Fiona] I'd replace "but only.." with "combined with FB in output" > As a PMD can set more than one of these flags, so the but only is mislead= ing in > this case. > Same with next flag. OK, will fix. Thanks! >=20