From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 151CD1BF67 for ; Wed, 27 Jun 2018 17:36:26 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2018 08:36:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,279,1526367600"; d="scan'208";a="67772392" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga001.fm.intel.com with ESMTP; 27 Jun 2018 08:36:24 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by IRSMSX101.ger.corp.intel.com ([169.254.1.148]) with mapi id 14.03.0319.002; Wed, 27 Jun 2018 16:36:24 +0100 From: "De Lara Guarch, Pablo" To: "Trahe, Fiona" , "ashish.gupta@caviumnetworks.com" , "Daly, Lee" CC: "dev@dpdk.org" Thread-Topic: [PATCH 2/2] compressdev: add huffman encoding flags Thread-Index: AQHUDiqzgAHXOjFx/kaiuV3QHpJ8raR0PHuQ Date: Wed, 27 Jun 2018 15:36:23 +0000 Message-ID: References: <20180627055031.24394-1-pablo.de.lara.guarch@intel.com> <20180627055031.24394-2-pablo.de.lara.guarch@intel.com> <348A99DA5F5B7549AA880327E580B435895B5E2C@IRSMSX101.ger.corp.intel.com> In-Reply-To: <348A99DA5F5B7549AA880327E580B435895B5E2C@IRSMSX101.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTQxOWNjNWYtNGU5ZC00ZDdmLWE2ZGEtNTAwNzllMDMxN2MxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZlwvYzBUOTdTcHE5YmZCXC9KR2NpckxkVzFTSVpaU1N4bEoycmFqbjRtakgzbUlVMlZ3R2FHSmJhZGN5VGoxVEZrIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/2] compressdev: add huffman encoding flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 15:36:27 -0000 > -----Original Message----- > From: Trahe, Fiona > Sent: Wednesday, June 27, 2018 4:23 PM > To: De Lara Guarch, Pablo ; > ashish.gupta@caviumnetworks.com; Daly, Lee > Cc: dev@dpdk.org; Trahe, Fiona > Subject: RE: [PATCH 2/2] compressdev: add huffman encoding flags >=20 > Hi Pablo, >=20 >=20 > > -----Original Message----- > > From: De Lara Guarch, Pablo > > Sent: Wednesday, June 27, 2018 6:51 AM > > To: Trahe, Fiona ; > > ashish.gupta@caviumnetworks.com; Daly, Lee > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > > > > Subject: [PATCH 2/2] compressdev: add huffman encoding flags > > > > Added Huffman fixed and dynamic encoding feature flags, so an > > application can query if a device supports these two types, when > > performing DEFLATE compression. > > > > Signed-off-by: Pablo de Lara > > --- > > drivers/compress/isal/isal_compress_pmd_ops.c | 4 +++- > > lib/librte_compressdev/rte_comp.c | 4 ++++ > > lib/librte_compressdev/rte_comp.h | 4 ++++ > > 3 files changed, 11 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/compress/isal/isal_compress_pmd_ops.c > > b/drivers/compress/isal/isal_compress_pmd_ops.c > > index 970a0413b..585f22802 100644 > > --- a/drivers/compress/isal/isal_compress_pmd_ops.c > > +++ b/drivers/compress/isal/isal_compress_pmd_ops.c > > @@ -12,7 +12,9 @@ > > static const struct rte_compressdev_capabilities isal_pmd_capabilities= [] =3D { > > { > > .algo =3D RTE_COMP_ALGO_DEFLATE, > > - .comp_feature_flags =3D > RTE_COMP_FF_SHAREABLE_PRIV_XFORM, > > + .comp_feature_flags =3D > RTE_COMP_FF_SHAREABLE_PRIV_XFORM | > > + RTE_COMP_FF_HUFFMAN_FIXED | > > + RTE_COMP_FF_HUFFMAN_DYNAMIC, > > .window_size =3D { > > .min =3D 15, > > .max =3D 15, > > diff --git a/lib/librte_compressdev/rte_comp.c > > b/lib/librte_compressdev/rte_comp.c > > index ea7692ae7..9711a86c8 100644 > > --- a/lib/librte_compressdev/rte_comp.c > > +++ b/lib/librte_compressdev/rte_comp.c > > @@ -36,6 +36,10 @@ rte_comp_get_feature_name(uint64_t flag) > > return "SHA2_SHA256_HASH"; > > case RTE_COMP_FF_SHAREABLE_PRIV_XFORM: > > return "SHAREABLE_PRIV_XFORM"; > > + case RTE_COMP_FF_HUFFMAN_FIXED: > > + return "HUFFMAN_FIXED"; > > + case RTE_COMP_FF_HUFFMAN_DYNAMIC: > > + return "HUFFMAN_DYNAMIC"; > [Fiona] Thanks for adding this. > Just in case any other algos are added in future which also use Huffman > encoding I'd suggest renaming to include DEFLATE, e.g. > RTE_COMP_FF_DFL_HUFFMAN_FIXED/DYNAMIC Since these flags are set per algorithm (in capabilities), do you think it is needed to specify DEFLATE? >=20 >=20 > > default: > > return NULL; > > } > > diff --git a/lib/librte_compressdev/rte_comp.h > > b/lib/librte_compressdev/rte_comp.h > > index 3ce6a80e1..c6a542c0c 100644 > > --- a/lib/librte_compressdev/rte_comp.h > > +++ b/lib/librte_compressdev/rte_comp.h > > @@ -62,6 +62,10 @@ extern "C" { > > * to create as many priv_xforms as it expects to have stateless > > * operations in-flight. > > */ > > +#define RTE_COMP_FF_HUFFMAN_FIXED (1ULL << 13) > > +/**< Fixed huffman enconding is supported */ > > +#define RTE_COMP_FF_HUFFMAN_DYNAMIC (1ULL << 14) > > +/**< Dynamic huffman enconding is supported */ > [Fiona] typo encoding. Will fix.