From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id E21331BF67 for ; Wed, 27 Jun 2018 17:38:09 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2018 08:38:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,279,1526367600"; d="scan'208";a="240775730" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by fmsmga005.fm.intel.com with ESMTP; 27 Jun 2018 08:38:08 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by irsmsx105.ger.corp.intel.com ([169.254.7.126]) with mapi id 14.03.0319.002; Wed, 27 Jun 2018 16:38:07 +0100 From: "De Lara Guarch, Pablo" To: "Somarowthu, Naga SureshX" , "dev@dpdk.org" CC: "Pattan, Reshma" Thread-Topic: [PATCH] crypto/kasumi: add dynamic logging to kasumi Thread-Index: AQHUDEScUTfplQmC7Ei0XzjbWMCiNqR0QLIw Date: Wed, 27 Jun 2018 15:38:06 +0000 Message-ID: References: <1529904182-8878-1-git-send-email-naga.sureshx.somarowthu@intel.com> In-Reply-To: <1529904182-8878-1-git-send-email-naga.sureshx.somarowthu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDcyNzBhMGUtMTMyNy00NWQ4LWEzY2QtM2MxZmQ0ODdlZmZkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiT01rVW05Z0hXWnBVZ3dnWU5ZUVNQVWRWVGtqWTJsZzh3WWdES2R2STByXC9pQ2JhSmFWN0R1bFVLbXBQa0cwaUoifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] crypto/kasumi: add dynamic logging to kasumi X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 15:38:10 -0000 Hi Naga, Two last comments below. > -----Original Message----- > From: Somarowthu, Naga SureshX > Sent: Monday, June 25, 2018 6:23 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Pattan, Reshm= a > ; Somarowthu, Naga SureshX > > Subject: [PATCH] crypto/kasumi: add dynamic logging to kasumi >=20 > 1.added new logtype for kasumi driver. > 2.registered new logtype. > 3.KASUMI_LOG_ERR and CDEV_LOG_ERR are > replaced with new logtype name KASUMI_PMD_LOG. >=20 > Signed-off-by: Naga Suresh Somarowthu > > Reviewed-by: Reshma Pattan > --- ... > if (cipher_xform) { > /* Only KASUMI F8 supported */ > if (cipher_xform->cipher.algo !=3D > RTE_CRYPTO_CIPHER_KASUMI_F8) > + KASUMI_PMD_LOG(ERR, "Unsupported cipher > algorithm "); > return -ENOTSUP; Missing braces, as there are two lines inside the if statement. >=20 > sess->cipher_iv_offset =3D cipher_xform->cipher.iv.offset; > if (cipher_xform->cipher.iv.length !=3D KASUMI_IV_LENGTH) { > - KASUMI_LOG_ERR("Wrong IV length"); > + KASUMI_PMD_LOG(ERR, "Wrong IV length"); > return -EINVAL; > } >=20 > @@ -102,10 +103,11 @@ kasumi_set_session_parameters(struct > kasumi_session *sess, > if (auth_xform) { > /* Only KASUMI F9 supported */ > if (auth_xform->auth.algo !=3D RTE_CRYPTO_AUTH_KASUMI_F9) > + KASUMI_PMD_LOG(ERR, "Unsupported > authentication"); > return -ENOTSUP; Missing braces, as there are two lines inside the if statement. >=20 > if (auth_xform->auth.digest_length !=3D