From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Babu Radhakrishnan,
AgalyaX" <agalyax.babu.radhakrishnan@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Pattan, Reshma" <reshma.pattan@intel.com>
Subject: Re: [dpdk-dev] [PATCH] crypto/zuc: add dynamic logging to zuc
Date: Wed, 27 Jun 2018 16:19:04 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8977F8DDCCE@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1529659681-28346-1-git-send-email-agalyax.babu.radhakrishnan@intel.com>
Hi Agalya,
> -----Original Message-----
> From: Babu Radhakrishnan, AgalyaX
> Sent: Friday, June 22, 2018 10:28 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Pattan, Reshma
> <reshma.pattan@intel.com>; Babu Radhakrishnan, AgalyaX
> <agalyax.babu.radhakrishnan@intel.com>
> Subject: [PATCH] crypto/zuc: add dynamic logging to zuc
>
> 1.added new logtype for zuc driver.
> 2.registered new logtype.
> 3.ZUC_LOG_ERR and CDEV_LOG_ERR are
> replaced with new logtype name ZUC_PMD_LOG
>
> Signed-off-by: Agalya Babu RadhaKrishnan
> <agalyax.babu.radhakrishnan@intel.com>
> Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
Could you make the following changes?
- Change the macro to ZUC_LOG, to make it shorter.
- Change title to: crypto/zuc: add dynamic logging
- Is your surname RadhaKrishnan all together or with a space?
Because there is a mismatch between the author and the Signed-off-by line.
- Remove unused "CONFIG_RTE_LIBRTE_PMD_ZUC_DEBUG=n"
from config file.
- Set log level of the new type to INFO (see isal_compress_pmd.c)
Thanks,
Pablo
next parent reply other threads:[~2018-06-27 16:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1529659681-28346-1-git-send-email-agalyax.babu.radhakrishnan@intel.com>
2018-06-27 16:19 ` De Lara Guarch, Pablo [this message]
2018-06-25 5:21 Jananee Parthasarathy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8977F8DDCCE@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=agalyax.babu.radhakrishnan@intel.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).