From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 17F641C067 for ; Wed, 27 Jun 2018 18:27:39 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2018 09:27:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,279,1526367600"; d="scan'208";a="236071749" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga005.jf.intel.com with ESMTP; 27 Jun 2018 09:27:37 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by IRSMSX101.ger.corp.intel.com ([169.254.1.148]) with mapi id 14.03.0319.002; Wed, 27 Jun 2018 17:27:36 +0100 From: "De Lara Guarch, Pablo" To: "Parthasarathy, JananeeX M" , "dev@dpdk.org" CC: "Pattan, Reshma" , "Poornima, PallantlaX" Thread-Topic: [PATCH] crypto/null: add dynamic logging to null driver Thread-Index: AQHUBJXesZObFWfcBk6GSEhtHLRwCqR0XNJw Date: Wed, 27 Jun 2018 16:27:36 +0000 Message-ID: References: <1529059456-25450-1-git-send-email-jananeex.m.parthasarathy@intel.com> In-Reply-To: <1529059456-25450-1-git-send-email-jananeex.m.parthasarathy@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTI5ZDE5ZGMtZmNiYi00ZjRlLTllYmEtOTY2NzcwYWY2ZWE2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWEgyWTJERTJJNUFGU0UxTFBnQXJOaWErRmE1R2tLdVkycEpUcHhjUldHdGk4RXZSM0oxTGhLVnp0NTdoTXE5ViJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] crypto/null: add dynamic logging to null driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 16:27:41 -0000 Hi Jananee/Pallantla, > -----Original Message----- > From: Parthasarathy, JananeeX M > Sent: Friday, June 15, 2018 11:44 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Pattan, Reshm= a > ; Parthasarathy, JananeeX M > ; Poornima, PallantlaX > > Subject: [PATCH] crypto/null: add dynamic logging to null driver >=20 > 1.added new logtype for null driver. > 2.registered new logtype. > 3.NULL_CRYPTO_LOG_ERR, RTE_LOG_ERR and CDEV_LOG_ERR are replaced > with new logtype name NULL_PMD_LOG. >=20 > Signed-off-by: Pallantla Poornima > Reviewed-by: Reshma Pattan Could you make the following changes? - Change the macro to NULL_LOG, to make it shorter. - Change title to: crypto/null: add dynamic logging - There is a mismatch between the author name and the name in the Signed-of= f line. Could you fix it? - Set log level of the new type to INFO (see isal_compress_pmd.c) Thanks, Pablo