From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 3179D1C3BA; Wed, 27 Jun 2018 23:14:14 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2018 14:14:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,280,1526367600"; d="scan'208";a="68275559" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga001.jf.intel.com with ESMTP; 27 Jun 2018 14:14:12 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by IRSMSX103.ger.corp.intel.com ([169.254.3.136]) with mapi id 14.03.0319.002; Wed, 27 Jun 2018 22:14:11 +0100 From: "De Lara Guarch, Pablo" To: "Gujjar, Abhinandan S" , "Doherty, Declan" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] cryptodev: fix ABI breakage Thread-Index: AQHUAvoCTvAW4BxtoUOnLLQOW5oTCKRd5BOAgBbH36A= Date: Wed, 27 Jun 2018 21:14:10 +0000 Message-ID: References: <20180613093648.6070-1-pablo.de.lara.guarch@intel.com> <5612CB344B05EE4F95FC5B729939F78070793376@PGSMSX102.gar.corp.intel.com> In-Reply-To: <5612CB344B05EE4F95FC5B729939F78070793376@PGSMSX102.gar.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2Y0ZWFlZmMtYTcwOC00ODRhLWI0ZjctMmUxYmEwN2ExYjI0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiN1VQSlwvRlhvMCt1TUFaRnFhU1kwSm5QWlNwT0VoYjdrN0F6aFFXUVwvQXBFcUFQejh0NHl4VmVkXC9LRWdnTU5EdiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] cryptodev: fix ABI breakage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 21:14:15 -0000 > -----Original Message----- > From: Gujjar, Abhinandan S > Sent: Wednesday, June 13, 2018 11:01 AM > To: De Lara Guarch, Pablo ; Doherty, Decl= an > > Cc: dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH] cryptodev: fix ABI breakage >=20 >=20 >=20 > > -----Original Message----- > > From: De Lara Guarch, Pablo > > Sent: Wednesday, June 13, 2018 3:07 PM > > To: Doherty, Declan ; Gujjar, Abhinandan S > > > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > > ; stable@dpdk.org > > Subject: [PATCH] cryptodev: fix ABI breakage > > > > In 17.08, the crypto operation was restructured, and some reserved > > bytes (5) were added to have the mempool pointer aligned to 64 bits, > > since the structure is expected to be aligned to 64 bits, allowing > > future additions with no ABI breakage needed. > > > > In 18.05, a new 2-byte field was added, so the reserved bytes were redu= ced to > 3. > > However, this field was added after the first 3 bytes of the > > structure, causing it to be placed in an offset of 4 bytes, and > > therefore, forcing the mempool pointer to be placed after 16 bytes, > > instead of a 8 bytes, causing unintentionally the ABI breakage. > > > > This commit fixes the breakage, by swapping the reserved bytes and the > > private_data_offset field, so the latter is aligned to 2 bytes and the > > offset of the mempool pointer returns to its original offset, > > 8 bytes. > > > > Fixes: 54c836846603 ("cryptodev: set private data for session-less > > mode") > > Cc: stable@dpdk.org > > > > Reported-by: Konstantin Ananyev > > Signed-off-by: Pablo de Lara ... > Acked-by: Abhinandan Gujjar >=20 > > 2.17.0 Applied to dpdk-next-crypto. Pablo