From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Pattan, Reshma" <reshma.pattan@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] crypto/snow3g: add dynamic logging
Date: Wed, 4 Jul 2018 10:01:43 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8977F8E48C5@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A35E3B9@irsmsx110.ger.corp.intel.com>
Hi Reshma,
> -----Original Message-----
> From: Pattan, Reshma
> Sent: Wednesday, July 4, 2018 10:54 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] crypto/snow3g: add dynamic logging
>
> Hi Pablo,
>
> Also need to remove CONFIG_RTE_LIBRTE_PMD_SNOW3G_DEBUG flag.
I haven't removed it, because it is still used in the data path, so it wasn't used just for logging.
Thanks for the review.
Pablo
>
> Thanks,
> Reshma
>
> > -----Original Message-----
> > From: Pattan, Reshma
> > Sent: Wednesday, July 4, 2018 10:32 AM
> > To: 'Pablo de Lara' <pablo.de.lara.guarch@intel.com>; dev@dpdk.org
> > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> > Subject: RE: [dpdk-dev] [PATCH] crypto/snow3g: add dynamic logging
> >
> > Hi Pablo,
> >
> > > -----Original Message-----
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> > > Sent: Tuesday, July 3, 2018 5:37 AM
> > > To: dev@dpdk.org
> > > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> > > Subject: [dpdk-dev] [PATCH] crypto/snow3g: add dynamic logging diff
> > > --git a/drivers/crypto/snow3g/rte_snow3g_pmd.c
> > > b/drivers/crypto/snow3g/rte_snow3g_pmd.c
> > > index 72751e35e..bb990a07e 100644
> > > --- a/drivers/crypto/snow3g/rte_snow3g_pmd.c
> >
> > > +++ b/drivers/crypto/snow3g/rte_snow3g_pmd.c
> > > b/drivers/crypto/snow3g/rte_snow3g_pmd_ops.c
> >
> > Update year in license header, otherwise
> >
> > Acked-by: Reshma Pattan <reshma.pattan@intel.com>
next prev parent reply other threads:[~2018-07-04 10:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 4:37 Pablo de Lara
2018-07-04 9:32 ` Pattan, Reshma
2018-07-04 9:53 ` Pattan, Reshma
2018-07-04 10:01 ` De Lara Guarch, Pablo [this message]
2018-07-04 10:03 ` Pattan, Reshma
2018-07-05 16:12 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8977F8E48C5@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).