From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 3A7051BB20 for ; Thu, 5 Jul 2018 13:25:47 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Jul 2018 04:25:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,312,1526367600"; d="scan'208";a="52783640" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga008.fm.intel.com with ESMTP; 05 Jul 2018 04:25:45 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by IRSMSX151.ger.corp.intel.com ([169.254.4.216]) with mapi id 14.03.0319.002; Thu, 5 Jul 2018 12:25:44 +0100 From: "De Lara Guarch, Pablo" To: "Verma, Shally" , "Gupta, Ashish" , "Trahe, Fiona" , "Daly, Lee" , "Sahu, Sunila" CC: "dev@dpdk.org" Thread-Topic: [PATCH v3 3/4] compressdev: replace mbuf scatter gather flag Thread-Index: AQHUE+SqFZAarKy3JEOUxiwSTFll1aSAPqQAgAAtRoD///3BAIAAE3YQ Date: Thu, 5 Jul 2018 11:25:43 +0000 Message-ID: References: <20180627055031.24394-1-pablo.de.lara.guarch@intel.com> <20180704141037.44021-1-pablo.de.lara.guarch@intel.com> <20180704141037.44021-3-pablo.de.lara.guarch@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjNiNDljMDgtNTQ0My00OTA3LTk5NGEtMzNmMjA0MjY5ZWYxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNHpjbGh5U0VERmNZK1BLN0lCV2lMcmpMam9OK2xqNzh3UjVzZUpiN2NoUDNMeXJGOEJqQWlKM1FPTVdQMGRRTyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 3/4] compressdev: replace mbuf scatter gather flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jul 2018 11:25:47 -0000 > -----Original Message----- > From: Verma, Shally [mailto:Shally.Verma@cavium.com] > Sent: Thursday, July 5, 2018 12:13 PM > To: De Lara Guarch, Pablo ; Gupta, Ashish > ; Trahe, Fiona ; Daly, Le= e > ; Sahu, Sunila > Cc: dev@dpdk.org > Subject: RE: [PATCH v3 3/4] compressdev: replace mbuf scatter gather flag >=20 >=20 >=20 > >-----Original Message----- > >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com] > >Sent: 05 July 2018 16:36 > >To: Verma, Shally ; Gupta, Ashish > >; Trahe, Fiona ; Daly, > >Lee ; Sahu, Sunila > >Cc: dev@dpdk.org > >Subject: RE: [PATCH v3 3/4] compressdev: replace mbuf scatter gather > >flag > > > >External Email > > > >> -----Original Message----- > >> From: Verma, Shally [mailto:Shally.Verma@cavium.com] > >> Sent: Thursday, July 5, 2018 9:39 AM > >> To: De Lara Guarch, Pablo ; Gupta, > >> Ashish ; Trahe, Fiona > >> ; Daly, Lee ; Sahu, Sunila > >> > >> Cc: dev@dpdk.org > >> Subject: RE: [PATCH v3 3/4] compressdev: replace mbuf scatter gather > >> flag > >> > >> > >> > >> >-----Original Message----- > >> >From: Pablo de Lara [mailto:pablo.de.lara.guarch@intel.com] > >> >Sent: 04 July 2018 19:41 > >> >To: Verma, Shally ; Gupta, Ashish > >> >; fiona.trahe@intel.com; lee.daly@intel.com > >> >Cc: dev@dpdk.org; Pablo de Lara > >> >Subject: [PATCH v3 3/4] compressdev: replace mbuf scatter gather > >> >flag > >> > > >> >External Email > >> > > >> >The current mbuf scatter gather feature flag is too ambiguous, as it > >> >is not clear if input and/or output buffers can be scatter gather > >> >mbufs or not. > >> > > >> >Therefore, three new flags will replace this flag: > >> >- RTE_COMP_FF_OOP_SGL_IN_SGL_OUT > >> >- RTE_COMP_FF_OOP_SGL_IN_FB_OUT > >> >- RTE_COMP_FF_OOP_FB_IN_SGL_OUT > >> > > >> [Shally] Believe Out of place is default support on current > >> compression API, so why do we need _OOP_ here? > > > >Hi Shally, > > > >You are right, but I just wanted to clarify that the scenario is for Out= of place > only. > > > Ok. But that looks redundant to me. Though not likely, tomorrow if some a= lgo > support in-place, Then we will end up adding in_place equivalent of same.= So > would prefer to keep naming generic of in/out place and specific to Scatt= er- > gather in/out support. I think I am not quite following you. Actually, if in the future we support In-place, then it is important to have OOP in the macro, to specify that SG= L is supported for Out-of-place and maybe not in-place (like in cryptodev). Otherwise, we would need to break the API, which can be avoided now. Thanks, Pablo >=20 > >Thanks, > >Pablo > > > >> > >> Thanks > >> Shally > >> >Note that out-of-place flat buffers is supported by default and > >> >in-place is not supported by the library. > >> > > >> >Signed-off-by: Pablo de Lara > >> >Acked-by: Fiona Trahe