* [dpdk-dev] [PATCH] test/crypto: fix the devid testcases
@ 2018-07-04 9:49 Hemant Agrawal
2018-07-05 12:29 ` De Lara Guarch, Pablo
0 siblings, 1 reply; 3+ messages in thread
From: Hemant Agrawal @ 2018-07-04 9:49 UTC (permalink / raw)
To: pablo.de.lara.guarch; +Cc: dev, stable, declan.doherty
devid is valid, while ts_params->valid_devs[devid] may
result a different value in case multiple devices are present
and any of the device is being used.
Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests")
Cc: stable@dpdk.org
Cc: declan.doherty@intel.com
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
test/test/test_cryptodev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/test/test_cryptodev.c b/test/test/test_cryptodev.c
index 389f796..e252fee 100644
--- a/test/test/test_cryptodev.c
+++ b/test/test/test_cryptodev.c
@@ -585,7 +585,7 @@ test_device_configure_invalid_dev_id(void)
dev_id = ts_params->valid_devs[ts_params->valid_dev_count - 1];
/* Stop the device in case it's started so it can be configured */
- rte_cryptodev_stop(ts_params->valid_devs[dev_id]);
+ rte_cryptodev_stop(dev_id);
TEST_ASSERT_SUCCESS(rte_cryptodev_configure(dev_id, &ts_params->conf),
"Failed test for rte_cryptodev_configure: "
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] test/crypto: fix the devid testcases
2018-07-04 9:49 [dpdk-dev] [PATCH] test/crypto: fix the devid testcases Hemant Agrawal
@ 2018-07-05 12:29 ` De Lara Guarch, Pablo
2018-07-05 16:11 ` De Lara Guarch, Pablo
0 siblings, 1 reply; 3+ messages in thread
From: De Lara Guarch, Pablo @ 2018-07-05 12:29 UTC (permalink / raw)
To: Hemant Agrawal; +Cc: dev, stable, Doherty, Declan
> -----Original Message-----
> From: Hemant Agrawal [mailto:hemant.agrawal@nxp.com]
> Sent: Wednesday, July 4, 2018 10:50 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Doherty, Declan
> <declan.doherty@intel.com>
> Subject: [PATCH] test/crypto: fix the devid testcases
>
> devid is valid, while ts_params->valid_devs[devid] may result a different value in
> case multiple devices are present and any of the device is being used.
>
> Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests")
> Cc: stable@dpdk.org
> Cc: declan.doherty@intel.com
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] test/crypto: fix the devid testcases
2018-07-05 12:29 ` De Lara Guarch, Pablo
@ 2018-07-05 16:11 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 3+ messages in thread
From: De Lara Guarch, Pablo @ 2018-07-05 16:11 UTC (permalink / raw)
To: De Lara Guarch, Pablo, Hemant Agrawal; +Cc: dev, stable, Doherty, Declan
> -----Original Message-----
> From: stable [mailto:stable-bounces@dpdk.org] On Behalf Of De Lara Guarch,
> Pablo
> Sent: Thursday, July 5, 2018 1:29 PM
> To: Hemant Agrawal <hemant.agrawal@nxp.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Doherty, Declan
> <declan.doherty@intel.com>
> Subject: Re: [dpdk-stable] [PATCH] test/crypto: fix the devid testcases
>
>
>
> > -----Original Message-----
> > From: Hemant Agrawal [mailto:hemant.agrawal@nxp.com]
> > Sent: Wednesday, July 4, 2018 10:50 AM
> > To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> > Cc: dev@dpdk.org; stable@dpdk.org; Doherty, Declan
> > <declan.doherty@intel.com>
> > Subject: [PATCH] test/crypto: fix the devid testcases
> >
> > devid is valid, while ts_params->valid_devs[devid] may result a
> > different value in case multiple devices are present and any of the device is
> being used.
> >
> > Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance
> > tests")
> > Cc: stable@dpdk.org
> > Cc: declan.doherty@intel.com
> >
> > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Applied to dpdk-next-crypto.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-05 16:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-04 9:49 [dpdk-dev] [PATCH] test/crypto: fix the devid testcases Hemant Agrawal
2018-07-05 12:29 ` De Lara Guarch, Pablo
2018-07-05 16:11 ` De Lara Guarch, Pablo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).