From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 60C771C4DB for ; Fri, 6 Jul 2018 10:59:14 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jul 2018 01:59:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,315,1526367600"; d="scan'208";a="54859495" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga008.jf.intel.com with ESMTP; 06 Jul 2018 01:59:12 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by IRSMSX151.ger.corp.intel.com ([169.254.4.36]) with mapi id 14.03.0319.002; Fri, 6 Jul 2018 09:59:11 +0100 From: "De Lara Guarch, Pablo" To: "Verma, Shally" , "Gupta, Ashish" , "Trahe, Fiona" , "Daly, Lee" , "Sahu, Sunila" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 3/4] compressdev: replace mbuf scatter gather flag Thread-Index: AQHUFQbQmYitgno7E0qT8YYZh/NWzaSB5OYA Date: Fri, 6 Jul 2018 08:59:10 +0000 Message-ID: References: <20180627055031.24394-1-pablo.de.lara.guarch@intel.com> <20180704141037.44021-1-pablo.de.lara.guarch@intel.com> <20180704141037.44021-3-pablo.de.lara.guarch@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDdjODU4YTItMGQzZS00NTk0LWFjZDEtZTc0MDQ0MDZlZTcwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVUJzaTFKNW5GdWhOTEhVZkVDaUxlTk9wdUVDOHlKd0kya1F1a1FUSkNIXC9YeXNBQjRvdVZrV3pRM0ZZTWZwbG0ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 3/4] compressdev: replace mbuf scatter gather flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jul 2018 08:59:15 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Verma, Shally > Sent: Friday, July 6, 2018 9:53 AM > To: De Lara Guarch, Pablo ; Gupta, Ashish > ; Trahe, Fiona ; Daly, Le= e > ; Sahu, Sunila > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 3/4] compressdev: replace mbuf scatter > gather flag >=20 >=20 >=20 > >-----Original Message----- > >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com] > >Sent: 06 July 2018 14:10 > >To: Verma, Shally ; Gupta, Ashish > >; Trahe, Fiona ; Daly, > >Lee ; Sahu, Sunila > >Cc: dev@dpdk.org > >Subject: RE: [PATCH v3 3/4] compressdev: replace mbuf scatter gather > >flag > > >=20 > //snip >=20 > >> Ohh okay, now I get it. So these feature flags intend to show > >> input/output mode supported specifically for in/out of place > >> operations. But then still I see having OOP isn't required as > >> compression default support is out-of-place and it's just making > >> feature name too big. Having in-place is exception and if supported, > >> can use convention RTE_COMP_FF_INPLACE_xx > > > >I would still prefer having OOP, to be consistent with cryptodev. It is = also not > that long, it is just 3 letters. > > > >> > >> Above one comment, as I see it, use of FB in > >> RTE_COMP_FF_OOP_FB_IN_SGL_OUT didn't give clear indication what it > mean. > >> May be replace it by RTE_COMP_FF_OOP_DIRECT/LINEAR_IN_SGL_OUT > > > >Linear could be a good option, but it is missing a noun there. What abou= t LB > (linear buffer), so we keep it short too. >=20 > Ok. LB looks fine. hopefully, that will make apparent to reader, that it'= s opposite > of Scatter-Gather. I can clarify a bit more in the comments. Thanks, Pablo >=20 > Thanks > Shally >=20 > > > >Pablo