From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id B379E5B14 for ; Mon, 9 Jul 2018 10:07:07 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jul 2018 01:07:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,329,1526367600"; d="scan'208";a="69741131" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga004.fm.intel.com with ESMTP; 09 Jul 2018 01:07:03 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by IRSMSX106.ger.corp.intel.com ([169.254.8.211]) with mapi id 14.03.0319.002; Mon, 9 Jul 2018 09:07:02 +0100 From: "De Lara Guarch, Pablo" To: "Verma, Shally" , "Gupta, Ashish" , "Trahe, Fiona" , "Daly, Lee" CC: "dev@dpdk.org" Thread-Topic: [PATCH v5 3/4] compressdev: replace mbuf scatter gather flag Thread-Index: AQHUFS33WL6CqBO4uUipK9sNaPwmLqSDPeqAgANOuYA= Date: Mon, 9 Jul 2018 08:07:02 +0000 Message-ID: References: <20180627055031.24394-1-pablo.de.lara.guarch@intel.com> <20180706052801.12901-1-pablo.de.lara.guarch@intel.com> <20180706052801.12901-3-pablo.de.lara.guarch@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDNmNTgyY2QtNjA0Mi00NjNiLTg3NTItZDc3MzczZjIxYmY1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVjc2ZkZuNDZCTmRXYm02SURGckROREZwR1hoMDN5d1pZbkg3Qm9rb1Z3cTBuUXBSMEkzSFkxV2hsRXlzSU42bSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 3/4] compressdev: replace mbuf scatter gather flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2018 08:07:08 -0000 > -----Original Message----- > From: Verma, Shally [mailto:Shally.Verma@cavium.com] > Sent: Saturday, July 7, 2018 7:34 AM > To: De Lara Guarch, Pablo ; Gupta, Ashish > ; Trahe, Fiona ; Daly, Le= e > > Cc: dev@dpdk.org > Subject: RE: [PATCH v5 3/4] compressdev: replace mbuf scatter gather flag >=20 >=20 >=20 > >-----Original Message----- > >From: Pablo de Lara [mailto:pablo.de.lara.guarch@intel.com] > >Sent: 06 July 2018 10:58 > >To: Verma, Shally ; Gupta, Ashish > >; fiona.trahe@intel.com; lee.daly@intel.com > >Cc: dev@dpdk.org; Pablo de Lara > >Subject: [PATCH v5 3/4] compressdev: replace mbuf scatter gather flag > > > >External Email > > > >The current mbuf scatter gather feature flag is too ambiguous, as it is > >not clear if input and/or output buffers can be scatter gather mbufs or > >not. > > > >Therefore, three new flags will replace this flag: > >- RTE_COMP_FF_OOP_SGL_IN_SGL_OUT > >- RTE_COMP_FF_OOP_SGL_IN_FB_OUT > >- RTE_COMP_FF_OOP_LB_IN_SGL_OUT > > > >Note that out-of-place flat buffers is supported by default and > >in-place is not supported by the library. > > > >Signed-off-by: Pablo de Lara > >Acked-by: Fiona Trahe > >--- > > > >v5: > >- Replaced left "Flat Buffer" with "Linear Buffer" (Shally) > >- Rephrased comment about new feature flags (Shally) > > > >v4: > >- Replaced FB (Flat Buffers) with LB (Linear Buffers) (Shally) > >- Add extra explanation on comments about Linear Buffers vs > > Scatter-gather lists > > > >v3: > >- Replaced Out-of-place with OOP > >- Added new feature flags in default.ini > > > >v2: > >- Fixed typos > >- Rephrased comments > > > > doc/guides/compressdevs/features/default.ini | 34 +++++++++++++++------= ---- > --- > > doc/guides/compressdevs/overview.rst | 14 ++++++++++++ > > doc/guides/rel_notes/release_18_08.rst | 6 +++++ > > lib/librte_compressdev/rte_comp.c | 8 +++++-- > > lib/librte_compressdev/rte_comp.h | 31 +++++++++++++++++----= ---- > > 5 files changed, 65 insertions(+), 28 deletions(-) > > > ... >=20 > >diff --git a/doc/guides/compressdevs/overview.rst > >b/doc/guides/compressdevs/overview.rst > >index d01c1a966..70bbe82b7 100644 > >--- a/doc/guides/compressdevs/overview.rst > >+++ b/doc/guides/compressdevs/overview.rst > >@@ -16,3 +16,17 @@ Supported Feature Flags > > - "Pass-through" feature flag refers to the ability of the PMD > > to let input buffers pass-through it, copying the input to the out= put, > > without making any modifications to it (no compression done). > >+ > >+ - "OOP SGL In SGL Out" feature flag stands for > >+ "Out-of-place Scatter-gather list Input, Scatter-gater list Output= ", > >+ which means PMD supports different scatter-gather styled input and= output > buffers > >+ (i.e. both can consists of multiple segments). > >+ > >+ - "OOP SGL In LB Out" feature flag stands for > >+ "Out-of-place Scatter-gather list Input, Linear Buffers Output", > >+ which means PMD supports input from scatter-gathered styled buffer= s, > outputting linear buffers > >+ (i.e. single segment). > >+ > >+ - "OOP LB In SGL Out" feature flag stands for > >+ "Out-of-place Linear Buffers Input, Scatter-gather list Output", > >+ which means PMD supports input from linear buffer, outputting scat= ter- > gathered styled buffers. >=20 > .... >=20 > >diff --git a/lib/librte_compressdev/rte_comp.h > >b/lib/librte_compressdev/rte_comp.h > >index 5b513c77e..274b5eadf 100644 > >--- a/lib/librte_compressdev/rte_comp.h > >+++ b/lib/librte_compressdev/rte_comp.h > >@@ -30,23 +30,34 @@ extern "C" { > > /**< Stateful compression is supported */ > > #define RTE_COMP_FF_STATEFUL_DECOMPRESSION (1ULL << 1) > > /**< Stateful decompression is supported */ > >-#define RTE_COMP_FF_MBUF_SCATTER_GATHER (1ULL << 2) > >-/**< Scatter-gather mbufs are supported */ > >-#define RTE_COMP_FF_ADLER32_CHECKSUM (1ULL << 3) > >+#define RTE_COMP_FF_OOP_SGL_IN_SGL_OUT (1ULL << 2) > >+/**< Out-of-place Scatter-gather (SGL) buffers, > >+ * with multiple segments, are supported in input and output */ > >+#define RTE_COMP_FF_OOP_SGL_IN_LB_OUT (1ULL << 3) > >+/**< Out-of-place Scatter-gather (SGL) buffers are supported > >+ * in input, combined with linear buffers (LB), with a > >+ * single segment, in output > >+ */ > >+#define RTE_COMP_FF_OOP_LB_IN_SGL_OUT (1ULL << 4) > >+/**< Out-of-place Scatter-gather (SGL) mbufs are supported > >+ * in output, combined with linear buffers (LB) in input */ > [Shally] Similar rephrase here please. Ok, I am replacing "mbufs" with "buffers". I won't clarify what SGL and LB = means, as it is done in the previous macros. I will make this change on the fly as I am applying this patch, as it is th= e last comment, I believe. Thanks, Pablo >=20 > Rest, > Acked-by: Shally Verma