From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 9D7101B432 for ; Mon, 9 Jul 2018 16:20:14 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jul 2018 07:20:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,330,1526367600"; d="scan'208";a="214523607" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga004.jf.intel.com with ESMTP; 09 Jul 2018 07:20:11 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by IRSMSX101.ger.corp.intel.com ([169.254.1.185]) with mapi id 14.03.0319.002; Mon, 9 Jul 2018 15:20:10 +0100 From: "De Lara Guarch, Pablo" To: "Wang, Yipeng1" CC: "dev@dpdk.org" , "Richardson, Bruce" , "honnappa.nagarahalli@arm.com" , "vguvva@caviumnetworks.com" , "brijesh.s.singh@gmail.com" Thread-Topic: [PATCH v3 3/8] hash: fix to have more accurate key slot size Thread-Index: AQHUFZ3CEJZP664tEkScUanG6w8qBKSG8++g Date: Mon, 9 Jul 2018 14:20:09 +0000 Message-ID: References: <1528455078-328182-1-git-send-email-yipeng1.wang@intel.com> <1530906406-289697-1-git-send-email-yipeng1.wang@intel.com> <1530906406-289697-4-git-send-email-yipeng1.wang@intel.com> In-Reply-To: <1530906406-289697-4-git-send-email-yipeng1.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDdiYmZjNmEtMDMwZC00YjAxLTk0NmYtZjRmNjMxOWFkYWM0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSDUrWisyWTg0QzRObUM3QU9KUFVzK21ZWlhrcjVVdlNJbWVvemZNdzJ4SmRkMHJNY3VOTzdKZjhUXC9iZXF6WngifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 3/8] hash: fix to have more accurate key slot size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2018 14:20:15 -0000 > -----Original Message----- > From: Wang, Yipeng1 > Sent: Friday, July 6, 2018 8:47 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Wang, Yipeng1 ; Richardson, > Bruce ; honnappa.nagarahalli@arm.com; > vguvva@caviumnetworks.com; brijesh.s.singh@gmail.com > Subject: [PATCH v3 3/8] hash: fix to have more accurate key slot size Titles always start with a verb whereas in your case, you are starting with= a noun. Better to change it to "fix key slot size accuracy"? Apart from that: Acked-by: Pablo de Lara >=20 > This commit calculates the needed key slot size more accurately. The prev= ious > local cache fix requires the free slot ring to be larger than actually ne= eded. > The calculation of the value is inaccurate. >=20 > Fixes: 5915699153d7 ("hash: fix scaling by reducing contention") > Cc: stable@dpdk.org